[0/3] Fix dtbs warnings for arch timer

Message

Kuldeep Singh March 16, 2022, 9:54 a.m. UTC

This patchset is an attempt to resolve 'make dtbs_check' warning for
arch timer.

Patch 1 is done in preparation for following patches which defines
compatibles order in more clear way.
Patch 2 documents arm,cortex-a7-timer entry in bindings similar to an
existing entry arm,cortex-a15-timer.
Patch 3 adds above 2 properties in of_match list to bring them in
use. 

Please note, this patchset is based on
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, master

Kuldeep Singh (3):
  dt-bindings: timer: Rearrange compatible entries of arch timer
  dt-bindings: timer: Document arm,cortex-a7-timer for arch timer
  clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list

 .../devicetree/bindings/timer/arm,arch_timer.yaml   | 13 +++++--------
 drivers/clocksource/arm_arch_timer.c                |  2 ++
 2 files changed, 7 insertions(+), 8 deletions(-)

Comments

Marc Zyngier March 16, 2022, 11:27 a.m. UTC | #1

On 2022-03-16 09:54, Kuldeep Singh wrote:
> This patchset is an attempt to resolve 'make dtbs_check' warning for
> arch timer.
> 
> Patch 1 is done in preparation for following patches which defines
> compatibles order in more clear way.
> Patch 2 documents arm,cortex-a7-timer entry in bindings similar to an
> existing entry arm,cortex-a15-timer.
> Patch 3 adds above 2 properties in of_match list to bring them in
> use.
> 
> Please note, this patchset is based on
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, 
> master
> 
> Kuldeep Singh (3):
>   dt-bindings: timer: Rearrange compatible entries of arch timer
>   dt-bindings: timer: Document arm,cortex-a7-timer for arch timer
>   clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list
> 
>  .../devicetree/bindings/timer/arm,arch_timer.yaml   | 13 +++++--------
>  drivers/clocksource/arm_arch_timer.c                |  2 ++
>  2 files changed, 7 insertions(+), 8 deletions(-)

Please use my @kernel.org address exclusively. My @arm.com
address stopped working over two years ago, and the MAINTAINERS
file shows the right addresses.

Thanks,

         M.

Kuldeep Singh March 16, 2022, 5:20 p.m. UTC | #2

On Wed, Mar 16, 2022 at 11:27:10AM +0000, Marc Zyngier wrote:
> On 2022-03-16 09:54, Kuldeep Singh wrote:
> > This patchset is an attempt to resolve 'make dtbs_check' warning for
> > arch timer.
> > 
> > Patch 1 is done in preparation for following patches which defines
> > compatibles order in more clear way.
> > Patch 2 documents arm,cortex-a7-timer entry in bindings similar to an
> > existing entry arm,cortex-a15-timer.
> > Patch 3 adds above 2 properties in of_match list to bring them in
> > use.
> > 
> > Please note, this patchset is based on
> > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, master
> > 
> > Kuldeep Singh (3):
> >   dt-bindings: timer: Rearrange compatible entries of arch timer
> >   dt-bindings: timer: Document arm,cortex-a7-timer for arch timer
> >   clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list
> > 
> >  .../devicetree/bindings/timer/arm,arch_timer.yaml   | 13 +++++--------
> >  drivers/clocksource/arm_arch_timer.c                |  2 ++
> >  2 files changed, 7 insertions(+), 8 deletions(-)
> 
> Please use my @kernel.org address exclusively. My @arm.com
> address stopped working over two years ago, and the MAINTAINERS
> file shows the right addresses.

Hi Marc,

I have tocmd and cccmd set in my gitconfig and it generated mail
addresses automatically so I assume it is correct.
tocmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nol"

It seems your arm mail address got configured from binding file and not
from MAINTAINERS.

Regards
Kuldeep

> 
> Thanks,
> 
>         M.
> -- 
> Jazz is not dead. It just smells funny...

Marc Zyngier March 16, 2022, 6:47 p.m. UTC | #3

On Wed, 16 Mar 2022 17:20:51 +0000,
Kuldeep Singh <[e-mail]> wrote:
> 
> On Wed, Mar 16, 2022 at 11:27:10AM +0000, Marc Zyngier wrote:
> > On 2022-03-16 09:54, Kuldeep Singh wrote:
> > > This patchset is an attempt to resolve 'make dtbs_check' warning for
> > > arch timer.
> > > 
> > > Patch 1 is done in preparation for following patches which defines
> > > compatibles order in more clear way.
> > > Patch 2 documents arm,cortex-a7-timer entry in bindings similar to an
> > > existing entry arm,cortex-a15-timer.
> > > Patch 3 adds above 2 properties in of_match list to bring them in
> > > use.
> > > 
> > > Please note, this patchset is based on
> > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, master
> > > 
> > > Kuldeep Singh (3):
> > >   dt-bindings: timer: Rearrange compatible entries of arch timer
> > >   dt-bindings: timer: Document arm,cortex-a7-timer for arch timer
> > >   clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list
> > > 
> > >  .../devicetree/bindings/timer/arm,arch_timer.yaml   | 13 +++++--------
> > >  drivers/clocksource/arm_arch_timer.c                |  2 ++
> > >  2 files changed, 7 insertions(+), 8 deletions(-)
> > 
> > Please use my @kernel.org address exclusively. My @arm.com
> > address stopped working over two years ago, and the MAINTAINERS
> > file shows the right addresses.
> 
> Hi Marc,
> 
> I have tocmd and cccmd set in my gitconfig and it generated mail
> addresses automatically so I assume it is correct.
> tocmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nol"
> 
> It seems your arm mail address got configured from binding file and not
> from MAINTAINERS.

It is a bug in get_maintainer.pl. You'll have to manually apply the
.mailmap transformation.

	M.

Rob Herring (Arm) March 23, 2022, 7:38 p.m. UTC | #4

On Wed, Mar 16, 2022 at 06:47:47PM +0000, Marc Zyngier wrote:
> On Wed, 16 Mar 2022 17:20:51 +0000,
> Kuldeep Singh <[e-mail]> wrote:
> > 
> > On Wed, Mar 16, 2022 at 11:27:10AM +0000, Marc Zyngier wrote:
> > > On 2022-03-16 09:54, Kuldeep Singh wrote:
> > > > This patchset is an attempt to resolve 'make dtbs_check' warning for
> > > > arch timer.
> > > > 
> > > > Patch 1 is done in preparation for following patches which defines
> > > > compatibles order in more clear way.
> > > > Patch 2 documents arm,cortex-a7-timer entry in bindings similar to an
> > > > existing entry arm,cortex-a15-timer.
> > > > Patch 3 adds above 2 properties in of_match list to bring them in
> > > > use.
> > > > 
> > > > Please note, this patchset is based on
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, master
> > > > 
> > > > Kuldeep Singh (3):
> > > >   dt-bindings: timer: Rearrange compatible entries of arch timer
> > > >   dt-bindings: timer: Document arm,cortex-a7-timer for arch timer
> > > >   clocksource: arch_timer: Add arm,cortex-a7/15-timer in of_match list
> > > > 
> > > >  .../devicetree/bindings/timer/arm,arch_timer.yaml   | 13 +++++--------
> > > >  drivers/clocksource/arm_arch_timer.c                |  2 ++
> > > >  2 files changed, 7 insertions(+), 8 deletions(-)
> > > 
> > > Please use my @kernel.org address exclusively. My @arm.com
> > > address stopped working over two years ago, and the MAINTAINERS
> > > file shows the right addresses.
> > 
> > Hi Marc,
> > 
> > I have tocmd and cccmd set in my gitconfig and it generated mail
> > addresses automatically so I assume it is correct.
> > tocmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nol"
> > 
> > It seems your arm mail address got configured from binding file and not
> > from MAINTAINERS.
> 
> It is a bug in get_maintainer.pl. You'll have to manually apply the
> .mailmap transformation.

I just sent a fix for this[1]. 'in file' emails were not honoring 
mailmap.

Rob

[1] https://lore.kernel.org/all/[e-mail]/