mbox series

[v2,0/2] Enable orphan-handling=warn for VDSO

Message ID 20220407101304.539-1-joey.gouly@arm.com (mailing list archive)
Headers show
Series Enable orphan-handling=warn for VDSO | expand

Message

Joey Gouly April 7, 2022, 10:13 a.m. UTC 
Hi all,

This small series enables the orphan-handling linker flag for the VDSO.
This could catch subtle errors if features that use special sections are
introduced into the VDSO implementation.

Changes from v1[1]:
  - Include vmlinux.ld.h directly, to use macros
  - Include DWARF sections in linker script

Thanks,
Joey

[1]: https://lore.kernel.org/linux-arm-kernel/20220405160246.1991-1-joey.gouly@arm.com/

Joey Gouly (2):
  arm64: vdso: put ELF related sections in the linker script
  arm64: vdso: enable orphan handling for VDSO

 arch/arm64/kernel/vdso/Makefile   | 8 +++++++-
 arch/arm64/kernel/vdso/vdso.lds.S | 4 ++++
 2 files changed, 11 insertions(+), 1 deletion(-)

Comments

Vincenzo Frascino April 8, 2022, 7:22 a.m. UTC | #1 
Hi Joey,

On 4/7/22 11:13 AM, Joey Gouly wrote:
> Hi all,
> 
> This small series enables the orphan-handling linker flag for the VDSO.
> This could catch subtle errors if features that use special sections are
> introduced into the VDSO implementation.
> 
> Changes from v1[1]:
>   - Include vmlinux.ld.h directly, to use macros
>   - Include DWARF sections in linker script
> 

The change looks fine to me. I have only one question, is there any specific
reason why we do have the same for compat vDSO?

> Thanks,
> Joey
> 
> [1]: https://lore.kernel.org/linux-arm-kernel/20220405160246.1991-1-joey.gouly@arm.com/
> 
> Joey Gouly (2):
>   arm64: vdso: put ELF related sections in the linker script
>   arm64: vdso: enable orphan handling for VDSO
> 
>  arch/arm64/kernel/vdso/Makefile   | 8 +++++++-
>  arch/arm64/kernel/vdso/vdso.lds.S | 4 ++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
>
Joey Gouly April 12, 2022, 10:04 a.m. UTC | #2 
Hi Vincenzo,

Thanks for the reviews (and Kees too)!

Having issues with e-mail, hopefully this gets through!

On Fri, Apr 08, 2022 at 08:22:49AM +0100, Vincenzo Frascino wrote:
> Hi Joey,
> 
> On 4/7/22 11:13 AM, Joey Gouly wrote:
> > Hi all,
> > 
> > This small series enables the orphan-handling linker flag for the VDSO.
> > This could catch subtle errors if features that use special sections are
> > introduced into the VDSO implementation.
> > 
> > Changes from v1[1]:
> >   - Include vmlinux.ld.h directly, to use macros
> >   - Include DWARF sections in linker script
> > 
> 
> The change looks fine to me. I have only one question, is there any specific
> reason why we do have the same for compat vDSO?

No reason, just that I only test arm64. I will build and test 32-bit and send out
a v3.

Thanks,
Joey
Vincenzo Frascino April 12, 2022, 10:05 a.m. UTC | #3 
On 4/12/22 11:04 AM, Joey Gouly wrote:
> No reason, just that I only test arm64. I will build and test 32-bit and send out
> a v3.

Thank you :)