From patchwork Tue Apr 12 15:48:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 12810902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4B0EC433EF for ; Tue, 12 Apr 2022 15:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Mime-Version: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=z/ZORIpYJYBOuMpT5DrlueBOyEtBD3rZvYwynVXc1YM=; b=SUs RGOSbmlpyLoA2CjVC6c7ijGyBDO14ic7tMsjbLXHTiJp6XiA15imDLsQgDHNmlvkhR8hLMKGJs2+b 2DPwXqKb+sKRmRuzTKScqvXODA5tcGrkKe8Dc+0d7+tyTGXM3uP/1pABZ6pqljx7A8v30bm3atGaT jPV6rjeW9M8NPlX+pCV83hZs2Y/eTZUA7QIPt7DBeiFG9Udq0bFaRmBNUEPI7hP/6JO3If5Ft+QVY NDdEApZKhsxkzK95+Kt8rJLXcD1AcT0G1irO8BSzq5i58+NUDrdK0uXRnTZ17NqRNAGdomssbhcuV l3fMpLMiHxYNewLbtqxsdfK9zmuWbDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neIkn-00Ezr4-Au; Tue, 12 Apr 2022 15:48:29 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neIkk-00EznT-6T for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 15:48:27 +0000 Received: by mail-yb1-xb49.google.com with SMTP id d129-20020a254f87000000b006411bf3f331so7861863ybb.4 for ; Tue, 12 Apr 2022 08:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=8IZz/gMylCpP1gVOy3Mzg8c3y39Rz/6oTdnON/BPbbo=; b=nozrEXfagyw88Rss5WjQoaW+QrAP05xY/u0NdTER42+HrNPzXBnVSeJMVV1t4f1tuk blSVnwX63Ntsee0BrggFx1BX7hqrWUE+/lheMmBq4lLmaGVbOnNzrH3RMNh/aYIYEC7m gkyaLUH7heh/Bagv6Tc7TIuyIYrzP9V8RZn/U4DS5KheteWxYjSJ7u/6J0we0EIJ0NC9 AsCP7aaf3Kb42hs6Lw2WxNxA8rsk6dSAiF1hRAoqmSeTeb13PJFeWlHtOGKWUJ5C2+Ue xLJls2OFlXo9elbttQXMs1LNWl87IVZaVxDY+tNaz/W/C6bgwKop6uSP1HPb7zpVPwZ0 gtWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=8IZz/gMylCpP1gVOy3Mzg8c3y39Rz/6oTdnON/BPbbo=; b=z7ZKktrMm9LeWIVklbL0gxXX5VjUWo1odN367/KwtI/nEeoo825Aw37KHmpgnCi1Lh poJ/CXDSLKVn9TTK1z7kpLya9Cgj+5Vyt7yoaiMHS+9WE31INHZTPsLiNY8MViijFBA8 IkYgKmEYLL6jwSpdbMDay1LLZHSga9KEbLrUG/ipfbAl1MUgbh2CRoBHFMO5m/2BU19Z goX63KRWyd/UX+wj77sbRNRltFFAfNX9/Q3sQYArHExqggDsEG+myaO4zv7um/GHsj/x /H4ScUe59jnAugkZGOf+5Fsi6iCvHM6YYTK3FD59m3/T3eDRF7+yF8Ja1Avf+67ctVoE OKAQ== X-Gm-Message-State: AOAM533dchUP6qUvXiAtx2hJzw1lEDqXH8bdfc2GSbIX+2fKzNWe6m56 F2hhWhG54ub2KIXWJ410Jvu1KM7gbGV6 X-Google-Smtp-Source: ABdhPJy450ML0VeLyDFpbPqaekYj5Wh+ytMVAvRr1v5nwfqBAHYtbYtXW7oIiYzIflTqKubXTCVh9Baufz9i X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:5f6f:a698:92a:5d45]) (user=irogers job=sendgmr) by 2002:a5b:cc:0:b0:63d:897a:ddab with SMTP id d12-20020a5b00cc000000b0063d897addabmr25252581ybp.110.1649778502201; Tue, 12 Apr 2022 08:48:22 -0700 (PDT) Date: Tue, 12 Apr 2022 08:48:13 -0700 Message-Id: <20220412154817.2728324-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.1.1178.g4f1659d476-goog Subject: [PATCH v2 0/4] Tidy up symbol end fixup From: Ian Rogers To: John Garry , Will Deacon , Mathieu Poirier , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , James Clark , Alexandre Truong , German Gomez , Ian Rogers , Dave Marchevsky , Song Liu , Ravi Bangoria , Li Huafei , " =?utf-8?q?Martin_Li=C5=A1ka?= " , William Cohen , Riccardo Mancini , Masami Hiramatsu , Thomas Richter , Lexi Shao , Remi Bernon , Michael Petlan , Denis Nikitin , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_084826_271880_780F16BE X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fixing up more symbol ends as introduced in: https://lore.kernel.org/lkml/20220317135536.805-1-mpetlan@redhat.com/ caused perf annotate to run into memory limits - every symbol holds all the disassembled code in the annotation, and so making symbols ends further away dramatically increased memory usage (40MB to >1GB). Modify the symbol end logic so that special kernel cases aren't applied in the common case. v2. Drops a merged patch. Fixes a build issue with libbfd enabled. Ian Rogers (4): perf symbols: Always do architecture specific fixups perf symbols: Add is_kernel argument to fixup end perf symbol: By default only fix zero length symbols perf symbols: More specific architecture end fixing tools/perf/arch/arm64/util/machine.c | 14 +++++++++----- tools/perf/arch/powerpc/util/machine.c | 10 +++++++--- tools/perf/arch/s390/util/machine.c | 12 ++++++++---- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol.c | 16 +++++++++------- tools/perf/util/symbol.h | 4 ++-- 6 files changed, 36 insertions(+), 22 deletions(-) Signed-off-by: Ian Rogers