From patchwork Wed Apr 13 06:54:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Garg X-Patchwork-Id: 12811621 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E119C433F5 for ; Wed, 13 Apr 2022 06:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Ym/OItbsWnqNdIzkalb2/lW1/57HBgCvENBw1XOnSD8=; b=Zt+q8znHIetfNf VLHVUOzP/nyHH80Kj63FFvtAYiqzjohULu89U64TXAHiLpsl9uP0pADG17ScyJcuzdbrRz+H/5xsZ PWgmn5xCmo6vejDni2tNKrzJEbuxOU0kK0sTq8rVoXye5B0UBIWJpkGvJx2vFPXEoQhabE2phgFCP T8I06qNxc/1Uf8tK7c2Vup0CC2x7RlrN69YHWJOvNl1mp/p06cTKyfSUpNlcDHNSXJVHR1l5+FqxB Dj2KGZMFCBg8Plv1BzD/7qm+BvTYASgv9cwOMo2WmT/KWU27CA0+ZiCfY1VTVAFegytmH3hR7Mpiq fyIYfcayfc0NHO5XSxIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neWuN-00HIaw-KE; Wed, 13 Apr 2022 06:55:19 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neWuJ-00HIaN-Va for linux-arm-kernel@lists.infradead.org; Wed, 13 Apr 2022 06:55:17 +0000 Received: by mail-pj1-x102f.google.com with SMTP id mp16-20020a17090b191000b001cb5efbcab6so5350033pjb.4 for ; Tue, 12 Apr 2022 23:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NTNvsaYQsVOBKwXhFRizlr6gNAaZNdWVxUOJaeUiNZE=; b=j+3PZTmYmUVLvMaCvmv87lqY2I3xXpgpzEiA42kI+lTOaVCqI+5d7VDErZIGYwhOCT pwddTg9Nrtb/asc9nxKYwgf0WETpAqYxYktp8tbEEzOJ1NH2ZcMXGQ9Iq6EPWJfcQ5Wi iEZvqxhUpSSuDGXtL0CjHCjdAVHxBbVbNoizO9BpIbCQWDixVOH+D8R49FP6FpW+EchY f3u+6v1+GhKtReSPJgYxvj7NxEcNs50Ukf8p3Z/MhUI7p6O6zlQkYRgEo4hjK7B5Z5bs qusUb5fxdVYYDRZfk3ZAKoOrMbIMfJDDgQPBnJVpY7dxetqpW1kw/8GCHVrE9e4ZewuT WGbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NTNvsaYQsVOBKwXhFRizlr6gNAaZNdWVxUOJaeUiNZE=; b=WFdUOXzGXdaziYEVFoI+KtXMPpetTlP791P/g4rfu1jPE7YH14mcT1og3/Hj+o2gJ2 bfNSLhgVZ9aDHVWI6WNahdZgShUdOYF7AtgQo500hIwfVM9BQAhiQBZc6VhMOIp3XXpO 8wVd8wx5cvRHxt2GJ8tfilqR765vMCQonOVHS4QlEiaoFAaF7JBZ8xfoi6R8sa3txfOn 6n47x2aiKz/exwIw++9ZzdbUtadRQkhb5tCCDzNsQeLsq5GZjnScBZ0Z9pCZ3yp88Pz9 8LtVtUIwuIOi8S1xvFnGITWixfLCuTnw6WMeZXaBzkOgzi+ca5pY1NX73EtTE5RoiW+q 943w== X-Gm-Message-State: AOAM530hf/fHLiKQNIGetNT9mZiwl3me33cTIaHVX2ebBQunFKAzDgMQ eK3kQhVgk4XooVjEhq+1dg85NZhU6x/fdTVW X-Google-Smtp-Source: ABdhPJyvFxG274Zs7yDnH2SyWAserZi3+Y7NKJp2WGbghG9SqGQxo7K8enBdXjaEmi/lXRb4P9De2A== X-Received: by 2002:a17:90a:430d:b0:1bc:f340:8096 with SMTP id q13-20020a17090a430d00b001bcf3408096mr8920797pjg.93.1649832913843; Tue, 12 Apr 2022 23:55:13 -0700 (PDT) Received: from localhost.localdomain ([223.177.215.72]) by smtp.gmail.com with ESMTPSA id m15-20020a638c0f000000b003827bfe1f5csm4926908pgd.7.2022.04.12.23.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 23:55:13 -0700 (PDT) From: Sumit Garg To: linux-arm-kernel@lists.infradead.org, dianders@chromium.org, will@kernel.org, liwei391@huawei.com Cc: catalin.marinas@arm.com, mark.rutland@arm.com, mhiramat@kernel.org, daniel.thompson@linaro.org, jason.wessel@windriver.com, maz@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: [PATCH v2 0/2] arm64: Fix pending single-step debugging issues Date: Wed, 13 Apr 2022 12:24:56 +0530 Message-Id: <20220413065458.88541-1-sumit.garg@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_235516_061096_F7699DC9 X-CRM114-Status: UNSURE ( 9.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This patch-set reworks pending fixes from Wei's series [1] to make single-step debugging via kgdb/kdb on arm64 work as expected. There was a prior discussion on ML [2] regarding if we should keep the interrupts enabled during single-stepping. So patch #1 follows suggestion from Will [3] to not disable interrupts during single stepping but rather skip single stepping within interrupt handler. [1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/ [2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/ [3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/ Changes in v2: - Replace patch #1 to rather follow Will's suggestion. Sumit Garg (2): arm64: entry: Skip single stepping interrupt handlers arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step arch/arm64/include/asm/debug-monitors.h | 1 + arch/arm64/kernel/debug-monitors.c | 5 +++++ arch/arm64/kernel/entry-common.c | 18 +++++++++++++++++- arch/arm64/kernel/kgdb.c | 2 ++ 4 files changed, 25 insertions(+), 1 deletion(-)