| Message ID | 20220517101514.21639-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dt-bindings: arm: MediaTek: Fix clock bindings | expand |
On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: > As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for > which I've used the already upstreamed ones as a base, it was found that > these bindings have some issues. > This series is addressing the issues that were found by Rob on my series, > which are present on all of the already merged bindings. > > [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 I would say we could squash patches here and make it 3 instead of 6. In any case for the whole series: Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > > AngeloGioacchino Del Regno (6): > dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix > formatting > dt-bindings: arm: mt8186: Set #clock-cells as required property > dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix > formatting > dt-bindings: arm: mt8195: Set #clock-cells as required property > dt-bindings: arm: mt8192-clock: Remove unnecessary 'items' > dt-bindings: arm: mt8192: Set #clock-cells as required property > > .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- > .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- > .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- > .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > 6 files changed, 71 insertions(+), 66 deletions(-) >
Il 17/05/22 15:39, Matthias Brugger ha scritto: > > > On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote: >> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for >> which I've used the already upstreamed ones as a base, it was found that >> these bindings have some issues. >> This series is addressing the issues that were found by Rob on my series, >> which are present on all of the already merged bindings. >> >> [1]: >> https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 >> > > I would say we could squash patches here and make it 3 instead of 6. > In any case for the whole series: > > Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > I had the same initial idea, but chose to do it in 6 patches because otherwise the titles would be too generic and not really effectual in the end... If anyone wants them squashed, now you know what was my difficulty and my reasons :-) By the way, thank you! >> >> AngeloGioacchino Del Regno (6): >> dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix >> formatting >> dt-bindings: arm: mt8186: Set #clock-cells as required property >> dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix >> formatting >> dt-bindings: arm: mt8195: Set #clock-cells as required property >> dt-bindings: arm: mt8192-clock: Remove unnecessary 'items' >> dt-bindings: arm: mt8192: Set #clock-cells as required property >> >> .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- >> .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + >> .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- >> .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + >> .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- >> .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + >> 6 files changed, 71 insertions(+), 66 deletions(-) >>
On Tue, May 17, 2022 at 12:15:08PM +0200, AngeloGioacchino Del Regno wrote: > As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for > which I've used the already upstreamed ones as a base, it was found that > these bindings have some issues. > This series is addressing the issues that were found by Rob on my series, > which are present on all of the already merged bindings. > > [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 > > AngeloGioacchino Del Regno (6): > dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix > formatting > dt-bindings: arm: mt8186: Set #clock-cells as required property > dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix > formatting > dt-bindings: arm: mt8195: Set #clock-cells as required property > dt-bindings: arm: mt8192-clock: Remove unnecessary 'items' > dt-bindings: arm: mt8192: Set #clock-cells as required property For the whole series, Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Thanks, Nícolas > > .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- > .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + > .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- > .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + > .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- > .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + > 6 files changed, 71 insertions(+), 66 deletions(-) > > -- > 2.35.1 > >
As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for which I've used the already upstreamed ones as a base, it was found that these bindings have some issues. This series is addressing the issues that were found by Rob on my series, which are present on all of the already merged bindings. [1]: https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 AngeloGioacchino Del Regno (6): dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix formatting dt-bindings: arm: mt8186: Set #clock-cells as required property dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix formatting dt-bindings: arm: mt8195: Set #clock-cells as required property dt-bindings: arm: mt8192-clock: Remove unnecessary 'items' dt-bindings: arm: mt8192: Set #clock-cells as required property .../arm/mediatek/mediatek,mt8186-clock.yaml | 29 ++++----- .../mediatek/mediatek,mt8186-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8192-clock.yaml | 46 +++++++-------- .../mediatek/mediatek,mt8192-sys-clock.yaml | 1 + .../arm/mediatek/mediatek,mt8195-clock.yaml | 59 ++++++++++--------- .../mediatek/mediatek,mt8195-sys-clock.yaml | 1 + 6 files changed, 71 insertions(+), 66 deletions(-)