mbox series

[v2,0/3] MediaTek Helio X10 MT6795 - MT6331 PMIC Keys

Message ID 20220524093505.85438-1-angelogioacchino.delregno@collabora.com (mailing list archive)
Headers show
Series MediaTek Helio X10 MT6795 - MT6331 PMIC Keys | expand

Message

AngeloGioacchino Del Regno May 24, 2022, 9:35 a.m. UTC
In an effort to give some love to the apparently forgotten MT6795 SoC,
I am upstreaming more components that are necessary to support platforms
powered by this one apart from a simple boot to serial console.

This series performs some cleanups in mtk-pmic-keys and adds support for
the MT6331 PMIC's keys.

Adding support to each driver in each subsystem is done in different
patch series as to avoid spamming uninteresting patches to maintainers.

This series depends on another two series series [1], [2] named
"MediaTek Helio X10 MT6795 - MT6331/6332 PMIC Wrapper" and
"MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration"

Tested on a MT6795 Sony Xperia M5 (codename "Holly") smartphone.

[1]: https://lore.kernel.org/lkml/20220520124039.228314-1-angelogioacchino.delregno@collabora.com/T/#t
[2]: https://lore.kernel.org/lkml/20220520124617.228808-1-angelogioacchino.delregno@collabora.com/T/#t

Changes in v2:
 - Dropped first two patches, as Dmitry pushed a different solution
 - Refactored on top of [3]
 - Dropped Mattijs R-b tags from patches [1/3], [2/3] due to the refactoring

[3]: https://patchwork.kernel.org/project/linux-mediatek/list/?series=644484

AngeloGioacchino Del Regno (3):
  Input: mtk-pmic-keys - Transfer per-key bit in mtk_pmic_keys_regs
  Input: mtk-pmic-keys - Move long press debounce mask to mtk_pmic_regs
  Input: mtk-pmic-keys - Add support for MT6331 PMIC keys

 drivers/input/keyboard/mtk-pmic-keys.c | 66 +++++++++++++++++++-------
 1 file changed, 49 insertions(+), 17 deletions(-)

Comments

Pavel Machek May 26, 2022, 11:08 a.m. UTC | #1
Hi!

> In an effort to give some love to the apparently forgotten MT6795 SoC,
> I am upstreaming more components that are necessary to support platforms
> powered by this one apart from a simple boot to serial console.
> 
> This series performs some cleanups in mtk-pmic-keys and adds support for
> the MT6331 PMIC's keys.
> 
> Adding support to each driver in each subsystem is done in different
> patch series as to avoid spamming uninteresting patches to maintainers.
> 
> This series depends on another two series series [1], [2] named
> "MediaTek Helio X10 MT6795 - MT6331/6332 PMIC Wrapper" and
> "MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration"
> 
> Tested on a MT6795 Sony Xperia M5 (codename "Holly") smartphone.

Please cc phone-devel with phone stuff...

...and thanks for all the work. I guess we still don't have an android
phone with basic phone functionality working on mainline...?

Best regards,
							Pavel
AngeloGioacchino Del Regno May 30, 2022, 9:47 a.m. UTC | #2
Il 26/05/22 13:08, Pavel Machek ha scritto:
> Hi!
> 
>> In an effort to give some love to the apparently forgotten MT6795 SoC,
>> I am upstreaming more components that are necessary to support platforms
>> powered by this one apart from a simple boot to serial console.
>>
>> This series performs some cleanups in mtk-pmic-keys and adds support for
>> the MT6331 PMIC's keys.
>>
>> Adding support to each driver in each subsystem is done in different
>> patch series as to avoid spamming uninteresting patches to maintainers.
>>
>> This series depends on another two series series [1], [2] named
>> "MediaTek Helio X10 MT6795 - MT6331/6332 PMIC Wrapper" and
>> "MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration"
>>
>> Tested on a MT6795 Sony Xperia M5 (codename "Holly") smartphone.
> 
> Please cc phone-devel with phone stuff...
> 
> ...and thanks for all the work. I guess we still don't have an android
> phone with basic phone functionality working on mainline...?
> 
> Best regards,
> 							Pavel


Hello Pavel,

I'm sorry, I've been sending a lot of things lately and I forgot to add
that list to the Cc on some series...

Btw, we don't have any MediaTek android phone working at all on mainline:
the one that I'm in the process of upstreaming would be the first one ever,
the hope is that doing this will encourage other developers to do the same
with other platforms.

Speaking of them all... I don't think that there's any retail smartphone
that comes with Android having any phone call ability... I'm aware of some
Qualcomm smartphones being able to use mobile data and SMS, but no calling.

Unless anything changed and unless I'm unaware of recent developments.

Aside from that, MediaTek chips should be a little simpler in this regard,
so I think that we can (and I would love to) get that working, so that
smartphones can still be smart -- phones -- on mainline as well... but I
have a hunch that this will require quite some time.

Regards,
Angelo