From patchwork Sat May 28 22:44:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 12864102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3231CC433EF for ; Sat, 28 May 2022 22:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=m8iSbbeNU1LbN0MfMe0zq4JmPl+zOavlHYepz5AUpXM=; b=QYIXgLs2LZXCeA uyQGLoClTxtBWVDyuXylQWDeEaj8xbwoDesFZ+wpmXsW2qYtrhCwC+0u8i8AZVSA9WdKLc8Z9zyx8 ZQ1az8oq03qDhUx1qxNZTGJ8zo4TmUZ6/Wis17tXNaBQHCmOsYaHwg+LHGF3YClG23Xga80rhnnU6 JmmKOk4CidrjV4R0rNydHpUMeeBXygTDIoVnUnNFJ32iM2CVVbpRWm2N9s47N4EwWdDzT1/Kv72YV YLCFHvjFt3quQnyWbTI2vBO4QLtTmPiDk3WKd0u0H6+x+ZPdhFte4sdQdAkPtzG2uc9VNmuuqBA79 3ODyK+WKVognJaa0D0vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nv5Af-002rN2-Qe; Sat, 28 May 2022 22:44:33 +0000 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nv5Ac-002rMJ-GY; Sat, 28 May 2022 22:44:32 +0000 Received: by mail-pl1-x62a.google.com with SMTP id q4so7187471plr.11; Sat, 28 May 2022 15:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=92XKyxi0NzOHImwEaY7u1Ue336ZJHzFbI2q0mbjzPnY=; b=HU4T4ua91/qz2/rQFff1E1UI5JiHLClbkXnlpC8NqDiWAa84xo/g1fe07kZIfzFOo+ /RsfCN69Q3au2zRKFcafl566xASs/UxE3n4FuJe3a80d7R+5HDBsQ5y7Eo7+OX9F9EB/ p3Ni7F+EY9UzQSMR5GvIUVO/dhFVPmA85l6ZcjSnKjfS58E2J51kf5tabwdMkZ0w4Zgf Unv1/Pl+TkYZdekbDArWpecjxVXQw3LBazPJGksFHeprBRSfkMZqdnSlM6qMPzvmPQo0 /8CuJF8FfmVw5+2hN0sR+YG7D3hTGBJ740YpTRU8pmB8NGzYig+EQ/XTL0r0Z6zGzx2u Lpyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=92XKyxi0NzOHImwEaY7u1Ue336ZJHzFbI2q0mbjzPnY=; b=tXY+/9zVxwmoBGN2Al59Dx5pI7LvcgyfIvkAUHf4B9n5JFnhI7KOSJJnJX3Lf+hPBN agEqE/hfeqtngP0PF0wOdLFdGpAcUvN7VGAr5rXS9LdcBPbcdeLIdS7Gzl2pK+NV8CHl 7WDCe9DPEFm0Kj3I4QUTtXqAjdnsUdMuDTMxq3RyQSqYsz0gtODraUI3SMXc0SYTNedZ TvUc9EKOpfOXIdGoq3buwsyEgU8fQiTfZgN1cBW0K/Mj2+PnprHV2UuJQ/4/N+AN4ERL JFd1LMxOkPCGInW9x7hO5O8V8KZ6vwhkWAs9hT2nwztDSQf3k99AvA6uOwoWdqiQivCR sPnQ== X-Gm-Message-State: AOAM531KeHV9WUr2iw6z52GMUoNrHodvWJXx/np9ap7QCghw2kXGisil 09szh/n7+yE4Ax0Z909YXtE= X-Google-Smtp-Source: ABdhPJxNOCI6gSDXeX1bi05aN85XmFKr3fAXik7FqEDBRdq4LSNWh5XkwWUaDywR1aLePLvzOfjYwg== X-Received: by 2002:a17:90b:3b89:b0:1e0:c079:9dd1 with SMTP id pc9-20020a17090b3b8900b001e0c0799dd1mr15313601pjb.230.1653777869095; Sat, 28 May 2022 15:44:29 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.11.250]) by smtp.gmail.com with ESMTPSA id x22-20020a170902b41600b001635a8f9dfdsm6159514plr.26.2022.05.28.15.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 May 2022 15:44:28 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , james.dutton@gmail.com, Cyril Brulebois , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, james.quinlan@broadcom.com Cc: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi , Rob Herring Subject: [PATCH v2 0/1] PCI: brcmstb: Fix regression regarding missing PCIe linkup Date: Sat, 28 May 2022 18:44:22 -0400 Message-Id: <20220528224423.7017-1-jim2101024@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220528_154430_610986_2825E14F X-CRM114-Status: UNSURE ( 7.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v2 -- Replace using the condition "bus->number == 1" and instead use "pci_is_root_bus(bus->parent)". Although I initially planned to get/enable regulators under and port device, this became more complicated for this regression fix. -- Corrected the commit message in v1 to say "Root Port DT node" rather than "Endpoint DT node". -- brcm_pcie_add_bus() now returns 0 if there is an error in error in calling pci_subdev_regulators_add_bus(). Instead, we dev_err() and turn on our refusal mode instead. -- The pci_subdev_regulators_remove_bus() function now calls regulator_bulk_free() in addtion to regulator_bulk_disable(). I noticed that this call was missing after Bjorn had me detail the call graph for removing the bus when pcie link-up failed. -- Rewrote and added some comments. v1 -- Original Jim Quinlan (1): PCI: brcmstb: Fix regression regarding missing PCIe linkup drivers/pci/controller/pcie-brcmstb.c | 43 +++++++++++++++++++-------- 1 file changed, 30 insertions(+), 13 deletions(-) base-commit: ef1302160bfb19f804451d0e919266703501c875 prerequisite-patch-id: 23a425390a4226bd70bbff459148c80f5e28379c prerequisite-patch-id: e3f2875124b46b2b1cf9ea28883bf0c864b79479 prerequisite-patch-id: 9cdd706ee2038c7b393c4d65ff76a1873df1ca03 prerequisite-patch-id: 332ac90be6e4e4110e27bdd1caaff212c129f547 prerequisite-patch-id: 32a74f87cbfe9e8d52c34a4edeee6d271925665a prerequisite-patch-id: f57cdf7ec7080bb8c95782bc7c3ec672db8ec1ce prerequisite-patch-id: 18dc9236aed47f708f5c854afd832f3c80be5ea7 prerequisite-patch-id: dd147c6854c4ca12a9a8bd4f5714968a59d60e4e prerequisite-patch-id: 0905430e81a95900a1366916fe2940b848317a7c prerequisite-patch-id: 710896210c50354d87f6025fe0bd1b89981138eb prerequisite-patch-id: 97d3886cb911cb12ef3d514fdfff2a0ab11e8570 prerequisite-patch-id: 241f1e1878fc177d941f4982ca12779a29feb62b prerequisite-patch-id: d856608825e2294297db5d7f88f8c180f3e5a1f2 prerequisite-patch-id: 92bcbc9772fb4d248157bcf35e799ac37be8ee45 prerequisite-patch-id: 6f4b1aac459bb54523ade0e87c04e9d6c45bd9f5 prerequisite-patch-id: 090ee7a3112a4ecb03805b23ed10e2c96b3b34ed