mbox series

[V2,00/11] soc: bcm2835-power: Prepare BCM2711 V3D support

Message ID 20220601125344.60602-1-stefan.wahren@i2se.com (mailing list archive)
Headers show
Series soc: bcm2835-power: Prepare BCM2711 V3D support | expand

Message

Stefan Wahren June 1, 2022, 12:53 p.m. UTC
This series is a split out of version 4 - Raspberry PI 4 V3D enablement send
by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the
power management driver. It's a rework of the less controversial changes
(excluding V3D GPU driver changes) so this can be reviewed and applied faster.

Changes in V2:
- add Peter's Reviewed-by
- simplify schema for rpivid_asb as suggested by Rob
- fix reference and clarify fallback & error handling in patch #7
- drop unnecessary newline in patch #9
- improve log messages as noticed by Peter

Changes since the mention series:
- fix DT schema errors
- make rpivid_asb register optional in DT schema
- avoid code duplication in BCM2835 ASB enable/disable
- rework ASB V3D handling so we don't need the V3D flag
- avoid log errors for optional register
- use a define for expected ASB_AXI_BRDG_ID result
- fix copy & paste issues in bcm2835-pm changes

[1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/

Nicolas Saenz Julienne (6):
  dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema
  dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names
  ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node
  ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node
  mfd: bcm2835-pm: Use 'reg-names' to get resources
  soc: bcm: bcm2835-power: Bypass power_on/off() calls

Stefan Wahren (5):
  dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711
  mfd: bcm2835-pm: Add support for BCM2711
  soc: bcm: bcm2835-power: Refactor ASB control
  soc: bcm: bcm2835-power: Resolve ASB register macros
  soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB

 .../bindings/soc/bcm/brcm,bcm2835-pm.txt      | 46 ----------
 .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 86 +++++++++++++++++++
 arch/arm/boot/dts/bcm2711.dtsi                |  3 +-
 arch/arm/boot/dts/bcm2835-common.dtsi         |  1 +
 drivers/mfd/bcm2835-pm.c                      | 80 +++++++++++++----
 drivers/soc/bcm/bcm2835-power.c               | 72 ++++++++++------
 include/linux/mfd/bcm2835-pm.h                |  1 +
 7 files changed, 199 insertions(+), 90 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt
 create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml

Comments

Peter Robinson June 1, 2022, 1:19 p.m. UTC | #1
Hi Stefan,

So I've done some basic boot testing on a rpi4b, rpi4b 8gb, rpi400,
rpi3b+ and rpi zero2w but all headless/remote, overall it looks good.
I'm back home tomorrow when I can test the rpi4 series with the GPU
patches on top with full desktop/display but overall this looks fab!

Peter

> This series is a split out of version 4 - Raspberry PI 4 V3D enablement send
> by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the
> power management driver. It's a rework of the less controversial changes
> (excluding V3D GPU driver changes) so this can be reviewed and applied faster.
>
> Changes in V2:
> - add Peter's Reviewed-by
> - simplify schema for rpivid_asb as suggested by Rob
> - fix reference and clarify fallback & error handling in patch #7
> - drop unnecessary newline in patch #9
> - improve log messages as noticed by Peter
>
> Changes since the mention series:
> - fix DT schema errors
> - make rpivid_asb register optional in DT schema
> - avoid code duplication in BCM2835 ASB enable/disable
> - rework ASB V3D handling so we don't need the V3D flag
> - avoid log errors for optional register
> - use a define for expected ASB_AXI_BRDG_ID result
> - fix copy & paste issues in bcm2835-pm changes
>
> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/
>
> Nicolas Saenz Julienne (6):
>   dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema
>   dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names
>   ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node
>   ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node
>   mfd: bcm2835-pm: Use 'reg-names' to get resources
>   soc: bcm: bcm2835-power: Bypass power_on/off() calls
>
> Stefan Wahren (5):
>   dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711
>   mfd: bcm2835-pm: Add support for BCM2711
>   soc: bcm: bcm2835-power: Refactor ASB control
>   soc: bcm: bcm2835-power: Resolve ASB register macros
>   soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB
>
>  .../bindings/soc/bcm/brcm,bcm2835-pm.txt      | 46 ----------
>  .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 86 +++++++++++++++++++
>  arch/arm/boot/dts/bcm2711.dtsi                |  3 +-
>  arch/arm/boot/dts/bcm2835-common.dtsi         |  1 +
>  drivers/mfd/bcm2835-pm.c                      | 80 +++++++++++++----
>  drivers/soc/bcm/bcm2835-power.c               | 72 ++++++++++------
>  include/linux/mfd/bcm2835-pm.h                |  1 +
>  7 files changed, 199 insertions(+), 90 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt
>  create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
>
> --
> 2.25.1
>
Stefan Wahren June 1, 2022, 1:31 p.m. UTC | #2
Hi Peter,

Am 01.06.22 um 15:19 schrieb Peter Robinson:
> Hi Stefan,
>
> So I've done some basic boot testing on a rpi4b, rpi4b 8gb, rpi400,
> rpi3b+ and rpi zero2w but all headless/remote, overall it looks good.
> I'm back home tomorrow when I can test the rpi4 series with the GPU
> patches on top with full desktop/display but overall this looks fab!

Thanks a lot for review and testing.

Stefan

>
> Peter
>
>> This series is a split out of version 4 - Raspberry PI 4 V3D enablement send
>> by Peter Robinson [1]. It attemps to enable BCM2711 V3D support for the
>> power management driver. It's a rework of the less controversial changes
>> (excluding V3D GPU driver changes) so this can be reviewed and applied faster.
>>
>> Changes in V2:
>> - add Peter's Reviewed-by
>> - simplify schema for rpivid_asb as suggested by Rob
>> - fix reference and clarify fallback & error handling in patch #7
>> - drop unnecessary newline in patch #9
>> - improve log messages as noticed by Peter
>>
>> Changes since the mention series:
>> - fix DT schema errors
>> - make rpivid_asb register optional in DT schema
>> - avoid code duplication in BCM2835 ASB enable/disable
>> - rework ASB V3D handling so we don't need the V3D flag
>> - avoid log errors for optional register
>> - use a define for expected ASB_AXI_BRDG_ID result
>> - fix copy & paste issues in bcm2835-pm changes
>>
>> [1] - https://patchwork.kernel.org/project/linux-arm-kernel/cover/20220213225646.67761-1-pbrobinson@gmail.com/
>>
>> Nicolas Saenz Julienne (6):
>>    dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema
>>    dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names
>>    ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node
>>    ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node
>>    mfd: bcm2835-pm: Use 'reg-names' to get resources
>>    soc: bcm: bcm2835-power: Bypass power_on/off() calls
>>
>> Stefan Wahren (5):
>>    dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711
>>    mfd: bcm2835-pm: Add support for BCM2711
>>    soc: bcm: bcm2835-power: Refactor ASB control
>>    soc: bcm: bcm2835-power: Resolve ASB register macros
>>    soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB
>>
>>   .../bindings/soc/bcm/brcm,bcm2835-pm.txt      | 46 ----------
>>   .../bindings/soc/bcm/brcm,bcm2835-pm.yaml     | 86 +++++++++++++++++++
>>   arch/arm/boot/dts/bcm2711.dtsi                |  3 +-
>>   arch/arm/boot/dts/bcm2835-common.dtsi         |  1 +
>>   drivers/mfd/bcm2835-pm.c                      | 80 +++++++++++++----
>>   drivers/soc/bcm/bcm2835-power.c               | 72 ++++++++++------
>>   include/linux/mfd/bcm2835-pm.h                |  1 +
>>   7 files changed, 199 insertions(+), 90 deletions(-)
>>   delete mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.txt
>>   create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-pm.yaml
>>
>> --
>> 2.25.1
>>