mbox series

[v2,0/3] dt-bindings: Arm CoreSight binding schema conversions

Message ID 20220603011933.3277315-1-robh@kernel.org (mailing list archive)
Headers show
Series dt-bindings: Arm CoreSight binding schema conversions | expand

Message

Rob Herring (Arm) June 3, 2022, 1:19 a.m. UTC
This series converts all the CoreSight debug bindings to DT schema
format. These bindings are at the top of the list of occurrences of
bindings without a schema. For arm64 dts files:

    702 ['arm,coresight-etm4x', 'arm,primecell']
    536 ['arm,coresight-cpu-debug', 'arm,primecell']
    509 ['arm,coresight-dynamic-funnel', 'arm,primecell']
    213 ['arm,coresight-tmc', 'arm,primecell']
    143 ['arm,coresight-dynamic-replicator', 'arm,primecell']
     97 ['arm,coresight-stm', 'arm,primecell']

I'll send a reply to these with the errors in dts files that this
causes. I've reviewed them and they all look legit. Xilinx Zynq though
has 3 clocks instead of 2.

v2:
 - Rename other Coresight bindings to use compatible string for filename
 - Add missing arm,coresight-dynamic-replicator.yaml and
   arm,coresight-static-funnel.yaml
 - Update MAINTAINERS
 - Fix coresight.txt references

Rob

Rob Herring (3):
  dt-bindings: arm: Rename Coresight filenames to match compatible
  dt-bindings: arm: Convert CoreSight bindings to DT schema
  dt-bindings: arm: Convert CoreSight CPU debug to DT schema

 .../bindings/arm/arm,coresight-catu.yaml      | 101 +++++
 .../bindings/arm/arm,coresight-cpu-debug.yaml |  81 ++++
 ...esight-cti.yaml => arm,coresight-cti.yaml} |   5 +-
 .../arm/arm,coresight-dynamic-funnel.yaml     | 126 ++++++
 .../arm/arm,coresight-dynamic-replicator.yaml | 126 ++++++
 .../bindings/arm/arm,coresight-etb10.yaml     |  92 ++++
 .../bindings/arm/arm,coresight-etm.yaml       | 156 +++++++
 .../arm/arm,coresight-static-funnel.yaml      |  89 ++++
 .../arm/arm,coresight-static-replicator.yaml  |  90 ++++
 .../bindings/arm/arm,coresight-stm.yaml       | 101 +++++
 .../bindings/arm/arm,coresight-tmc.yaml       | 131 ++++++
 .../bindings/arm/arm,coresight-tpiu.yaml      |  91 ++++
 ...yaml => arm,embedded-trace-extension.yaml} |   3 +-
 ...e.yaml => arm,trace-buffer-extension.yaml} |   2 +-
 .../bindings/arm/coresight-cpu-debug.txt      |  49 ---
 .../devicetree/bindings/arm/coresight.txt     | 402 ------------------
 Documentation/trace/coresight/coresight.rst   |   2 +-
 MAINTAINERS                                   |   8 +-
 18 files changed, 1192 insertions(+), 463 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml
 rename Documentation/devicetree/bindings/arm/{coresight-cti.yaml => arm,coresight-cti.yaml} (98%)
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
 rename Documentation/devicetree/bindings/arm/{ete.yaml => arm,embedded-trace-extension.yaml} (95%)
 rename Documentation/devicetree/bindings/arm/{trbe.yaml => arm,trace-buffer-extension.yaml} (94%)
 delete mode 100644 Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
 delete mode 100644 Documentation/devicetree/bindings/arm/coresight.txt

--
2.34.1

Comments

Mathieu Poirier June 20, 2022, 4:55 p.m. UTC | #1
Hi Rob,

On Thu, Jun 02, 2022 at 08:19:30PM -0500, Rob Herring wrote:
> This series converts all the CoreSight debug bindings to DT schema
> format. These bindings are at the top of the list of occurrences of
> bindings without a schema. For arm64 dts files:
> 
>     702 ['arm,coresight-etm4x', 'arm,primecell']
>     536 ['arm,coresight-cpu-debug', 'arm,primecell']
>     509 ['arm,coresight-dynamic-funnel', 'arm,primecell']
>     213 ['arm,coresight-tmc', 'arm,primecell']
>     143 ['arm,coresight-dynamic-replicator', 'arm,primecell']
>      97 ['arm,coresight-stm', 'arm,primecell']
> 
> I'll send a reply to these with the errors in dts files that this
> causes. I've reviewed them and they all look legit. Xilinx Zynq though
> has 3 clocks instead of 2.
> 
> v2:
>  - Rename other Coresight bindings to use compatible string for filename
>  - Add missing arm,coresight-dynamic-replicator.yaml and
>    arm,coresight-static-funnel.yaml
>  - Update MAINTAINERS
>  - Fix coresight.txt references

What a massive undertaking... I have looked scrupulously and everything adds up.
Let me know if you were looking for me to pick this up.  Otherwise:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Thanks,
Mathieu

> 
> Rob
> 
> Rob Herring (3):
>   dt-bindings: arm: Rename Coresight filenames to match compatible
>   dt-bindings: arm: Convert CoreSight bindings to DT schema
>   dt-bindings: arm: Convert CoreSight CPU debug to DT schema
> 
>  .../bindings/arm/arm,coresight-catu.yaml      | 101 +++++
>  .../bindings/arm/arm,coresight-cpu-debug.yaml |  81 ++++
>  ...esight-cti.yaml => arm,coresight-cti.yaml} |   5 +-
>  .../arm/arm,coresight-dynamic-funnel.yaml     | 126 ++++++
>  .../arm/arm,coresight-dynamic-replicator.yaml | 126 ++++++
>  .../bindings/arm/arm,coresight-etb10.yaml     |  92 ++++
>  .../bindings/arm/arm,coresight-etm.yaml       | 156 +++++++
>  .../arm/arm,coresight-static-funnel.yaml      |  89 ++++
>  .../arm/arm,coresight-static-replicator.yaml  |  90 ++++
>  .../bindings/arm/arm,coresight-stm.yaml       | 101 +++++
>  .../bindings/arm/arm,coresight-tmc.yaml       | 131 ++++++
>  .../bindings/arm/arm,coresight-tpiu.yaml      |  91 ++++
>  ...yaml => arm,embedded-trace-extension.yaml} |   3 +-
>  ...e.yaml => arm,trace-buffer-extension.yaml} |   2 +-
>  .../bindings/arm/coresight-cpu-debug.txt      |  49 ---
>  .../devicetree/bindings/arm/coresight.txt     | 402 ------------------
>  Documentation/trace/coresight/coresight.rst   |   2 +-
>  MAINTAINERS                                   |   8 +-
>  18 files changed, 1192 insertions(+), 463 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml
>  rename Documentation/devicetree/bindings/arm/{coresight-cti.yaml => arm,coresight-cti.yaml} (98%)
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>  rename Documentation/devicetree/bindings/arm/{ete.yaml => arm,embedded-trace-extension.yaml} (95%)
>  rename Documentation/devicetree/bindings/arm/{trbe.yaml => arm,trace-buffer-extension.yaml} (94%)
>  delete mode 100644 Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
>  delete mode 100644 Documentation/devicetree/bindings/arm/coresight.txt
> 
> --
> 2.34.1
Rob Herring (Arm) June 28, 2022, 6:01 p.m. UTC | #2
On Mon, Jun 20, 2022 at 10:55:41AM -0600, Mathieu Poirier wrote:
> Hi Rob,
> 
> On Thu, Jun 02, 2022 at 08:19:30PM -0500, Rob Herring wrote:
> > This series converts all the CoreSight debug bindings to DT schema
> > format. These bindings are at the top of the list of occurrences of
> > bindings without a schema. For arm64 dts files:
> > 
> >     702 ['arm,coresight-etm4x', 'arm,primecell']
> >     536 ['arm,coresight-cpu-debug', 'arm,primecell']
> >     509 ['arm,coresight-dynamic-funnel', 'arm,primecell']
> >     213 ['arm,coresight-tmc', 'arm,primecell']
> >     143 ['arm,coresight-dynamic-replicator', 'arm,primecell']
> >      97 ['arm,coresight-stm', 'arm,primecell']
> > 
> > I'll send a reply to these with the errors in dts files that this
> > causes. I've reviewed them and they all look legit. Xilinx Zynq though
> > has 3 clocks instead of 2.
> > 
> > v2:
> >  - Rename other Coresight bindings to use compatible string for filename
> >  - Add missing arm,coresight-dynamic-replicator.yaml and
> >    arm,coresight-static-funnel.yaml
> >  - Update MAINTAINERS
> >  - Fix coresight.txt references
> 
> What a massive undertaking... I have looked scrupulously and everything adds up.
> Let me know if you were looking for me to pick this up.  Otherwise:
> 
> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Can you apply. I think there was another series from QCom touching 
the MAINTAINERS entry that will conflict. 

There's a couple of indentation fixups. Can you fix when applying or do 
you want me to resend?

Rob
Mathieu Poirier June 29, 2022, 4:28 p.m. UTC | #3
On Tue, Jun 28, 2022 at 12:01:18PM -0600, Rob Herring wrote:
> On Mon, Jun 20, 2022 at 10:55:41AM -0600, Mathieu Poirier wrote:
> > Hi Rob,
> > 
> > On Thu, Jun 02, 2022 at 08:19:30PM -0500, Rob Herring wrote:
> > > This series converts all the CoreSight debug bindings to DT schema
> > > format. These bindings are at the top of the list of occurrences of
> > > bindings without a schema. For arm64 dts files:
> > > 
> > >     702 ['arm,coresight-etm4x', 'arm,primecell']
> > >     536 ['arm,coresight-cpu-debug', 'arm,primecell']
> > >     509 ['arm,coresight-dynamic-funnel', 'arm,primecell']
> > >     213 ['arm,coresight-tmc', 'arm,primecell']
> > >     143 ['arm,coresight-dynamic-replicator', 'arm,primecell']
> > >      97 ['arm,coresight-stm', 'arm,primecell']
> > > 
> > > I'll send a reply to these with the errors in dts files that this
> > > causes. I've reviewed them and they all look legit. Xilinx Zynq though
> > > has 3 clocks instead of 2.
> > > 
> > > v2:
> > >  - Rename other Coresight bindings to use compatible string for filename
> > >  - Add missing arm,coresight-dynamic-replicator.yaml and
> > >    arm,coresight-static-funnel.yaml
> > >  - Update MAINTAINERS
> > >  - Fix coresight.txt references
> > 
> > What a massive undertaking... I have looked scrupulously and everything adds up.
> > Let me know if you were looking for me to pick this up.  Otherwise:
> > 
> > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> 
> Can you apply. I think there was another series from QCom touching 
> the MAINTAINERS entry that will conflict.

I just tried a rebased on today's linux-next and it didn't blow up.

> 
> There's a couple of indentation fixups. Can you fix when applying or do 
> you want me to resend?

Fixed and applied.

Thanks,
Mathieu

> 
> Rob