| Message ID | 20220609072722.3488207-1-hsinyi@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add a panel API to set orientation properly | expand |
On Thu, Jun 9, 2022 at 3:27 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the property through device tree during probe. > > The series add a panel API drm_connector_set_orientation_from_panel() > for drm/kms drivers. The drivers can call the API to set panel's > orientation before drm_dev_register(). > > Panel needs to implement .get_orientation callback to return the property. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > Hsin-Yi Wang (8): > drm/panel: Add an API to allow drm to set orientation from panel > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > drm/panel: panel-edp: Implement .get_orientation callback > drm/panel: lvds: Implement .get_orientation callback > drm/panel: panel-simple: Implement .get_orientation callback > drm/panel: ili9881c: Implement .get_orientation callback > drm/panel: elida-kd35t133: Implement .get_orientation callback > drm: Config orientation property if panel provides it > hi Maintainers, All the patches are reviewed. If there's no other comments, will this series be picked? Thanks. > drivers/gpu/drm/bridge/panel.c | 34 +++++++++++++++++++ > drivers/gpu/drm/drm_bridge_connector.c | 8 ++++- > drivers/gpu/drm/drm_connector.c | 31 +++++++++++++++++ > .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 12 +++++++ > drivers/gpu/drm/panel/panel-edp.c | 13 ++++++- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 12 +++++++ > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 12 +++++++ > drivers/gpu/drm/panel/panel-lvds.c | 13 +++++++ > drivers/gpu/drm/panel/panel-simple.c | 14 +++++++- > include/drm/drm_bridge.h | 14 ++++++++ > include/drm/drm_connector.h | 4 +++ > include/drm/drm_panel.h | 9 +++++ > 12 files changed, 173 insertions(+), 3 deletions(-) > > -- > 2.36.1.255.ge46751e96f-goog >
Hi, On Tue, Jun 14, 2022 at 10:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > On Thu, Jun 9, 2022 at 3:27 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > later than drm/kms driver calling drm_dev_register(). This leads to a > > WARN()[1]. > > > > The orientation property is known earlier. For example, some panels > > parse the property through device tree during probe. > > > > The series add a panel API drm_connector_set_orientation_from_panel() > > for drm/kms drivers. The drivers can call the API to set panel's > > orientation before drm_dev_register(). > > > > Panel needs to implement .get_orientation callback to return the property. > > > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > > > Hsin-Yi Wang (8): > > drm/panel: Add an API to allow drm to set orientation from panel > > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > > drm/panel: panel-edp: Implement .get_orientation callback > > drm/panel: lvds: Implement .get_orientation callback > > drm/panel: panel-simple: Implement .get_orientation callback > > drm/panel: ili9881c: Implement .get_orientation callback > > drm/panel: elida-kd35t133: Implement .get_orientation callback > > drm: Config orientation property if panel provides it > > > hi Maintainers, > > All the patches are reviewed. If there's no other comments, will this > series be picked? Thanks. Unless someone beat me to it or yells, my plan was to land them to drm-misc-next next week. Since it touches core code I wanted to give a little extra time. Also at the moment patch #8 is all Chromium (all author and reviewers are chromium.org) at the moment so that's another reason to make sure it has sufficient time on the lists. -Doug
Hi, On Wed, Jun 15, 2022 at 6:36 AM Doug Anderson <dianders@chromium.org> wrote: > > Hi, > > On Tue, Jun 14, 2022 at 10:50 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > On Thu, Jun 9, 2022 at 3:27 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > > > > > Panels usually call drm_connector_set_panel_orientation(), which is > > > later than drm/kms driver calling drm_dev_register(). This leads to a > > > WARN()[1]. > > > > > > The orientation property is known earlier. For example, some panels > > > parse the property through device tree during probe. > > > > > > The series add a panel API drm_connector_set_orientation_from_panel() > > > for drm/kms drivers. The drivers can call the API to set panel's > > > orientation before drm_dev_register(). > > > > > > Panel needs to implement .get_orientation callback to return the property. > > > > > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > > > > > Hsin-Yi Wang (8): > > > drm/panel: Add an API to allow drm to set orientation from panel > > > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > > > drm/panel: panel-edp: Implement .get_orientation callback > > > drm/panel: lvds: Implement .get_orientation callback > > > drm/panel: panel-simple: Implement .get_orientation callback > > > drm/panel: ili9881c: Implement .get_orientation callback > > > drm/panel: elida-kd35t133: Implement .get_orientation callback > > > drm: Config orientation property if panel provides it > > > > > hi Maintainers, > > > > All the patches are reviewed. If there's no other comments, will this > > series be picked? Thanks. > > Unless someone beat me to it or yells, my plan was to land them to > drm-misc-next next week. Since it touches core code I wanted to give a > little extra time. Also at the moment patch #8 is all Chromium (all > author and reviewers are chromium.org) at the moment so that's another > reason to make sure it has sufficient time on the lists. As promised, I've pushed to drm-misc-next. Note: I had to fix whitespace problems in almost every patch. Please run checkpatch on your patches. 15b9ca1641f0 drm: Config orientation property if panel provides it a64af136771a drm/panel: elida-kd35t133: Implement .get_orientation callback db9b4ffbfa82 drm/panel: ili9881c: Implement .get_orientation callback a960e35ac011 drm/panel: panel-simple: Implement .get_orientation callback c0398df2a195 drm/panel: lvds: Implement .get_orientation callback 47bef230225b drm/panel: panel-edp: Implement .get_orientation callback 3fa214eea43a drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback 5e41b01a7808 drm/panel: Add an API to allow drm to set orientation from panel -Doug