[v5,0/9] power: reset: at91-reset: add support for sama7g5

Message

Claudiu Beznea June 10, 2022, 9:24 a.m. UTC

Hi,

The series adds reset controller support for SAMA7G5 SoCs. Compared with
previous version the reset controller embedded on SAMA7G5 is able to
reset individual on SoC devices (e.g. USB PHY controllers).

Among with this I took the change and converted reset controller
bindings to YAML (patch 2/9) and adapt reset controller nodes in
device tree files to comply with DT specifications (patch 1/9).

Thank you,
Claudiu Beznea

Changes in v5:
- in patch 6/9 added device_reset_min_id, device_reset_max_id to
  struct at91_reset_data; these will be used in at91_reset_of_xlate()
  (patch 7/9) allowing expansion of device reset code for future
  devices; with this member of type const struct at91_reset_data *
  has been added to struct at91_reset and at91_rcdev_init() gets
  now only 2 arguments.
- in patch 8/9 use filled .device_reset_min_id, .device_reset_max_id
- in patch 6/9 use device_get_match_data()
- collected tags

Changes in v4:
- removed patch 10/10 from v3 as it has been taken though at91 tree

Changes in v3:
- use spin_lock_irqsave()/spin_unlock_irqrestore() and lock only
  on update path
- collected tags

Changes in v2:
- added patches 5/10 and 10/10
- in patch 2/10 use my microchip email address
- in patch 4/10 added "SAMA7G5_" in front of macros to cope with file
  naming and used (GPL-2.0-only OR BSD-2-Clause)
- in patch 6/10 documented the structure's members
- in patch 7/10:
	- protect access to reset->dev_base with spin lock
	- check for valid values of reset_spec->args[0] in
	  at91_reset_of_xlate()
	- s/if (IS_ERR(reset->rstc_base))/if (IS_ERR(reset->dev_base))
	- include dt-bindings/reset/sama7g5-reset.h
	- document new added structure's members
- collected tags

Claudiu Beznea (9):
  ARM: dts: at91: use generic name for reset controller
  dt-bindings: reset: convert Atmel/Microchip reset controller to YAML
  dt-bindings: reset: atmel,at91sam9260-reset: add sama7g5 bindings
  dt-bindings: reset: add sama7g5 definitions
  power: reset: at91-reset: document structures and enums
  power: reset: at91-reset: add at91_reset_data
  power: reset: at91-reset: add reset_controller_dev support
  power: reset: at91-reset: add support for SAMA7G5
  ARM: dts: at91: sama7g5: add reset-controller node

 .../devicetree/bindings/arm/atmel-sysregs.txt |  15 --
 .../reset/atmel,at91sam9260-reset.yaml        |  68 +++++++
 arch/arm/boot/dts/at91sam9260.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9261.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9263.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9g45.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9n12.dtsi            |   2 +-
 arch/arm/boot/dts/at91sam9rl.dtsi             |   2 +-
 arch/arm/boot/dts/at91sam9x5.dtsi             |   2 +-
 arch/arm/boot/dts/sam9x60.dtsi                |   2 +-
 arch/arm/boot/dts/sama5d2.dtsi                |   2 +-
 arch/arm/boot/dts/sama5d3.dtsi                |   2 +-
 arch/arm/boot/dts/sama5d4.dtsi                |   2 +-
 arch/arm/boot/dts/sama7g5.dtsi                |   7 +
 drivers/power/reset/at91-reset.c              | 184 ++++++++++++++++--
 include/dt-bindings/reset/sama7g5-reset.h     |  10 +
 16 files changed, 265 insertions(+), 41 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
 create mode 100644 include/dt-bindings/reset/sama7g5-reset.h

Comments

Sebastian Reichel June 17, 2022, 3:39 p.m. UTC | #1

Hi,

On Fri, Jun 10, 2022 at 12:24:05PM +0300, Claudiu Beznea wrote:
> Hi,
> 
> The series adds reset controller support for SAMA7G5 SoCs. Compared with
> previous version the reset controller embedded on SAMA7G5 is able to
> reset individual on SoC devices (e.g. USB PHY controllers).
> 
> Among with this I took the change and converted reset controller
> bindings to YAML (patch 2/9) and adapt reset controller nodes in
> device tree files to comply with DT specifications (patch 1/9).
> 
> Thank you,
> Claudiu Beznea

Thanks, I queued patches 2-8 (i.e. skipping the DT patches). The DT
patches can go through the ARM tree. In case you plan to use the
dt-binding include I queued the patches via an immutable branch
that can be pulled into the ARM tree:

-----------------------------------------------------------------------------

The following changes since commit f2906aa863381afb0015a9eb7fefad885d4e5a56:

  Linux 5.19-rc1 (2022-06-05 17:18:54 -0700)

are available in the Git repository at:

  ssh://[e-mail]/pub/scm/linux/kernel/git/sre/linux-power-supply.git tags/at91-reset-sama7g5-signed

for you to fetch changes up to a22c8e8834bcc55e44d0bae738f0915df7e6f573:

  power: reset: at91-reset: add support for SAMA7G5 (2022-06-17 17:20:00 +0200)

----------------------------------------------------------------
power: reset: at91-reset: add support for sama7g5

This adds reset controller support for SAMA7G5 SoCs. Compared with
previous version the reset controller embedded on SAMA7G5 is able to
reset individual on SoC devices (e.g. USB PHY controllers).

Signed-off-by: Sebastian Reichel <[e-mail]>

----------------------------------------------------------------
Claudiu Beznea (7):
      dt-bindings: reset: convert Atmel/Microchip reset controller to YAML
      dt-bindings: reset: atmel,at91sam9260-reset: add sama7g5 bindings
      dt-bindings: reset: add sama7g5 definitions
      power: reset: at91-reset: document structures and enums
      power: reset: at91-reset: add at91_reset_data
      power: reset: at91-reset: add reset_controller_dev support
      power: reset: at91-reset: add support for SAMA7G5

 .../devicetree/bindings/arm/atmel-sysregs.txt      |  15 --
 .../bindings/reset/atmel,at91sam9260-reset.yaml    |  68 ++++++++
 drivers/power/reset/at91-reset.c                   | 184 +++++++++++++++++++--
 include/dt-bindings/reset/sama7g5-reset.h          |  10 ++
 4 files changed, 247 insertions(+), 30 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/reset/atmel,at91sam9260-reset.yaml
 create mode 100644 include/dt-bindings/reset/sama7g5-reset.h

-----------------------------------------------------------------------------

-- Sebastian