[RESEND,0/3] i2c: at91: Fixes and updates

Message

Codrin Ciubotariu June 14, 2022, 10:13 a.m. UTC

Resend due to the fact that the i2c list no longer accepts replys on the
old patch-set. Comments not addressed yet.

The first patch is mostly a prerequisite for the second one. It only
moves the i2c_recover_bus() out of the actual transfer function. This
helps the second patch disable the controller before using GPIO
recovery. The second patch will keep the controller enabled when a
transfer occurs. Before using GPIO recovery, the controller must be
disabled, to ignore potential glitches. However, the controller must be
enabled for HW recovery (bus CLEAR command). The third and last patch
adds advanced digital filtering support for SAMA5D4. The TWI IP found in
SAMA5D4 supports advanced digital filtering, even if, at the moment of
this patch, the SAMA5D4 datasheet does not mention it.

Codrin Ciubotariu (3):
  i2c: at91: move i2c_recover_bus() outside of at91_do_twi_transfer()
  i2c: at91: keep the controller disabled when it is not used
  i2c: at91: add advanced digital filtering support for SAMA5D4

 drivers/i2c/busses/i2c-at91-core.c   |  1 +
 drivers/i2c/busses/i2c-at91-master.c | 53 ++++++++++++++++++++++------
 2 files changed, 44 insertions(+), 10 deletions(-)

Comments

Wolfram Sang June 29, 2022, 7:46 p.m. UTC | #1

On Tue, Jun 14, 2022 at 01:13:44PM +0300, Codrin Ciubotariu wrote:
> Resend due to the fact that the i2c list no longer accepts replys on the
> old patch-set. Comments not addressed yet.
> 
> The first patch is mostly a prerequisite for the second one. It only
> moves the i2c_recover_bus() out of the actual transfer function. This
> helps the second patch disable the controller before using GPIO
> recovery. The second patch will keep the controller enabled when a
> transfer occurs. Before using GPIO recovery, the controller must be
> disabled, to ignore potential glitches. However, the controller must be
> enabled for HW recovery (bus CLEAR command). The third and last patch
> adds advanced digital filtering support for SAMA5D4. The TWI IP found in
> SAMA5D4 supports advanced digital filtering, even if, at the moment of
> this patch, the SAMA5D4 datasheet does not mention it.

So, can you guys read this mail? It should be possible somehow that I
can read your remarks to my remarks, no?

Nicolas Ferre June 30, 2022, 7:41 a.m. UTC | #2

Hi Wolfram,

On 29/06/2022 at 21:46, Wolfram Sang wrote:
> On Tue, Jun 14, 2022 at 01:13:44PM +0300, Codrin Ciubotariu wrote:
>> Resend due to the fact that the i2c list no longer accepts replys on the
>> old patch-set. Comments not addressed yet.
>>
>> The first patch is mostly a prerequisite for the second one. It only
>> moves the i2c_recover_bus() out of the actual transfer function. This
>> helps the second patch disable the controller before using GPIO
>> recovery. The second patch will keep the controller enabled when a
>> transfer occurs. Before using GPIO recovery, the controller must be
>> disabled, to ignore potential glitches. However, the controller must be
>> enabled for HW recovery (bus CLEAR command). The third and last patch
>> adds advanced digital filtering support for SAMA5D4. The TWI IP found in
>> SAMA5D4 supports advanced digital filtering, even if, at the moment of
>> this patch, the SAMA5D4 datasheet does not mention it.
 >
> So, can you guys read this mail? It should be possible somehow that I
> can read your remarks to my remarks, no?

Codrin is not with Microchip anymore and we have to re-distribute the 
maintenance of this driver internally. His email address will probably 
"bounce" soon.

So, forgive us if there's a lack of response for some time ;-)

Best regards,
   Nicolas

Wolfram Sang June 30, 2022, 8:09 a.m. UTC | #3

Hi Nicolas,

> Codrin is not with Microchip anymore and we have to re-distribute the
> maintenance of this driver internally. His email address will probably
> "bounce" soon.

Ah, very unfortunate that we couldn't move this series forward
because of the mysterious mail problems.

All the best,

   Wolfram