mbox series

[v2,0/3] ASoC: sun50i-codec-analog: Internal bias support

Message ID 20220621035452.60272-1-samuel@sholland.org (mailing list archive)
Headers show
Series ASoC: sun50i-codec-analog: Internal bias support | expand

Message

Samuel Holland June 21, 2022, 3:54 a.m. UTC
This series adds support for enabling the codec's internal microphone
bias, which is needed on at least some versions of the PinePhone.

Changes in v2:
 - Move register update from component probe to device probe

Arnaud Ferraris (2):
  ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
  ASoC: sun50i-codec-analog: Add support for internal bias

Samuel Holland (1):
  arm64: dts: allwinner: pinephone: Enable internal HMIC bias

 .../bindings/sound/allwinner,sun50i-a64-codec-analog.yaml | 5 +++++
 .../arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.0.dts | 4 ++++
 .../arm64/boot/dts/allwinner/sun50i-a64-pinephone-1.1.dts | 4 ++++
 sound/soc/sunxi/sun50i-codec-analog.c                     | 8 ++++++++
 4 files changed, 21 insertions(+)

Comments

Mark Brown June 27, 2022, 8:46 p.m. UTC | #1
On Mon, 20 Jun 2022 22:54:49 -0500, Samuel Holland wrote:
> This series adds support for enabling the codec's internal microphone
> bias, which is needed on at least some versions of the PinePhone.
> 
> Changes in v2:
>  - Move register update from component probe to device probe
> 
> Arnaud Ferraris (2):
>   ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
>   ASoC: sun50i-codec-analog: Add support for internal bias
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
      commit: 24e0b04dd42be34ec4b18dc1a1e139d66eb572a3
[2/3] ASoC: sun50i-codec-analog: Add support for internal bias
      commit: 25ae1a04da0d32c22db0b018e5668129b91fa104

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Jernej Škrabec July 5, 2022, 8:12 p.m. UTC | #2
Hi Mark!

Dne ponedeljek, 27. junij 2022 ob 22:46:30 CEST je Mark Brown napisal(a):
> On Mon, 20 Jun 2022 22:54:49 -0500, Samuel Holland wrote:
> > This series adds support for enabling the codec's internal microphone
> > bias, which is needed on at least some versions of the PinePhone.
> > 
> > Changes in v2:
> >  - Move register update from component probe to device probe
> > 
> > Arnaud Ferraris (2):
> >   ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
> >   ASoC: sun50i-codec-analog: Add support for internal bias
> > 
> > [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
> for-next
> 
> Thanks!
> 
> [1/3] ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
>       commit: 24e0b04dd42be34ec4b18dc1a1e139d66eb572a3
> [2/3] ASoC: sun50i-codec-analog: Add support for internal bias
>       commit: 25ae1a04da0d32c22db0b018e5668129b91fa104

Can you also take patch 3? You picked bindings change, so it's easiest if DT 
change goes through your tree too.

Best regards,
Jernej

> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> 
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
> 
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
> 
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
> 
> Thanks,
> Mark
Mark Brown July 5, 2022, 8:58 p.m. UTC | #3
On Tue, Jul 05, 2022 at 10:12:56PM +0200, Jernej Škrabec wrote:
> Dne ponedeljek, 27. junij 2022 ob 22:46:30 CEST je Mark Brown napisal(a):
> > On Mon, 20 Jun 2022 22:54:49 -0500, Samuel Holland wrote:

> > [1/3] ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
> >       commit: 24e0b04dd42be34ec4b18dc1a1e139d66eb572a3
> > [2/3] ASoC: sun50i-codec-analog: Add support for internal bias
> >       commit: 25ae1a04da0d32c22db0b018e5668129b91fa104

> Can you also take patch 3? You picked bindings change, so it's easiest if DT 
> change goes through your tree too.

I can if the sunxi maintainers like, but normally changes to the DTs go
via the platform tree.
Jernej Škrabec July 5, 2022, 9:04 p.m. UTC | #4
Dne torek, 05. julij 2022 ob 22:58:32 CEST je Mark Brown napisal(a):
> On Tue, Jul 05, 2022 at 10:12:56PM +0200, Jernej Škrabec wrote:
> > Dne ponedeljek, 27. junij 2022 ob 22:46:30 CEST je Mark Brown napisal(a):
> > > On Mon, 20 Jun 2022 22:54:49 -0500, Samuel Holland wrote:
> > > 
> > > [1/3] ASoC: dt-bindings: sun50i-codec: Add binding for internal bias
> > > 
> > >       commit: 24e0b04dd42be34ec4b18dc1a1e139d66eb572a3
> > > 
> > > [2/3] ASoC: sun50i-codec-analog: Add support for internal bias
> > > 
> > >       commit: 25ae1a04da0d32c22db0b018e5668129b91fa104
> > 
> > Can you also take patch 3? You picked bindings change, so it's easiest if
> > DT change goes through your tree too.
> 
> I can if the sunxi maintainers like, but normally changes to the DTs go
> via the platform tree.

I am sunxi maintainer. Wouldn't my branch generate warnings, if I have only DT 
changes but not bindings?

Best regards,
Jernej
Mark Brown July 5, 2022, 9:14 p.m. UTC | #5
On Tue, Jul 05, 2022 at 11:04:54PM +0200, Jernej Škrabec wrote:
> Dne torek, 05. julij 2022 ob 22:58:32 CEST je Mark Brown napisal(a):

> > I can if the sunxi maintainers like, but normally changes to the DTs go
> > via the platform tree.

> I am sunxi maintainer. Wouldn't my branch generate warnings, if I have only DT 
> changes but not bindings?

I guess, I think people tend not to worry about it so long as -next is
OK.  The issue with merging things through subsystem trees is that it's
very easy to generate lots of conflicts which tends to cause more issues
overall.