From patchwork Tue Jun 21 07:26:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tong Tiangen X-Patchwork-Id: 12888766 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41619C433EF for ; Tue, 21 Jun 2022 07:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7z9Yo+wAiaeXtjlFysE4Fe3kN7k7OlQRYYWEQTItBes=; b=eK53vuDDpONRel cRgmbsN6sNkheRckuRF0aN/QDX9Y36v4Ua3IvrY86EaP95RxYweZYH0rtAxtBimGhkCFQeL/MSBse 3NNoTxoSMUDt7GKYHvpCEYOosDNPr7cUgdNtmCatQ6YRVs9zBhrhqrgX3gc+sAXoBFPb5MrBOaDu5 C/e52jzPI7hEYs8Tmy9D41Q62gHpvImDi06afe1HVEBCwXWNn0RYIw8g9aEoe0U2jM0t8BXymJem3 tdiDZo6G0Z7Urf6OB9/fPgC3V1i3HJ2lLo1YKy9OsTsGXpFcJl3LPEsDUbJnQaIlrHrFpjeObyIlF wbJ2t87qykZtaB5KP3Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3YI0-0043vx-9A; Tue, 21 Jun 2022 07:27:08 +0000 Received: from szxga03-in.huawei.com ([45.249.212.189]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3YHu-0043pT-L9 for linux-arm-kernel@lists.infradead.org; Tue, 21 Jun 2022 07:27:06 +0000 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LRyk33r4tzDsL6; Tue, 21 Jun 2022 15:26:19 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 21 Jun 2022 15:26:48 +0800 Received: from localhost.localdomain (10.175.112.125) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 21 Jun 2022 15:26:47 +0800 From: Tong Tiangen To: Mark Rutland , James Morse , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Robin Murphy , Dave Hansen , Catalin Marinas , Will Deacon , Alexander Viro , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , , "H . Peter Anvin" CC: , , , , Kefeng Wang , Xie XiuQi , Guohanjun , Tong Tiangen Subject: [PATCH -next v6 00/10]arm64: add machine check safe support Date: Tue, 21 Jun 2022 07:26:28 +0000 Message-ID: <20220621072638.1273594-1-tongtiangen@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220621_002703_125672_4CEDBA0B X-CRM114-Status: GOOD ( 19.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org With the increase of memory capacity and density, the probability of memory error increases. The increasing size and density of server RAM in the data center and cloud have shown increased uncorrectable memory errors. Currently, the kernel has a mechanism to recover from hardware memory errors. This patchset provides an new recovery mechanism. For arm64, the hardware memory error handling is do_sea() which divided into two cases: 1. The user state consumed the memory errors, the solution is kill the user process and isolate the error page. 2. The kernel state consumed the memory errors, the solution is panic. For case 2, Undifferentiated panic maybe not the optimal choice, it can be handled better, in some scenarios, we can avoid panic, such as uaccess, if the uaccess fails due to memory error, only the user process will be affected, kill the user process and isolate the user page with hardware memory errors is a better choice. This patchset can be divided into two parts: 1. Patch 1~6 - do some restructuring to arm64 extable. 2. Patch 7~10 - arm64 add support for machine check safe framework, then ,add two specific scenarios(uaccess/cow) to machine check safe. Since V5: 1. Add patch2/3 to add uaccess assembly helpers. 2. Optimize the implementation logic of arm64_do_kernel_sea() in patch8. 3. Remove kernel access fixup in patch9. All suggestion are from Mark. Since V4: 1. According Michael's suggestion, add patch5. 2. According Mark's suggestiog, do some restructuring to arm64 extable, then a new adaptation of machine check safe support is made based on this. 3. According Mark's suggestion, support machine check safe in do_mte() in cow scene. 4. In V4, two patches have been merged into -next, so V5 not send these two patches. Since V3: 1. According to Robin's suggestion, direct modify user_ldst and user_ldp in asm-uaccess.h and modify mte.S. 2. Add new macro USER_MC in asm-uaccess.h, used in copy_from_user.S and copy_to_user.S. 3. According to Robin's suggestion, using micro in copy_page_mc.S to simplify code. 4. According to KeFeng's suggestion, modify powerpc code in patch1. 5. According to KeFeng's suggestion, modify mm/extable.c and some code optimization. Since V2: 1. According to Mark's suggestion, all uaccess can be recovered due to memory error. 2. Scenario pagecache reading is also supported as part of uaccess (copy_to_user()) and duplication code problem is also solved. Thanks for Robin's suggestion. 3. According Mark's suggestion, update commit message of patch 2/5. 4. According Borisllav's suggestion, update commit message of patch 1/5. Since V1: 1.Consistent with PPC/x86, Using CONFIG_ARCH_HAS_COPY_MC instead of ARM64_UCE_KERNEL_RECOVERY. 2.Add two new scenes, cow and pagecache reading. 3.Fix two small bug(the first two patch). V1 in here: https://lore.kernel.org/lkml/20220323033705.3966643-1-tongtiangen@huawei.com/ Tong Tiangen (10): arm64: extable: add new extable type EX_TYPE_KACCESS_ERR_ZERO support arm64: asm-extable: move data fields arm64: asm-extable: add asm uacess helpers arm64: extable: make uaaccess helper use extable type EX_TYPE_UACCESS_ERR_ZERO arm64: extable: move _cond_extable to _cond_uaccess_extable arm64: extable: cleanup redundant extable type EX_TYPE_FIXUP Add generic fallback version of copy_mc_to_user() arm64: add support for machine check error safe arm64: add uaccess to machine check safe arm64: add cow to machine check safe arch/arm64/Kconfig | 1 + arch/arm64/include/asm/asm-extable.h | 84 ++++++++++++++++++------- arch/arm64/include/asm/asm-uaccess.h | 12 ++-- arch/arm64/include/asm/assembler.h | 8 ++- arch/arm64/include/asm/extable.h | 1 + arch/arm64/include/asm/mte.h | 4 ++ arch/arm64/include/asm/page.h | 10 +++ arch/arm64/include/asm/uaccess.h | 94 ++++++++++++++-------------- arch/arm64/lib/Makefile | 2 + arch/arm64/lib/copy_page_mc.S | 82 ++++++++++++++++++++++++ arch/arm64/lib/mte.S | 19 ++++++ arch/arm64/mm/copypage.c | 41 +++++++++--- arch/arm64/mm/extable.c | 21 ++++++- arch/arm64/mm/fault.c | 29 ++++++++- arch/powerpc/include/asm/uaccess.h | 1 + arch/x86/include/asm/uaccess.h | 1 + include/linux/highmem.h | 8 +++ include/linux/uaccess.h | 9 +++ mm/memory.c | 2 +- 19 files changed, 339 insertions(+), 90 deletions(-) create mode 100644 arch/arm64/lib/copy_page_mc.S Reviewed-by: Kefeng Wang