| Message ID | 20220713110020.85511-1-lihuafei1@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: Convert to ARCH_STACKWALK | expand |
On Wed, Jul 13, 2022 at 1:02 PM Li Huafei <lihuafei1@huawei.com> wrote: > This series mainly updates the ARM stack trace code to use the newer and > simpler arch_stack_walk() interface. Two issues were fixed before that > (see patch 1 and 2), as well as allowing stack_trace_save_tsk() to > trace non-current tasks (see patch 3). > > v2: > - As suggested by Mark, the commit logs for patch 4 and 5 were > refined for easy review. I see I reviewed v1 when v2 was already out but think the comments still stand. I think you can already add patches 1 & 2 to Russells patch tracker, they are straight-forward fixes. Patches 3-5 may need some elaboration but I trust that you have done some serious testing since you found the snags in patches 1 & 2. Yours, Linus Walleij
This series mainly updates the ARM stack trace code to use the newer and simpler arch_stack_walk() interface. Two issues were fixed before that (see patch 1 and 2), as well as allowing stack_trace_save_tsk() to trace non-current tasks (see patch 3). v2: - As suggested by Mark, the commit logs for patch 4 and 5 were refined for easy review. v1: https://lore.kernel.org/lkml/20220712021527.109921-1-lihuafei1@huawei.com/ Li Huafei (5): ARM: stacktrace: Skip frame pointer boundary check for call_with_stack() ARM: stacktrace: Avoid duplicate saving of exception PC value ARM: stacktrace: Allow stack trace saving for non-current tasks ARM: stacktrace: Make stack walk callback consistent with generic code ARM: stacktrace: Convert stacktrace to generic ARCH_STACKWALK arch/arm/Kconfig | 1 + arch/arm/include/asm/stacktrace.h | 8 +- arch/arm/kernel/perf_callchain.c | 9 +- arch/arm/kernel/return_address.c | 9 +- arch/arm/kernel/stacktrace.c | 195 +++++++++++++----------------- arch/arm/lib/call_with_stack.S | 2 + 6 files changed, 105 insertions(+), 119 deletions(-)