From patchwork Mon Aug 22 09:18:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liang Yang X-Patchwork-Id: 12950406 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB9C3C32789 for ; Mon, 22 Aug 2022 09:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=nF6Xc5JZPh24eaOrBYY+WSm53EE8/UPU0/2PxLJtjhU=; b=kI4apeQrUXelms skMxTgHdw1wtJbOss1d+K/EJ1aslg76cAbzw9aAduPpgrDuLlWmWeIP5DwZkUFMKCBwmCEyghcMxz I2nbYCAYBkuDJP49b12RgXBbajkoavqYJ6NIprmN9LOPahYqwHaHm3DNlm0zpZaoN5n4Xg+PFG7Ci yJMyJ4KBKZw0LkiMCULYS6gxYcoKvA6g+/EQFiCrwxT5OM5gKR4Y640ozfV/ta+VexBWROfH34knV m2SekZXjN16tO6VtAtjT2kxX7aaFdWTCqzGUnQEg54DlJP0iI2D0xcM9u02etoRf9Z6W3O+fRtG7s W2t3bRzZnqFFfiSDf7nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ3bN-006w99-3C; Mon, 22 Aug 2022 09:20:09 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQ3bJ-006w4Q-54; Mon, 22 Aug 2022 09:20:06 +0000 Received: from droid11-sz.amlogic.com (10.28.8.21) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server id 15.1.2507.6; Mon, 22 Aug 2022 17:19:43 +0800 From: Liang Yang To: Miquel Raynal , CC: Liang Yang , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , Subject: [PATCH RESEND v8 0/5] fix the meson NFC clock Date: Mon, 22 Aug 2022 17:18:32 +0800 Message-ID: <20220822091838.18528-1-liang.yang@amlogic.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.28.8.21] X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220822_022005_258285_62B7B487 X-CRM114-Status: GOOD ( 11.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org EMMC and NAND have the same clock control register named 'SD_EMMC_CLOCK' which is defined in EMMC port internally. bit0~5 of 'SD_EMMC_CLOCK' is the divider and bit6~7 is the mux for fix pll and xtal. At the beginning, a common MMC and NAND sub-clock was discussed and planed to be implemented as NFC clock provider, but now this series of patches of a common MMC and NAND sub-clock are never being accepted and the current binding was never valid. the reasons are: 1. EMMC and NAND, which are mutually exclusive anyway 2. coupling the EMMC and NAND. 3. it seems that a common MMC and NAND sub-clock is over engineered. and let us see the link for more information: https://lore.kernel.org/all/20220121074508.42168-5-liang.yang@amlogic.com so The meson nfc can't work now, let us rework the clock. Changes since v7 [8] - use COMMON_CLK && (ARCH_MESON || COMPILE_TEST) instead of ARCH_MESON || COMPILE_TEST || COMMON_CLK. - collect the review and ack Changes since v6 [7] - use COMMON_CLK instead of !HAVE_LEGACY_CLK Changes since v5 [6] - add change log for patch 3/5 - add patch 5/5 to fix the reporting error of test robot Changes since v4 [5] - split the dt binding patch into two patches, one for fixing, clock, the other for coverting to yaml - split the nfc driver patch into two patches, one for fixing clock, the other for refining the get nfc resource. Changes since v3 [4] - use devm_platform_ioremap_resource_byname - dt_binding_check for mtd/amlogic,meson-nand.yaml Changes since v2 [3] - use fw_name from dts, instead the wrong way using __clk_get_name - reg resource size change to 0x800 - use reg-names Changes since v1 [2] - use clk_parent_data instead of parent_names - define a reg resource instead of sd_emmc_c_clkc [1] https://lore.kernel.org/r/20220106033130.37623-1-liang.yang@amlogic.com https://lore.kernel.org/r/20220106032504.23310-1-liang.yang@amlogic.com [2] https://lore.kernel.org/all/20220217063346.21691-1-liang.yang@amlogic.com [3] https://lore.kernel.org/all/20220318124121.26117-1-liang.yang@amlogic.com [4] https://lore.kernel.org/all/20220402074921.13316-1-liang.yang@amlogic.com/ [5] https://lore.kernel.org/all/20220513123404.48513-1-liang.yang@amlogic.com/ [6] https://lore.kernel.org/all/20220607064731.13367-1-liang.yang@amlogic.com/ [7] https://lore.kernel.org/all/20220624131257.29906-1-liang.yang@amlogic.com/ Liang Yang (5): dt-bindings: nand: meson: fix meson nfc clock mtd: rawnand: meson: fix the clock mtd: rawnand: meson: refine resource getting in probe dt-bindings: nand: meson: convert txt to yaml mtd: rawnand: meson: not support legacy clock .../bindings/mtd/amlogic,meson-nand.txt | 60 ------------- .../bindings/mtd/amlogic,meson-nand.yaml | 88 +++++++++++++++++++ drivers/mtd/nand/raw/Kconfig | 2 +- drivers/mtd/nand/raw/meson_nand.c | 86 +++++++++--------- 4 files changed, 131 insertions(+), 105 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.txt create mode 100644 Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml