[v6,0/6] completely rework mediatek,mt7530 binding

Message

Arınç ÜNAL Aug. 25, 2022, 8:22 a.m. UTC

Hello.

This patch series brings complete rework of the mediatek,mt7530 binding.

The binding is checked with "make dt_binding_check
DT_SCHEMA_FILES=mediatek,mt7530.yaml".

If anyone knows the GIC bit for interrupt for multi-chip module MT7530 in
MT7623AI SoC, let me know. I'll add it to the examples.

If anyone got a Unielec U7623 or another MT7623AI board, please reach out.

v6:
- Do not remove binding for DSA ports from top level.
- On the first patch, remove requiring reg as it's already required by
dsa-port.yaml and define acceptable reg values for the CPU ports.
- Add Krzysztof's Reviewed-by: and Acked-by: to where they're given except
the first patch because of the changes above.

v5:
- Remove lists for single items.
- Split fix reset lines patch, add new patch to fix mediatek,mcm property.
- Remove Rob's Reviewed-by: from first patch because of new changes.
- Add Krzysztof's Reviewed-by: and Acked-by: to where they're given.

v4:
- Define reg property on $defs as it's the same for all switch models.

v3:
- Add Rob's Reviewed-by: to first patch.
- Explain why to invalidating reset-gpios and mediatek,mcm.
- Do not change ethernet-ports to ports on examples.
- Remove platform and, when possible, ethernet nodes from examples.
- Remove pinctrl binding from examples.
- Combine removing unnecesary lines patch with relocating port binding.
- Define $defs of mt7530 and mt7531 port binding and refer to them in each
compatible device.
- Remove allOf: for cases where there's only a single if:.
- Use else: for cpu port 6 which simplifies the binding.
- State clearly that the DSA driver does not support the MT7530 switch in
MT7620 SoCs.

v2:
- Change the way of adding descriptions for each compatible string.
- Split the patch for updating the json-schema.
- Make slight changes on the patch for the binding description.

Arınç ÜNAL (6):
  dt-bindings: net: dsa: mediatek,mt7530: make trivial changes
  dt-bindings: net: dsa: mediatek,mt7530: fix description of mediatek,mcm
  dt-bindings: net: dsa: mediatek,mt7530: fix reset lines
  dt-bindings: net: dsa: mediatek,mt7530: update examples
  dt-bindings: net: dsa: mediatek,mt7530: define phy-mode per switch
  dt-bindings: net: dsa: mediatek,mt7530: update binding description

 .../bindings/net/dsa/mediatek,mt7530.yaml       | 649 +++++++++++++++----
 1 file changed, 527 insertions(+), 122 deletions(-)

Comments

Krzysztof Kozlowski Aug. 26, 2022, 6:45 a.m. UTC | #1

On 25/08/2022 11:22, Arınç ÜNAL wrote:
> Hello.
> 
> This patch series brings complete rework of the mediatek,mt7530 binding.
> 
> The binding is checked with "make dt_binding_check
> DT_SCHEMA_FILES=mediatek,mt7530.yaml".
> 
> If anyone knows the GIC bit for interrupt for multi-chip module MT7530 in
> MT7623AI SoC, let me know. I'll add it to the examples.
> 
> If anyone got a Unielec U7623 or another MT7623AI board, please reach out.
> 
> v6:
> - Do not remove binding for DSA ports from top level.
> - On the first patch, remove requiring reg as it's already required by
> dsa-port.yaml and define acceptable reg values for the CPU ports.
> - Add Krzysztof's Reviewed-by: and Acked-by: to where they're given except
> the first patch because of the changes above.

Review should have stayed. It's a close to trivial change.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof

[e-mail] Aug. 31, 2022, 5:50 a.m. UTC | #2

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[e-mail]>:

On Thu, 25 Aug 2022 11:22:55 +0300 you wrote:
> Hello.
> 
> This patch series brings complete rework of the mediatek,mt7530 binding.
> 
> The binding is checked with "make dt_binding_check
> DT_SCHEMA_FILES=mediatek,mt7530.yaml".
> 
> [...]

Here is the summary with links:
  - [v6,1/6] dt-bindings: net: dsa: mediatek,mt7530: make trivial changes
    https://git.kernel.org/netdev/net-next/c/214537cd8a17
  - [v6,2/6] dt-bindings: net: dsa: mediatek,mt7530: fix description of mediatek,mcm
    https://git.kernel.org/netdev/net-next/c/ba9476f72500
  - [v6,3/6] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines
    https://git.kernel.org/netdev/net-next/c/f565c54e96b6
  - [v6,4/6] dt-bindings: net: dsa: mediatek,mt7530: update examples
    https://git.kernel.org/netdev/net-next/c/c9aece04e01c
  - [v6,5/6] dt-bindings: net: dsa: mediatek,mt7530: define phy-mode per switch
    https://git.kernel.org/netdev/net-next/c/79a16c3b162f
  - [v6,6/6] dt-bindings: net: dsa: mediatek,mt7530: update binding description
    https://git.kernel.org/netdev/net-next/c/cd7e2b97f6ec

You are awesome, thank you!