From patchwork Fri Aug 26 13:54:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Chevallier X-Patchwork-Id: 12956048 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CBC7ECAAA3 for ; Fri, 26 Aug 2022 13:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lUqBfk2bQf0J5+4Qx3vbQj98yk6RPb0L9D8DYzphZlw=; b=R7yVv6DN7WPilh 1hP3cud8HNkbp6rojJScICgKfD8aYvfnJKGabFRd46TNPELWngFE/VfE+eMLW3qmBlmYlNQqamnog 4GfEqz0Bj+uB+1uZYp5imwhxXKEYvfl3J9JtRBy8SU3EABo9f0MQ7eI/vKjd4rZk1JuEJuiNdbMDj FuiCdi238deb+uXkwirJQAcWgl54YrD/ROPUnBdWj3TgxDT0kDjf6d0q+HWhwlzOtm3ayw/VWk2bc R5ajxwav5fUqL26XFvMToFMF+YfM0xQMzXdjdxJQYy3Gqj5JdFO9V5sC54QmrzLU5PfeoE8uACXAp Ph/YiUpJiHqdaMohTZTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRZni-005K1m-Ds; Fri, 26 Aug 2022 13:55:10 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRZnb-005JLd-E8 for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2022 13:55:05 +0000 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 176AA240008; Fri, 26 Aug 2022 13:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1661522096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=YIEtOKyE2S1rP4xNAtZiRn4s6t1T6XAkiZfnPLjfWu4=; b=UvEUK/zYB+YqlMCN5VJVtpW+6MXVn731QA2TuZ+0RYWYpkd6AtzbfFxttccnrUxbr2cKyl 4h06ix7+3+DOzZVAk2E0RZSFsOh4gMzS97l4Q8lo81xF+/n6J9G76uLcJzx9pubyS+g7vG 6FhG7bgAJBkvFvRZ9P1FkvzQvq2fnX+SLLjW2dNSlCoprHXl01YJURpNM1p8YcHwWqe1/O 8Iu0VMcsG5lwA7yZe/6x2O2XTnwHmeCWf8xqDwW2DNMVzR4/R7J1Xa31dPhMxV/ZCOrRf0 6+FVan+2xUqP/DP8+tY7udWW3jjCD6rFVUrUmuUKHIB9AJ29U+c32FVCsicCuQ== From: Maxime Chevallier To: davem@davemloft.net, Rob Herring Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: [PATCH net-next 0/5] net: altera: tse: phylink conversion Date: Fri, 26 Aug 2022 15:54:46 +0200 Message-Id: <20220826135451.526756-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_065503_791076_01F49138 X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series is a rework of a previous series [1], and as Russell stated, it needed work :) The Altera TSE can be built with a SGMII/1000BaseX PCS, allowing to use SFP ports with this MAC, which is the end goal of adding phylink support and a proper PCS driver. The PCS itself can either be mapped in the MAC's register space, in that case, it's accessed through 32 bits registers, with the higher 16 bits always 0. Alternatively, it can sit on its own register space, exposing 16 bits registers, some of which ressemble the standard PHY registers. To tackle that rework, several things needs updating, starting by the DT binding, since we add support for a new register range for the PCS. Hence, the first patch of the series is a conversion to YAML of the existing binding. Then, patch 2 does a bit of simple cleanup to the TSE driver, using nice reverse xmas tree definitions. Patch 3 adds the actual PCS driver, as a standalone driver. Some future series will then reuse that PCS driver from the dwmac-socfpga driver, which implements support for this exact PCS too, allowing to share the code nicely. Patch 4 is then a phylink conversion of the altera_tse driver, to use this new PCS driver. Finally, patch 5 updates the newly converted DT binding to support the pcs register range. This series contains bits and pieces for this conversion, please tell me if you want me to send it as individual patches. Thanks, Maxime [1] : https://lore.kernel.org/netdev/20220823140517.3091239-1-maxime.chevallier@bootlin.com/ Maxime Chevallier (5): dt-bindings: net: Convert Altera TSE bindings to yaml net: altera: tse: cosmetic change to use reverse xmas tree ordering net: pcs: add new PCS driver for altera TSE PCS net: altera: tse: convert to phylink dt-bindings: net: altera: tse: add an optional pcs register range .../devicetree/bindings/net/altera_tse.txt | 113 ----- .../devicetree/bindings/net/altr,tse.yaml | 162 +++++++ MAINTAINERS | 7 + arch/arm/boot/dts/Makefile | 3 +- drivers/net/ethernet/altera/Kconfig | 2 + drivers/net/ethernet/altera/altera_tse.h | 19 +- .../net/ethernet/altera/altera_tse_ethtool.c | 22 +- drivers/net/ethernet/altera/altera_tse_main.c | 453 +++++------------- drivers/net/pcs/Kconfig | 6 + drivers/net/pcs/Makefile | 1 + drivers/net/pcs/pcs-altera-tse.c | 162 +++++++ include/linux/pcs-altera-tse.h | 17 + 12 files changed, 519 insertions(+), 448 deletions(-) delete mode 100644 Documentation/devicetree/bindings/net/altera_tse.txt create mode 100644 Documentation/devicetree/bindings/net/altr,tse.yaml create mode 100644 drivers/net/pcs/pcs-altera-tse.c create mode 100644 include/linux/pcs-altera-tse.h