From patchwork Mon Jan 2 16:06:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Mergnat X-Patchwork-Id: 13086804 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50F08C4708E for ; Mon, 2 Jan 2023 16:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Message-Id:Date:From:MIME-Version :Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Uzaz1sa2Ha2exqmVFTM/JQN7dsz7wXoRHH5mlAhWB/o=; b=gC6BF6t1wljZFx eOV7DZlC9+VU63iLAFQnBCfOxWlHt11z9FdcEbrwrZgoML+8F4vqXL79ktrMgLmLeIF4H0Kt8NTZL kwRMfljVPPp4HKAe8Ft6wRspb7d7+4vy0iOnVswrTZcbnIrfHwRz51X8/pc5fkFRuql8sQEbHy+f5 15CZon4jtg4Zi6h6oBG6u4SkcvnAIY1mvijlKbbrEapX2irhvKCPmEKy4hl6QfaVP7r10Hj4VxUfh KSkFqwS1YeTHU5vuV+No5o4tRp3VcKlYq80jsLhCvMF5OtnMdNHH/CnmVBi7AekjMqFukgD1/5kaP c+jbVpKimaN5rZjq07Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCNKy-00CbHu-Vm; Mon, 02 Jan 2023 16:06:57 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCNKT-00Cb6q-Oa for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 16:06:29 +0000 Received: by mail-wr1-x42d.google.com with SMTP id y8so26662949wrl.13 for ; Mon, 02 Jan 2023 08:06:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:from:to:cc:subject:date:message-id:reply-to; bh=yjXxn0Gm+72C4uouOQHc+bGyejQ/xXoLI7xGm1lh+LU=; b=DBhyN0p+sU1au65Ro4tSm2WuyZt+j+NaZhAKpfNLICLjbM5H/QpGwLLOMeHbFxv29y H2FlN7VBQzD1hnwe5cLzuwONwYvpbzHQqAdMp/KBaOPdguNJeXfk0TaTvVhTLTPa4/fq MBVDWtDFs+WXwOI/D7b0Z6vx9YZk3z4OwzGK65RdYmDJ9mKCvmqhTvbWqWR6xH7oVfmN FJqXLe5bKSGnGQY7QINUHY6fmvyNeiJi3V0yVoCQLstULLKPmi+VCgezoU96MP6JMuxZ R6ES20SFZjBXVNEdmzVvST7eUycLV2N4JRTmKRW4kfrKckVDWMqkNJpal7R7+tXgTo5T H7yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:message-id:date:from:content-transfer-encoding:mime-version :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yjXxn0Gm+72C4uouOQHc+bGyejQ/xXoLI7xGm1lh+LU=; b=38wQIbCFvdnQ8yCkAu08cHeAoGsAZ/gYBVFYBdg6lhfdpy1NJyiG9oBOqY93teCpQ3 gQmVvwAAv1812rvfeJMHHyB56j86LoeZLWelX2NyDMlZfqeVJdIBsuFtwLGIDexdBPoF 1/UM8hG8WB4GDiJtSNKKf3/LMsQT3IpjkcpLl2y2fEPAp5o8xOYzG3o8st0ztZhYDUSh 5M4Bwjvb8xi8sUrFi4h9Sh0ilE87OE5O16iOBP2bICNbF+AamDjx4XZxVduzIgKw87+5 Rpr5Qn8WZHfP49qEbax4x7vdOLGF8Jai6fSo/t7fEPBBga2n7QUFwqLBonh3ns2QbkXk r3/A== X-Gm-Message-State: AFqh2kqFC4Tczhj916ybCZwo6/nqxbuew4VX80r+nFZQuuxiiELxjKo4 17D0vpFbsH9WizH7rUwey25osw== X-Google-Smtp-Source: AMrXdXt3Pchs9Wngt3PAgATIOjyl4UrTNzJyUg65G9w7v3CDUOM+cQRnPVTI6yOPy8Rw40P8egVifQ== X-Received: by 2002:adf:fc4a:0:b0:27e:315e:d279 with SMTP id e10-20020adffc4a000000b0027e315ed279mr16343571wrs.32.1672675582751; Mon, 02 Jan 2023 08:06:22 -0800 (PST) Received: from [127.0.1.1] (158.22.5.93.rev.sfr.net. [93.5.22.158]) by smtp.googlemail.com with ESMTPSA id t5-20020a5d49c5000000b0028cf987d944sm11868020wrs.33.2023.01.02.08.06.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 08:06:22 -0800 (PST) Subject: [PATCH v8 0/6] Add MediaTek MT6357 PMIC support MIME-Version: 1.0 X-b4-tracking: H4sIAOkAs2MC/33QwWrDMAwA0F8pPs/DkSPL2Wn/MXawYmcxpEmx00Ap+fdpO44sJyEJPSE9VU0lp6 reLk9V0pZrXmZJ/MtF9WOYv5LOUXIFBqAxBvV1dRZJ1/vttpRVI1rj2UOydlAyxKEmzSXM/Shj832a pDjmui7l8btkAwkf/3obaKOHhjhAhGhC987hMWUu6bVfrupTtM2eC1YESoYj9bZBhgOhPRdaETACM/ rkjKcDAc8FFMFLK3aIMdp4ILhzwYnQDug7QsdpCAcCnQv0IxDJBQ04av9+ct/3bwTziJL+AQAA From: Alexandre Mergnat Date: Mon, 02 Jan 2023 17:06:01 +0100 Message-Id: <20221005-mt6357-support-v8-0-560caaafee53@baylibre.com> To: Mark Brown , Tianping Fang , Alessandro Zummo , Dmitry Torokhov , Alexandre Belloni , Fabien Parent , Lee Jones , Krzysztof Kozlowski , Chen Zhong , Pavel Machek , Matthias Brugger , Rob Herring , Sean Wang , Flora Fu , Liam Girdwood Cc: Alexandre Mergnat , Mattijs Korpershoek , Krzysztof Kozlowski , linux-rtc@vger.kernel.org, linux-leds@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Fabien Parent , linux-input@vger.kernel.org, linux-mediatek@lists.infradead.org, AngeloGioacchino Del Regno , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.10.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=6715; i=amergnat@baylibre.com; h=from:subject:message-id; bh=y+wz6c4W9HrqoN7G2jonBGgIm26tMVUUbm/Y5LjIEto=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBjswD8T/0NFNmSdPBmNpUaUOCEMfw/f8dvxPpEtDAY 8btKQJeJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCY7MA/AAKCRArRkmdfjHURd15D/ 9nQyB3IXZ8ob1pZ4iFKmdX2Ni08WDhAN66H7D5b6P/dEaDy8MrzhS+PKlh4yC3ofgAzpEQOn5GP+ZJ 6CanCOubi0s4dnuueTlzQLCjjGWg2UwEc1zfLsZ6e495w4Z2OS8UZOfjYZvzhU5lyvrjVByk9eQ65n JXItaBpLqtTI9SVV053Ej2sNEoqTiHBKv63Ae0huQeGq9M+GamEtsYuy68ODlOjixJYyj3M9n4VtNy STPvi61fWp9vLjRkliWxuaJ7bMjSHrLSZZQw8nuPA/U6igBlO2EmR8l0SKdAc8er+LMSFP8IIyrkHG e19KCkiMpbFXBHPIozh7e8+glnpdLJX6KX83stIoi9/48Yl6HKmTVInOh7R8zxo0I/xoe/GeDnOaAJ i2/BdY9RDAMR5PkllXuTeIleZB7M6+v5dC8yf3ABj9iPEowKtyqaEyK7lhCu607N++fzN1OEaPfLLC iT8Xfp3Fp+IKDBzmLAgISeUYssrtgwmTBwNB12oSCfCEZ7bIqdylPsCadwlMIKa8dD1fEkaMFUZkrn H7nuZeaWX4pfSpAfyn6jjUzODNz0fHbBBOMcqad/90B5i1JismpGzT5yoSa+H1IBOWxwZWUz6TyT8C C87sbBxBKXuFhFxBITAjLbH28DCf1eAqZXLbdb/z/smgoSUErI50CDItGQDQ== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_080625_867226_A221844F X-CRM114-Status: GOOD ( 24.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, This patch series adds MFD, PMIC keys, and regulator support for MT6357. MT6357 is a MediaTek PMIC very similar to MT6358. Currently, MTK bindings related to the PMICs are not converted yet (still .txt): soc/mediatek/pwrap.txt (all PMIC parent) | V mfd/mt6397.txt (support lot of mt63XX PMIC) +---------------+----------------+---... V V V regulator/... rtc/... codec/... 1) Convert pwrap to yaml is ok. 2) For the PMIC bindings, there are two option: - Convert mt6397.txt to mediatek,mt6397.yaml and continue to support multiple PMIC with only one file. IMO, the file will be hard to read because the supported features aren't the same for each PMIC. - Make a binding file for each PMIC ref: - mfd/mediatek,mt6357.yaml - mfd/mediatek,mt6358.yaml - ... 3) All PMIC daughter bindings (regulator, rtc, codec, led, ...) aren't fully converted yet. Refering to the two PMIC convertion options above: - To be clean, all daughter bindings should be converted. This is hard because a good understanding of each device is requiered to write efficient bindings. - Only daughter bindings supported by the added PMIC should be converted, that allows to do the task conversion step by step. In the V4 of this serie, I chose the second option. Regards, Alex Changes in v8: - Remove the 2 applied patches (v6.2-rc1) from the serie. - regulator: dt-bindings: Add binding schema for mt6357 regulators - regulator: add mt6357 regulator - Rebase from v6.2-tmp/soc branch, got from kernel/git/matthias.bgg/linux.git - Link to v7: https://lore.kernel.org/r/20221005-mt6357-support-v7-0-477e60126749@baylibre.com Changes in v7: - Drop mt6397 RTC schema conversion. - Integrate mt6357 RTC schema directly in mediatek,mt6357.yaml. - Fix unit address in mediatek,pwrap.yaml. - Link to v6: https://lore.kernel.org/r/20221005-mt6357-support-v6-0-4f589756befa@baylibre.com Changes in v6: - Fix typo in documentations. - Remove mediatek,mt6397-rtc.yaml example. - Align pwrap convertion with the original .txt file. - Remove unecessary include in the mt6357-regulator driver. - Link to v5: https://lore.kernel.org/r/20221005-mt6357-support-v5-0-8210d955dd3d@baylibre.com Changes in v5: - Add missing maintainers - Improve RTC binding by adding rtc.yaml ref and start-year property - Split the txt->yaml conversion in one commit and the addition of the new mt6357-rtc compatible in another commit. - Improve PWRAP binding: - clocks and clock-name have been refactored. - reset-names is now properly dependent to resets. - additionalProperties change from true to false. - change example for a most recent and popular SoC. - "allOf" part has been simplified. - Pass binding tests with the updated tools. Here the command: "make DT_CHECKER_FLAGS=-m dt_binding_check" - Link to v4: https://lore.kernel.org/r/20221005-mt6357-support-v4-0-5d2bb58e6087@baylibre.com Changes in v4: - "dt-bindings: mfd: mt6397: add binding for MT6357" has been applied by Lee Jones - All fixed regulator are now refering to fixed-regulator.yaml - vfe28 and vcamio18 regulators have been added - pwrap binding has been converted and mt8365 support has been added - mt6357 PMIC binding has been created - mt6397 RTC binding has been converted and mt6357 support has been added - Link to v3: https://lore.kernel.org/r/20221005-mt6357-support-v3-0-7e0bd7c315b2@baylibre.com Changes in v3: - To be consistent with regulator/driver.h and helper.c, shift variables have been removed and the mask values have been directly shifted. - Remove index tables and rework volt tables to use set/get helper functions. - Add comment to structure and function. - Fix Fabien Parent mail address. - Link to v2: https://lore.kernel.org/r/20221005-mt6357-support-v2-0-f17ba2d2d0a9@baylibre.com Changes in v2: - Rebase - Fix typo - Remove dependencies with https://lore.kernel.org/all/20220415153629.1817202-1-fparent@baylibre.com/ which is no longer relevant. Previous versions: v1 - https://lore.kernel.org/all/20220531124959.202787-1-fparent@baylibre.com/ To: Lee Jones To: Rob Herring To: Krzysztof Kozlowski To: Matthias Brugger To: Dmitry Torokhov To: Chen Zhong To: Liam Girdwood To: Mark Brown To: Fabien Parent To: Alessandro Zummo To: Alexandre Belloni To: Sean Wang To: Pavel Machek To: Tianping Fang To: Flora Fu Cc: devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: linux-input@vger.kernel.org Cc: Fabien Parent Cc: Rob Herring Cc: linux-rtc@vger.kernel.org Cc: linux-leds@vger.kernel.org Cc: AngeloGioacchino Del Regno Cc: Mattijs Korpershoek Cc: Krzysztof Kozlowski Signed-off-by: Alexandre Mergnat --- Alexandre Mergnat (4): dt-bindings: soc: mediatek: convert pwrap documentation dt-bindings: mfd: mediatek: Add bindings for MT6357 PMIC arm64: dts: mt6358: change node names arm64: dts: mt8173: change node name Fabien Parent (2): dt-bindings: input: mtk-pmic-keys: add binding for MT6357 PMIC Input: mtk-pmic-keys: add MT6357 support .../bindings/input/mediatek,pmic-keys.yaml | 1 + .../devicetree/bindings/leds/leds-mt6323.txt | 2 +- .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 111 ++++++++++++++++ Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +- .../bindings/soc/mediatek/mediatek,pwrap.yaml | 147 +++++++++++++++++++++ .../devicetree/bindings/soc/mediatek/pwrap.txt | 75 ----------- arch/arm64/boot/dts/mediatek/mt6358.dtsi | 6 +- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 +- arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 2 +- drivers/input/keyboard/mtk-pmic-keys.c | 17 +++ 10 files changed, 283 insertions(+), 82 deletions(-) --- base-commit: e32caddfc737a96f6593754c2a08be6b8c1e0cec change-id: 20221005-mt6357-support-55308b82e33f Best regards,