| Message ID | 20221005174343.24240-1-y.oudjana@protonmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support | expand |
Il 05/10/22 19:43, Yassine Oudjana ha scritto: > From: Yassine Oudjana <y.oudjana@protonmail.com> > > Add a driver for the MediaTek MT6735 SoC pin controller. This driver > also supports the pin controller on MT6735M, which lacks 6 physical > pins (198-203) used for MSDC2 on MT6735. > > Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> > --- > MAINTAINERS | 8 + > drivers/pinctrl/mediatek/Kconfig | 6 + > drivers/pinctrl/mediatek/Makefile | 1 + > drivers/pinctrl/mediatek/pinctrl-mt6735.c | 584 +++ > drivers/pinctrl/mediatek/pinctrl-mtk-mt6735.h | 3993 +++++++++++++++++ > 5 files changed, 4592 insertions(+) > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt6735.c > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt6735.h > ..snip.. > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt6735.c b/drivers/pinctrl/mediatek/pinctrl-mt6735.c > new file mode 100644 > index 000000000000..dd9dad9cb142 > --- /dev/null > +++ b/drivers/pinctrl/mediatek/pinctrl-mt6735.c > @@ -0,0 +1,584 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022 Yassine Oudjana <y.oudjana@protonmail.com> > + */ > + > +#include <linux/platform_device.h> > +#include <linux/regmap.h> > + > +#include "pinctrl-mtk-mt6735.h" > +#include "pinctrl-paris.h" > + ..snip.. > + > +/* Pin group registers */ > +#define GPIO_IES 0x000 > +#define GPIO_SMT 0x010 > +#define GPIO_TDSEL0 0x020 > +#define GPIO_TDSEL1 0x024 This is the only reason why I can't give you a Reviewed-by, and I'm sad about that. Please fix that tabulation after #define. > +#define GPIO_RDSEL0 0x028 > +#define GPIO_RDSEL1 0x02c > +#define GPIO_PULLEN0 0x030 > +#define GPIO_PULLEN1 0x040 > +#define GPIO_PULLSEL0 0x050 > +#define GPIO_PULLSEL1 0x060 > +#define GPIO_DRV0 0x070 > +#define GPIO_DRV1 0x074 ...and same here. > +#define GPIO_PUPD0 0x080 > +#define GPIO_PUPD1 0x090 > + Thanks, Angelo
From: Yassine Oudjana <y.oudjana@protonmail.com> This series adds a driver for the pin controller found on the MediaTek MT6735 and MT6735M SoCs. The two differ in the last 6 physical pins, which are used for MSDC2 on MT6735 but don't exist on MT6735M (since MSDC2 doesn't exist on it to begin with). In preparation to document DT bindings for this pin controller, the existing documents for MT67xx SoCs are combined into one in order to eliminate duplicate property definitions and standardize pin configuration node names. Necessary cleanup is done along the way. Changes since v1: - Combine other documents into existing mediatek,mt6779-pinctrl.yaml instead of creating a new document with wild card in its name. - Split first patch into smaller patches focused on specific changes. - Remove syscon compatible from MT6779 DT to avoid a check error. - Fix interrupt count for MT6795. Yassine Oudjana (10): arm64: dts: mediatek: mt6779: Remove syscon compatible from pin controller dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve description dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Make gpio-ranges optional dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6797 dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 arm64: dts: mediatek: mt6797: Make pin configuration nodes follow DT bindings dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6735 pin controller bindings pinctrl: mediatek: Add MT6735 pinctrl driver .../pinctrl/mediatek,mt6779-pinctrl.yaml | 247 +- .../pinctrl/mediatek,mt6797-pinctrl.yaml | 176 - .../pinctrl/mediatek,pinctrl-mt6795.yaml | 224 - MAINTAINERS | 10 +- arch/arm64/boot/dts/mediatek/mt6779.dtsi | 2 +- arch/arm64/boot/dts/mediatek/mt6797.dtsi | 20 +- drivers/pinctrl/mediatek/Kconfig | 6 + drivers/pinctrl/mediatek/Makefile | 1 + drivers/pinctrl/mediatek/pinctrl-mt6735.c | 584 +++ drivers/pinctrl/mediatek/pinctrl-mtk-mt6735.h | 3993 +++++++++++++++++ 10 files changed, 4809 insertions(+), 454 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt6797-pinctrl.yaml delete mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt6735.c create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt6735.h