[v5,0/2] net: phylink: add phylink_set_mac_pm() helper

Message

Shenwei Wang Oct. 13, 2022, 1:39 p.m. UTC

Per Russell's suggestion, the implementation is changed from the helper
function to add an extra property in phylink_config structure because this
change can easily cover SFP usecase too.

Changes in v5:
 - Add fix tag in the commit message

Changes in v4:
 - Clean up the codes in phylink.c
 - Continue the version number

Shenwei Wang (2):
  net: phylink: add mac_managed_pm in phylink_config structure
  net: stmmac: Enable mac_managed_pm phylink config

 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 +
 drivers/net/phy/phylink.c                         | 3 +++
 include/linux/phylink.h                           | 2 ++
 3 files changed, 6 insertions(+)

--
2.34.1

Comments

Russell King (Oracle) Oct. 13, 2022, 4:07 p.m. UTC | #1

On Thu, Oct 13, 2022 at 08:39:02AM -0500, Shenwei Wang wrote:
> Per Russell's suggestion, the implementation is changed from the helper
> function to add an extra property in phylink_config structure because this
> change can easily cover SFP usecase too.

Which tree are you aiming this for - net-next or net?

You should use [PATCH net ...] or [PATCH net-next ...] to indicate which
tree you're aiming these patches for.

Please don't repost due to this unless you want it to go into the net
tree, as net-next is currently closed.

Shenwei Wang Oct. 13, 2022, 7:24 p.m. UTC | #2

> -----Original Message-----
> From: Russell King <[e-mail]>
> Sent: Thursday, October 13, 2022 11:07 AM
> To: Shenwei Wang <[e-mail]>
> Cc: David S. Miller <[e-mail]>; Eric Dumazet
> <[e-mail]>; Jakub Kicinski <[e-mail]>; Paolo Abeni
> <[e-mail]>; Maxime Coquelin <[e-mail]>;
> Andrew Lunn <[e-mail]>; Heiner Kallweit <[e-mail]>;
> Giuseppe Cavallaro <[e-mail]>; Alexandre Torgue
> <[e-mail]>; Jose Abreu <[e-mail]>;
> [e-mail]; [e-mail]; linux-
> [e-mail]; [e-mail]
> Subject: [EXT] Re: [PATCH v5 0/2] net: phylink: add phylink_set_mac_pm() helper
> 
> Caution: EXT Email
> 
> On Thu, Oct 13, 2022 at 08:39:02AM -0500, Shenwei Wang wrote:
> > Per Russell's suggestion, the implementation is changed from the
> > helper function to add an extra property in phylink_config structure
> > because this change can easily cover SFP usecase too.
> 
> Which tree are you aiming this for - net-next or net?
> 

The patch can be applied to both trees.  You can select the one which is easy to
go ahead.

Thanks,
Shenwei

> You should use [PATCH net ...] or [PATCH net-next ...] to indicate which tree
> you're aiming these patches for.
> 
> Please don't repost due to this unless you want it to go into the net tree, as net-
> next is currently closed.
> 
> --
> RMK's Patch system:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.ar
> mlinux.org.uk%2Fdeveloper%2Fpatches%2F&amp;data=05%7C01%7Cshenwei.
> wang%40nxp.com%7C9eb73c5218ab4ca2e25908daad350702%7C686ea1d3bc2
> b4c6fa92cd99c5c301635%7C0%7C0%7C638012740506537030%7CUnknown%7
> CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=ZUtXNJ8wXqhi9Tvcg51uJJvcS
> 9CbJt6yxF3zjuoEfuQ%3D&amp;reserved=0
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

Russell King (Oracle) Oct. 14, 2022, 10:17 a.m. UTC | #3

On Thu, Oct 13, 2022 at 07:24:02PM +0000, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Russell King <[e-mail]>
> > Sent: Thursday, October 13, 2022 11:07 AM
> > On Thu, Oct 13, 2022 at 08:39:02AM -0500, Shenwei Wang wrote:
> > > Per Russell's suggestion, the implementation is changed from the
> > > helper function to add an extra property in phylink_config structure
> > > because this change can easily cover SFP usecase too.
> > 
> > Which tree are you aiming this for - net-next or net?
> 
> The patch can be applied to both trees.  You can select the one which is easy to
> go ahead.

That may be the case at the moment, because the net-next tree has been
merged into mainline and the net tree recently updated to mainline, but
that is not always the case.

The purpose of the tag in the subject line is to tell the various
maintainers on the netdev mailing list what _your_ expectation is for
the patch and where _you_ intend it to be applied.

Thanks.