From patchwork Thu Oct 20 16:26:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13013752 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94F6CC4332F for ; Thu, 20 Oct 2022 16:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=2cZBurZeK0HphIuVMz7IfIZSrkPsUqwIE4S+n588jv4=; b=d+EOzzPAsY8GBv BPv8LLvIOLNWcyeMS5ZgChY3dwMYOjuCPTE67/s99S3V0aOULs6jIGRgIrloeLlXM4jXi0N/73+a2 Ky8dvJsCEH/aoC21wpWWm7vy3K/AuLKzg6ELM6YbEhCBG/NtfR9kFBNjjAI0y1NpWSiQua5G2dGlu dIIGek35MgjdkG/vobQQEpXBWXIvwnMhVR8kXg5tS82Qbl2sVfXZWPBDao30Q1PydFkm3NP7dHfqj kfDuVmf+8YuJy712QeD+3JAJoSxVjGiLjzCm4s7azncHuuAGVuCdY7Eng5btVEtr+zZSoKThZ+7Kb dOMbLLclHJbhrNXZxqnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olYO2-000JZM-Vu; Thu, 20 Oct 2022 16:27:15 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olYN9-000J9b-8G for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 16:26:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666283179; x=1697819179; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=L1PpsyQD3YIK+QP7eDAPlt7fNZIEOmcOxOCOyV/CAlg=; b=CR7qimrFuUjVVNP8on2TTaF2d3n4KA9SiDx7Y0q2Sca0BzX+opFcLHZK Re0o3AmWuhapXjYVjTEyNafg0jT2cflLzWVZYcGhLLOVdTliyMFatjApw MfSWnb6JndB6yn0NaKKsC7X36p9W+qaO6+ZpaxtvC5kAZQoYl9OBtlIXK blzxf1be6u5Q4oEX5t3UWzdVPtuOzQ5QRj5CPZh/Yb3hTDHM71boEn8cm oeB3x7a5Rsl6sfW7at35AHzgPPuV63YuRwlth60YV9G0I6p3dQQPyV5nZ NhNrweyytOUb3soF9sEG4bes7Z7vnaimSloHrgSQpdcDbQL1BM7ANAC/I g==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="286482343" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="286482343" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 09:26:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="581004363" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="581004363" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 20 Oct 2022 09:26:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id A2394291; Thu, 20 Oct 2022 19:26:32 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown Subject: [PATCH v3 0/5] spi: pxa2xx: Pass the SSP type via device property Date: Thu, 20 Oct 2022 19:26:26 +0300 Message-Id: <20221020162631.68914-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_092619_376826_BA9758ED X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the SPI PXA2xx devices on Intel platforms can be instantiated via the following paths: 1) as ACPI LPSS device on Haswell, Bay Trail and Cherry Trail; 2) as ACPI LPSS device on the Sky Lake and newer; 3) as PCI LPSS device on Haswell, Bay Trail and Cherry Trail; 4) as PCI LPSS device on the Sky Lake and newer; 5) as PCI device via ID table. Each of these cases provides some platform related data differently, i.e.: 1) via drivers/acpi/acpi_lpss.c and drivers/spi/spi-pxa2xx.c 2) via drivers/mfd/intel-lpss-acpi.c 3) via drivers/spi/spi-pxa2xx-pci.c 4) via drivers/mfd/intel-lpss-pci.c and drivers/spi/spi-pxa2xx.c 5) via drivers/spi/spi-pxa2xx-pci.c This approach has two downsides: a) there is no data propagated in the case #2 because we can't have two or more drivers to match the same ACPI ID and hence some cases are still not supported (Sky Lake and newer ACPI enabled LPSS); b) the data is duplicated over two drivers in the cases #1 & #4 and, besides to be a bloatware, it is error prone (e.g. Lakefield has a wrong data right now due to missed PCI entry in the spi-pxa2xx.c). This series fixes the downsides, and enables previously unsupported cases. On top of that it has a couple of cleanups (patches 4 and 5). Changelog v3: - added tags to patches 4 & 5 (Jonathan) - massaged cover letter Changelog v2: - added cover letter (Mark) - dropped applied patch Andy Shevchenko (5): spi: pxa2xx: Respect Intel SSP type given by a property spi: pxa2xx: Remove no more needed PCI ID table spi: pxa2xx: Remove no more needed driver data spi: pxa2xx: Move OF and ACPI ID tables closer to their user spi: pxa2xx: Switch from PM ifdeffery to pm_ptr() drivers/spi/spi-pxa2xx.c | 170 +++++++------------------------------ include/linux/pxa2xx_ssp.h | 1 + 2 files changed, 30 insertions(+), 141 deletions(-)