From patchwork Thu Oct 20 19:44:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13013955 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D559DC433FE for ; Thu, 20 Oct 2022 19:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ENZBQeTuravSuCyFeY6jeuBusVACaForvrTKXgPJ6iA=; b=ouFrzfwRBtoNKb e/+z4Twg8iZ6kXlJuVH9FTiUqz6WV3vEx7SOroLYWzIyMqnMf/0DMm7eNq9brMZoem688you2P4V5 PykoawvaDNC+0yXGwuEknev2vh5SgZVjRJQgZ5ZkrlrPOxDnbk0ijmG8B3hM1GQGIPrIoGmythxOR D13B5YbmnHHA4tCvemkHVqLlETssWFA5ia1SkJvFzIOMtuty5+/tleYVQ+OU5ZcL0On0WelTp4dGC 4S7jw2NzFVG6P5lV5+Uqv320iLrkeKFZrto6CVnAFetkgGPe97yQ5Vz3bRo32Jf610d/FprZ8WiC8 DiYADoKGT52IJBtxmUYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olbTI-001TMY-3W; Thu, 20 Oct 2022 19:44:52 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olbTD-001TJN-Te for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 19:44:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666295087; x=1697831087; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=cDRbvPGMB4daHpf4H0/xcqTeuiVnp6lHkMnNi54s/1I=; b=kYI1EdIINm3kt1dDEIerhLNKyN4k2fgrH4r2ZGrhUAiR9+KzCYc5t7Bg 30VwOSUlwK+0m/1tBz1D89KagD/gvnd8dDHRLfskya4jkR7oyMlcqm9Zq Cu8Xr4f1EV7/0gipseEHq6qHOHbrna+ClIu8RuOcVP/Hy+Y9EnrorvMLQ tqTLxHHBCMsvGSqoStzcaAGLG8C1pEDzBeWkCjB2DAFpAojK3ZKSA2/Nn F0qy7P54MfXDm58kvYWyjjF/4jMgUbGnfeRHDRz2S0M4s9Lv7Qid9lPtE cYYWRPep24KZUeZO8soKWJ2qS9xrtrXiPD/xCoy4Tfu8SdFVMLJi28Wg8 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="286542458" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="286542458" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 12:44:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="630031800" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="630031800" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 20 Oct 2022 12:44:42 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id DA0E3107; Thu, 20 Oct 2022 22:45:03 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Mark Brown Subject: [PATCH v4 0/5] spi: pxa2xx: Pass the SSP type via device property Date: Thu, 20 Oct 2022 22:44:55 +0300 Message-Id: <20221020194500.10225-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_124448_002562_2DE089BF X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Currently the SPI PXA2xx devices on Intel platforms can be instantiated via the following paths: 1) as ACPI LPSS device on Haswell, Bay Trail and Cherry Trail; 2) as ACPI LPSS device on the Sky Lake and newer; 3) as PCI LPSS device on Haswell, Bay Trail and Cherry Trail; 4) as PCI LPSS device on the Sky Lake and newer; 5) as PCI device via ID table. Each of these cases provides some platform related data differently, i.e.: 1) via drivers/acpi/acpi_lpss.c and drivers/spi/spi-pxa2xx.c 2) via drivers/mfd/intel-lpss-acpi.c 3) via drivers/spi/spi-pxa2xx-pci.c 4) via drivers/mfd/intel-lpss-pci.c and drivers/spi/spi-pxa2xx.c 5) via drivers/spi/spi-pxa2xx-pci.c This approach has two downsides: a) there is no data propagated in the case #2 because we can't have two or more drivers to match the same ACPI ID and hence some cases are still not supported (Sky Lake and newer ACPI enabled LPSS); b) the data is duplicated over two drivers in the cases #1 & #4 and, besides to be a bloatware, it is error prone (e.g. Lakefield has a wrong data right now due to missed PCI entry in the spi-pxa2xx.c). This series fixes the downsides, and enables previously unsupported cases. On top of that it has a couple of cleanups (patches 4 and 5). Changelog v4: - apply the property only for known MFD enumerated devices (Mark) Changelog v3: - added tags to patches 4 & 5 (Jonathan) - massaged cover letter Changelog v2: - added cover letter (Mark) - dropped applied patch Andy Shevchenko (5): spi: pxa2xx: Respect Intel SSP type given by a property spi: pxa2xx: Remove no more needed PCI ID table spi: pxa2xx: Move OF and ACPI ID tables closer to their user spi: pxa2xx: Consistently use dev variable in pxa2xx_spi_init_pdata() spi: pxa2xx: Switch from PM ifdeffery to pm_ptr() drivers/spi/spi-pxa2xx.c | 186 ++++++++----------------------------- include/linux/pxa2xx_ssp.h | 1 + 2 files changed, 41 insertions(+), 146 deletions(-)