From patchwork Tue Oct 25 09:02:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 13018800 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A8E7C38A2D for ; Tue, 25 Oct 2022 09:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=njmbMH/c7EyWxBZVBVNKB2uQjoAyvjWg2Pg3nzl4PCw=; b=zfMA7FXRNLhgAK MJ0a0nIUuigszUrq6EO50bzlMowi1fehmY3V9mFngfxFngPRLJR0cXsJPZLJN/SNN9A4FWMnl71Hr zZr1vkXV4+oULgdPyK7m/DwH1zTLLeWf0TOzw8xxXHauxrgPklSUdkUQSAQOMWc+u14hbjtaJYxlE zeox736ai+Qax+AdPKamj5l8p7Y0eqfVwaD46b5mpJJiB0WiNwXPg8/ticix0gHizDS9gNCj0hYqA NpWCszlh3a04TALMsCTXygCDhGSmdNaQQg5rkI8gNvJeKC9dXweWIjc8SRa+6CycxTkkJ60wIsjXb nGQOafCBjUBNYq/aaGLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1onFqe-004PMy-H1; Tue, 25 Oct 2022 09:03:48 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1onFqG-004PCs-9H for linux-arm-kernel@lists.infradead.org; Tue, 25 Oct 2022 09:03:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666688604; x=1698224604; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wcNkbfUgqXT7nAfmkdFbESesrvdKH9TGwWLIWOtxlR0=; b=si6+1kLnNN5aL2AVG3whGExoEatt2mKaW5V3+4E4K+0+JRpAD7UUnhyJ zCK+6SJH4CzrHk62nm3DO7XRCg0/6WiCBhVfpTArphdKmV2JC1PEY5e11 xsfcykvIX+D+jlboml4HVKqW2K8OrFAG+J6wkUOT5Lt348rZLQIIVEsyc iDFiC+1l1IJX8yzj8jyHreUrTGKE0Oe0Go2DOMvcLv7pbTMUHBjwsTDph PVXaFku6jycdZt8bcRtfcF4EFqibbwncwsN7TQ8kdQWkgYW4Q6c9IHTzB 2tzzEyAhEV2lRrG2tF2Z4H841WAg8h/quFx+swOlO30nO7JCwxyy+4GFn Q==; X-IronPort-AV: E=Sophos;i="5.95,211,1661842800"; d="scan'208";a="183777233" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 25 Oct 2022 02:03:17 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 25 Oct 2022 02:03:12 -0700 Received: from ROB-ULT-M18064N.mchp-main.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Tue, 25 Oct 2022 02:03:10 -0700 From: Tudor Ambarus To: , , Subject: [PATCH v2 00/32] dmaengine: at_hdmac: Fix concurrency bugs and then convert to virt-dma Date: Tue, 25 Oct 2022 12:02:34 +0300 Message-ID: <20221025090306.297886-1-tudor.ambarus@microchip.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221025_020324_437343_0499B22D X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tudor Ambarus , maciej.sosnowski@intel.com, linux-kernel@vger.kernel.org, mripard@kernel.org, linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, torfl6749@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v2: - reorder patches so that fixes come first -> easier to backport to stable kernels. - drop the devm_request_irq() patch as we had to disable the irq anyway in remove() in order to avoid spurios IRQs. Using devm variant brings no palpable benefit. - reword pm_ptr commit message at_hdmac driver had poor list handling and concurrency bugs. We experienced calling of the completion call twice for the same descriptor. Peter Rosin encountered the same while reporting a different bug: https://lore.kernel.org/lkml/13c6c9a2-6db5-c3bf-349b-4c127ad3496a@axentia.se/ Two sets of tests were performed: 1/ tested just the fixes, to make sure everything is fine and the concurrency bugs are squashed even without the conversion to virt-dma. All went fine. 2/ tested the entire series including the conversion the virt-dma All went fine. I tested NAND (prep_dma_memcpy), MMC (prep_dma_slave_sg), usart (cyclic mode), dmatest (memcpy, memset). With the conversion to virt-dma I replaced the election of a new transfer in the tasklet with the election of the new transfer in the interrupt handler. We should have a shorter idle window as we remove the scheduling latency of the tasklet. Using mtd_speedtest showed similar performances when using NAND with DMA. That could be because of using a low timming mode on NAND. Tudor Ambarus (32): dmaengine: at_hdmac: Fix at_lli struct definition dmaengine: at_hdmac: Don't start transactions at tx_submit level dmaengine: at_hdmac: Start transfer for cyclic channels in issue_pending dmaengine: at_hdmac: Fix premature completion of desc in issue_pending dmaengine: at_hdmac: Do not call the complete callback on device_terminate_all dmaengine: at_hdmac: Protect atchan->status with the channel lock dmaengine: at_hdmac: Fix concurrency problems by removing atc_complete_all() dmaengine: at_hdmac: Fix concurrency over descriptor dmaengine: at_hdmac: Free the memset buf without holding the chan lock dmaengine: at_hdmac: Fix concurrency over the active list dmaengine: at_hdmac: Fix descriptor handling when issuing it to hardware dmaengine: at_hdmac: Fix completion of unissued descriptor in case of errors dmaengine: at_hdmac: Don't allow CPU to reorder channel enable dmaengine: at_hdmac: Fix impossible condition dmaengine: at_hdmac: Check return code of dma_async_device_register dmaengine: at_hdmac: Do not print messages on console while holding the lock dmaengine: at_hdmac: Return dma_cookie_status()'s ret code when txstate is NULL dmaengine: at_hdmac: Remove superfluous cast dmaengine: at_hdmac: Pass residue by address to avoid unnecessary implicit casts dmaengine: at_hdmac: s/atc_get_bytes_left/atc_get_residue dmaengine: at_hdmac: Introduce atc_get_llis_residue() dmaengine: at_hdmac: Use devm_kzalloc() and struct_size() dmaengine: at_hdmac: Use devm_platform_ioremap_resource dmaengine: at_hdmac: Use devm_clk_get() dmaengine: at_hdmac: Use pm_ptr() dmaengine: at_hdmac: Set include entries in alphabetic order dmaengine: at_hdmac: Keep register definitions and structures private to at_hdmac.c dmaengine: at_hdmac: Use bitfield access macros dmaengine: at_hdmac: Rename "dma_common" to "dma_device" dmaengine: at_hdmac: Rename "chan_common" to "dma_chan" dmaengine: at_hdmac: Remove unused member of at_dma_chan dmaengine: at_hdmac: Convert driver to use virt-dma MAINTAINERS | 1 - drivers/dma/Kconfig | 1 + drivers/dma/at_hdmac.c | 1899 ++++++++++++++++++----------------- drivers/dma/at_hdmac_regs.h | 478 --------- 4 files changed, 990 insertions(+), 1389 deletions(-) delete mode 100644 drivers/dma/at_hdmac_regs.h Acked-by: Nicolas Ferre