[0/2] drm/rockchip: vop2: fix IOMMU warnings after reenable

Message

Michael Tretter Oct. 28, 2022, 9:52 a.m. UTC

Hi,

I was observing a lot of warnings that the IOMMU has blocked accessed by the
VOP2 when I disabled and reenabled the VOP2 by shutting down a DRM user space
application (namely Weston) and restarting it.

The reason for the warnings was that the address of the last framebuffer was
still residing in the read register of Smart0-win0. After enabling the VOP2,
the Smart0-win0 was still enabled and started reading from the address.

This series makes sure that the planes are disabled when the CRTC is disabled
to make sure that the VOP2 is always started with disabled overlays.

Michael

Michael Tretter (2):
  drm/rockchip: vop2: fix null pointer in plane_atomic_disable
  drm/rockchip: vop2: disable planes when disabling the crtc

 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Heiko Stuebner Oct. 29, 2022, 1 p.m. UTC | #1

On Fri, 28 Oct 2022 11:52:04 +0200, Michael Tretter wrote:
> I was observing a lot of warnings that the IOMMU has blocked accessed by the
> VOP2 when I disabled and reenabled the VOP2 by shutting down a DRM user space
> application (namely Weston) and restarting it.
> 
> The reason for the warnings was that the address of the last framebuffer was
> still residing in the read register of Smart0-win0. After enabling the VOP2,
> the Smart0-win0 was still enabled and started reading from the address.
> 
> [...]

Applied, thanks!

[1/2] drm/rockchip: vop2: fix null pointer in plane_atomic_disable
      commit: 471bf2406c043491b1a8288e5f04bc278f7d7ca1
[2/2] drm/rockchip: vop2: disable planes when disabling the crtc
      commit: 447fb14bf07905b880c9ed1ea92c53d6dd0649d7

Best regards,