From patchwork Fri Oct 28 15:49:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Chevallier X-Patchwork-Id: 13023882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FDE9ECAAA1 for ; Fri, 28 Oct 2022 15:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=gE46s11Oj4A7WTgHur7K5UT9IADicf3hzzZo1/PiXhY=; b=WYSex7L3lwsrKo ZcPDIXFAhMexv+T7adRBu1pSWYsrbn3OBnlm1OR7jDVmdY/UvEswnK9hye0k4xuR5vZcCSQVOPNI7 n8r8oWrEqO4lZkoDRxwDc0jj+glJYLFyUabw2FkjK03B/H2VZqi4Ju8ss6kHUWMfHmKV8k3t+PKfh QWYL+hzOj+dkq6Z16OKOnE0FDT17oPLvB3hXdlDuzdWKzKox3iOcYs4lUy4zrMCzx04ci6Zi6XBtQ qLfDnQdQK8HcW6YMzE7G+b4lN0wqSYjXyY91tJH1d8eQ1fkINt8c2Pj7jDSOQj1EsNfIOaErucgjl 3KywToTNDu4d55oYfhdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooRd2-000eyF-Gg; Fri, 28 Oct 2022 15:50:41 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooRby-000eV5-S2 for linux-arm-kernel@lists.infradead.org; Fri, 28 Oct 2022 15:49:37 +0000 Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id EDC3324000D; Fri, 28 Oct 2022 15:49:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1666972168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=f23mXktPnjBIbQnylG+4fHP9q0uzvSm8Mys4clA2Wyg=; b=a9wF6nGSZcwRGb55YkTPYESTmNRJxwlOMLvuXH4yrMellZVomcLGHG27XIHgHjQrs9zP9N nxEW2FAkPXPrvpQDHm4V/mSNqvDgU8LD5iGUeGLrICrR777uqvxbZ75Eh1CSaJnSKMaxTr QDWzF+Y5A44uQyHKONDcW3rirm7HtVH5c/CL5qkHKt4n/FYBZb6ym0rS4Xh8RylJC+c2fH oK43OudHEYcx5SQEBXDz2mRDn/M9XnILWqe6wJaiXZJUsfwK7bPsj1dMOUYcgLOhVdEQ0c tVBg6I4GN5fjUzXqRhDtUdm4x0qdeWSh1raPJRbRUAp2BQ62i0UqWRToAGH+bg== From: Maxime Chevallier To: davem@davemloft.net, Rob Herring , Krzysztof Kozlowski Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Vladimir Oltean , Luka Perkov , Robert Marko Subject: [PATCH net-next v6 0/5] net: ipqess: introduce Qualcomm IPQESS driver Date: Fri, 28 Oct 2022 17:49:19 +0200 Message-Id: <20221028154924.789116-1-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_084935_418408_0807940B X-CRM114-Status: GOOD ( 20.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello everyone, This is the 6th iteration on the IPQESS driver, that includes a new DSA tagger to let the MAC convey the tag to the switch through an out-of-band medium, here using DMA descriptors. Notables changes on V6 : - Cleanup unused helpers and fields in the tagger - Cleanup ordering in various files - Added more documentation on the tagger - Fixed the CHANGEUPPER caching - Cleanups in the IPQESS driver Thanks Andrew, Vlad and Krzysztof for the reviews ! Notables changes on V5 : - Fix caching of CHANGEUPPER events - Use a skb extension-based tagger - Rename the binding file - Some cleanups in the ipqess driver itself Notables changes on V4 : - Cache the uses_dsa info from CHANGEUPPER events - Use better string handling helpers for ethtool stats - rename ethtool callbacks - Fix a binding typo Notables changes on V3 : - Took into account Russell's review on the ioctl handler and the mac capabilities that were missing - Took Andrew's reviews into account by reworking the napi rx loop, some stray "inline" keywords, and useless warnings - Took Vlad's reviews into account by reworking a few macros - Took Christophe's review into account by removing extra GFP_ZERO - Took Rob's review into account by simplifying the binding Notables changes on V2 : - Put the DSA tag in the skb itself instead of using skb->shinfo - Fixed the initialisation sequence based on Andrew's comments - Reworked the error paths in the init sequence - Add support for the clock and reset lines on that controller - Fixed and updated the binding The driver itself is pretty straightforward, but has lived out-of-tree for a while. I've done my best to clean-up some outdated API calls, but some might remain. This controller is somewhat special, since it's part of the IPQ4019 SoC which also includes an QCA8K switch, and uses the IPQESS controller for the CPU port. The switch is so tightly intergrated with the MAC that it is connected to the MAC using an internal link (hence the fact that we only support PHY_INTERFACE_MODE_INTERNAL), and this has some consequences on the DSA side. The tagging for the switch isn't done inband as most switch do, but out-of-band, the DSA tag being included in the DMA descriptor. This series includes a new out-of-band tagger that uses skb extensions to convey the tag between the tagger and the MAC driver. Thanks to the Sartura folks who worked on a base version of this driver, and provided test hardware. Best regards, Maxime Chevallier Maxime Chevallier (5): net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller net: ipqess: introduce the Qualcomm IPQESS driver net: dsa: add out-of-band tagging protocol net: ipqess: Add out-of-band DSA tagging support ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller .../bindings/net/qcom,ipq4019-ess-edma.yaml | 94 ++ Documentation/networking/dsa/dsa.rst | 13 +- MAINTAINERS | 8 + arch/arm/boot/dts/qcom-ipq4019.dtsi | 44 + drivers/net/ethernet/qualcomm/Kconfig | 12 + drivers/net/ethernet/qualcomm/Makefile | 2 + drivers/net/ethernet/qualcomm/ipqess/Makefile | 8 + drivers/net/ethernet/qualcomm/ipqess/ipqess.c | 1307 +++++++++++++++++ drivers/net/ethernet/qualcomm/ipqess/ipqess.h | 522 +++++++ .../ethernet/qualcomm/ipqess/ipqess_ethtool.c | 164 +++ include/linux/dsa/oob.h | 16 + include/linux/skbuff.h | 3 + include/net/dsa.h | 2 + net/core/skbuff.c | 10 + net/dsa/Kconfig | 9 + net/dsa/Makefile | 1 + net/dsa/tag_oob.c | 48 + 17 files changed, 2262 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq4019-ess-edma.yaml create mode 100644 drivers/net/ethernet/qualcomm/ipqess/Makefile create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.c create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.h create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess_ethtool.c create mode 100644 include/linux/dsa/oob.h create mode 100644 net/dsa/tag_oob.c