[net-next,0/6] Add support for sorted VCAP rules in Sparx5

Message

Steen Hegelund Nov. 11, 2022, 1:05 p.m. UTC

This provides support for adding Sparx5 VCAP rules in sorted order, VCAP
rule counters and TC filter matching on ARP frames.

It builds on top of the initial IS2 VCAP support found in these series:

https://lore.kernel.org/all/[e-mail]/
https://lore.kernel.org/all/[e-mail]/

Functionality
=============

When a new VCAP rule is added the driver will now ensure that the rule is
inserted in sorted order, and when a rule is removed, the remaining rules
will be moved to keep the sorted order and remove any gaps in the VCAP
address space.

A VCAP rule is ordered using these 3 values:

 - Rule size: the count of VCAP addresses used by the rule.  The largest
   rule have highest priority

 - Rule User: The rules are ordered by the user enumeration

 - Priority: The priority provided in the flower filter.  The lowest value
   has the highest priority.

A VCAP instance may contain the counter as part of the VCAP cache area, and
this counter may be one or more bits in width.  This type of counter
automatically increments its value when the rule is hit.

Other VCAP instances have a dedicated counter area outside of the VCAP and
in this case the rule must contain the counter id to be able to locate the
counter value and cause the counter to be incremented.  In this case there
must also be a VCAP rule action that sets the counter id.

The Sparx5 IS2 VCAP uses a dedicated counter area with 32bit counters.

This series adds support for getting VCAP rule counters and provide these
via the TC statistic interface.

This only support packet counters, not byte counters.

Finally the series adds support for the ARP frame dissector and configures
the Sparx5 IS2 VCAP to generate the ARP keyset when ARP traffic is
received.

Delivery:
=========

This is current plan for delivering the full VCAP feature set of Sparx5:

- DebugFS support for inspecting rules
- TC protocol all support
- Sparx5 IS0 VCAP support
- TC policer and drop action support (depends on the Sparx5 QoS support
  upstreamed separately)
- Sparx5 ES0 VCAP support
- TC flower template support
- TC matchall filter support for mirroring and policing ports
- TC flower filter mirror action support
- Sparx5 ES2 VCAP support


Steen Hegelund (6):
  net: flow_offload: add support for ARP frame matching
  net: microchip: sparx5: Add support for TC flower ARP dissector
  net: microchip: sparx5: Add/delete rules in sorted order
  net: microchip: sparx5: Add support for IS2 VCAP rule counters
  net: microchip: sparx5: Add support for TC flower filter statistics
  net: microchip: sparx5: Add KUNIT test of counters and sorted rules

 .../microchip/sparx5/sparx5_tc_flower.c       | 144 +++++
 .../microchip/sparx5/sparx5_vcap_impl.c       |  76 ++-
 .../net/ethernet/microchip/vcap/vcap_api.c    | 233 +++++++-
 .../ethernet/microchip/vcap/vcap_api_client.h |  14 +
 .../ethernet/microchip/vcap/vcap_api_kunit.c  | 526 ++++++++++++++++++
 include/net/flow_offload.h                    |   6 +
 net/core/flow_offload.c                       |   7 +
 7 files changed, 990 insertions(+), 16 deletions(-)

Comments

[e-mail] Nov. 14, 2022, 11:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Fri, 11 Nov 2022 14:05:13 +0100 you wrote:
> This provides support for adding Sparx5 VCAP rules in sorted order, VCAP
> rule counters and TC filter matching on ARP frames.
> 
> It builds on top of the initial IS2 VCAP support found in these series:
> 
> https://lore.kernel.org/all/[e-mail]/
> https://lore.kernel.org/all/[e-mail]/
> 
> [...]

Here is the summary with links:
  - [net-next,1/6] net: flow_offload: add support for ARP frame matching
    https://git.kernel.org/netdev/net-next/c/70ea86a0dfed
  - [net-next,2/6] net: microchip: sparx5: Add support for TC flower ARP dissector
    https://git.kernel.org/netdev/net-next/c/3a344f99bb55
  - [net-next,3/6] net: microchip: sparx5: Add/delete rules in sorted order
    https://git.kernel.org/netdev/net-next/c/990e483981ea
  - [net-next,4/6] net: microchip: sparx5: Add support for IS2 VCAP rule counters
    https://git.kernel.org/netdev/net-next/c/f13230a47477
  - [net-next,5/6] net: microchip: sparx5: Add support for TC flower filter statistics
    https://git.kernel.org/netdev/net-next/c/40e7fe18abab
  - [net-next,6/6] net: microchip: sparx5: Add KUNIT test of counters and sorted rules
    https://git.kernel.org/netdev/net-next/c/dccc30cc4906

You are awesome, thank you!