From patchwork Thu Dec 8 14:19:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Kocialkowski X-Patchwork-Id: 13068463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A74CC4332F for ; Thu, 8 Dec 2022 14:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WRdZZaPmRIV0YP02+6WF+CpSUwXPkNMRUJPx3CgvMy4=; b=YZ8yx40ryY0JtR tlPwDkb6h9aeE0iLJCVfU4m9FrsgomX+aurtWSADKlL4oaYez2nU83+q1qipiWTYUMgmwcOw/V7YW g6wG1sRE5rtWL5SxwRyl5DBG+8k3RsFx272M4d+eTw8Z/jMeayVvsHZMoJB1BV1ZidylL/fnOCjGl cs7azQEEi8CiDUUkkrfyNpBu282BYpL8H+tF5j9DkRHy0P5mUq3THh/kYJMNdIwavE3B+K8cWjTXa 5yLmKJhl2BsCGZ3BO6JT0ZmQJuRby/CUEt39COvfoxBEOUkCHdLlDoH369HYD1xBCbWRcDMTEgKbm emhEy1rw1n3JO9UP8rRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3HlW-001lxS-6P; Thu, 08 Dec 2022 14:20:46 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3HlH-001liX-S1 for linux-arm-kernel@lists.infradead.org; Thu, 08 Dec 2022 14:20:33 +0000 Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id C0F00C0010; Thu, 8 Dec 2022 14:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1670509227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Er/zpDRtCQXlbS772FbVkPP0n/UrKmzzmTIs7nTLoI4=; b=n1k1Yf0W5V1TTM6CadsEXCVgumhJKTHTq0FWkWUdr9QeBrRsW1ZBLXAs8O0UiZV0hRlV8P wiqNfUm97nmrAPO4f2GrajxSfnn81eoI9sxm6IH5KxBd1iLIbhKKDchR22kKkOLrzZB0Ts hfC2q4CQ9x9K3PpllK+Gm//rzFDWZybKnRsnm0o3VaU3ybwqP/HeMK8jWNuSIcXQm+HSaI Zm0kzal1hQd3Qjh8uFX5nwmWdhssmVKgj/QhTWtzuMsVfPwcLRJ7IRx+fZuwjAHiIWvXSc IBjokKolhZ+pWOxEmvE6OVclNUabiWdcTSFneZXGFwOqkXcbU6WBYGl3/76rUw== From: Paul Kocialkowski To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Cc: Yong Deng , Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Petazzoni , Hans Verkuil , Sakari Ailus , Conor Dooley , Nathan Chancellor Subject: [PATCH v3 00/12] Allwinner A31/A83T CSI/ISP/MIPI CSI-2 media fixes Date: Thu, 8 Dec 2022 15:19:54 +0100 Message-Id: <20221208142006.425809-1-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221208_062032_215508_2C297B43 X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This series resolves reported smatch warnings against the recently-introduced Allwinner A31/A83T CSI, ISP and MIPI CSI-2 drivers. Smatch was ran again on the updated tree and no longer shows any error or warning. Changes since v2: - Added isp params pending buffer fix; - Added fixes tags where needed; - Reworded cosmetic commits; - Changed sunxi-isp to the proper sun6i-isp. Changes since v1: - Added fixes for static struct declarations; - Fixed ISP commit titles by replacing bridge with proc. Paul Paul Kocialkowski (12): media: sun6i-csi: bridge: Fix return code handling in stream off path media: sun6i-csi: bridge: Error out on invalid port to fix warning media: sunxi-csi: bridge: Declare subdev ops as static media: sun6i-csi: capture: Remove useless ret initialization media: sun6i-mipi-csi2: Clarify return code handling in stream off path media: sun8i-a83t-mipi-csi2: Clarify return code handling in stream off path media: sun6i-isp: proc: Fix return code handling in stream off path media: sun6i-isp: proc: Error out on invalid port to fix warning media: sun6i-isp: proc: Declare subdev ops as static media: sun6i-isp: capture: Fix uninitialized variable use media: sun6i-isp: params: Fix incorrect indentation media: sun6i-isp: params: Unregister pending buffer on cleanup drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c | 8 ++++---- .../media/platform/sunxi/sun6i-csi/sun6i_csi_capture.c | 2 +- .../platform/sunxi/sun6i-mipi-csi2/sun6i_mipi_csi2.c | 5 ++--- .../sunxi/sun8i-a83t-mipi-csi2/sun8i_a83t_mipi_csi2.c | 5 ++--- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c | 4 ++-- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c | 6 ++++-- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_proc.c | 8 ++++---- 7 files changed, 19 insertions(+), 19 deletions(-) Reviewed-by: Palmer Dabbelt