| Message ID | 20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: imx-pxp: add support for i.MX7D | expand |
Hi Michael, The whole series has been reviewed, and only the DT bindings need a small change. If you post a v2.1 of just that patch (--in-reply-to v2 and CC me, or I may not notice quickly), I can take the whole series and get it merged in v6.3. On Fri, Jan 13, 2023 at 10:54:07AM +0100, Michael Tretter wrote: > This is v2 of the series to add support for the PXP found on the i.MX7D to the > imx-pxp driver. > > The PXP on the i.MX7D has a few differences compared to the one on the > i.MX6ULL. Especially, it has more processing blocks and slightly different > multiplexers to route the data between the blocks. Therefore, the driver must > configure a different data path depending on the platform. > > While the PXP has a version register, the reported version is the same on the > i.MX6ULL and the i.MX7D. Therefore, we cannot use the version register to > change the driver behavior, but have to use the device tree compatible. The > driver still prints the found version to the log to help bringing up the PXP > on further platforms. > > The patches are inspired by some earlier patches [0] by Laurent to add PXP > support to the i.MX7d. Compared to the earlier patches, these patches add > different behavior depending on the platform. Furthermore, the patches disable > only the LUT block, but keep the rotator block enabled, as it may now be > configured via the V4L2 rotate control. > > In v2, I included Laurent's patch series [1], which was based on this series > anyway and added regmap support. > > Patch 1 converts the dt-binding to yaml. > > Patches 2 to 5 cleanup and refactor the driver in preparation of handling > different PXP versions. > > Patches 6 and 7 add the handling of different platforms and the i.MX7d > specific configuration. > > Patch 8 adds the device tree node for the PXP to the i.MX7d device tree. > > Patches 9 to 15 are the cleanup and enhancement patches to add media > controller support, implement enum_framesizes, and add pxp_read/pxp_write > helpers. > > Patch 16 adds regmap support to the driver. > > Michael > > [0] https://lore.kernel.org/linux-media/20200510223100.11641-1-laurent.pinchart@ideasonboard.com/ > [1] https://lore.kernel.org/linux-media/20230112172507.30579-1-laurent.pinchart@ideasonboard.com > > --- > > Changelog > > v2: > > - fix device tree binding > - reduce log level of PXP version to debug > - drop fallback for missing pdata > - add cleanup and enhancement patches to series > - convert driver to regmap > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> > To: linux-media@vger.kernel.org > To: devicetree@vger.kernel.org > To: Philipp Zabel <p.zabel@pengutronix.de> > To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Alexander Stein <alexander.stein@ew.tq-group.com> > Cc: kernel@pengutronix.de > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: Michael Tretter <m.tretter@pengutronix.de> > > --- > Laurent Pinchart (7): > media: imx-pxp: Sort headers alphabetically > media: imx-pxp: Don't set bus_info manually in .querycap() > media: imx-pxp: Add media controller support > media: imx-pxp: Pass pixel format value to find_format() > media: imx-pxp: Implement frame size enumeration > media: imx-pxp: Introduce pxp_read() and pxp_write() wrappers > media: imx-pxp: Use non-threaded IRQ > > Michael Tretter (9): > dt-bindings: media: fsl-pxp: convert to yaml > media: imx-pxp: detect PXP version > media: imx-pxp: extract helper function to setup data path > media: imx-pxp: explicitly disable unused blocks > media: imx-pxp: disable LUT block > media: imx-pxp: make data_path_ctrl0 platform dependent > media: imx-pxp: add support for i.MX7D > ARM: dts: imx7d: add node for PXP > media: imx-pxp: convert to regmap > > .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 +++++ > .../devicetree/bindings/media/fsl-pxp.txt | 26 -- > arch/arm/boot/dts/imx7d.dtsi | 9 + > drivers/media/platform/nxp/imx-pxp.c | 359 +++++++++++++++------ > 4 files changed, 355 insertions(+), 121 deletions(-) > --- > base-commit: b7bfaa761d760e72a969d116517eaa12e404c262 > change-id: 20230112-imx-pxp-073008b3c857
This is v2 of the series to add support for the PXP found on the i.MX7D to the imx-pxp driver. The PXP on the i.MX7D has a few differences compared to the one on the i.MX6ULL. Especially, it has more processing blocks and slightly different multiplexers to route the data between the blocks. Therefore, the driver must configure a different data path depending on the platform. While the PXP has a version register, the reported version is the same on the i.MX6ULL and the i.MX7D. Therefore, we cannot use the version register to change the driver behavior, but have to use the device tree compatible. The driver still prints the found version to the log to help bringing up the PXP on further platforms. The patches are inspired by some earlier patches [0] by Laurent to add PXP support to the i.MX7d. Compared to the earlier patches, these patches add different behavior depending on the platform. Furthermore, the patches disable only the LUT block, but keep the rotator block enabled, as it may now be configured via the V4L2 rotate control. In v2, I included Laurent's patch series [1], which was based on this series anyway and added regmap support. Patch 1 converts the dt-binding to yaml. Patches 2 to 5 cleanup and refactor the driver in preparation of handling different PXP versions. Patches 6 and 7 add the handling of different platforms and the i.MX7d specific configuration. Patch 8 adds the device tree node for the PXP to the i.MX7d device tree. Patches 9 to 15 are the cleanup and enhancement patches to add media controller support, implement enum_framesizes, and add pxp_read/pxp_write helpers. Patch 16 adds regmap support to the driver. Michael [0] https://lore.kernel.org/linux-media/20200510223100.11641-1-laurent.pinchart@ideasonboard.com/ [1] https://lore.kernel.org/linux-media/20230112172507.30579-1-laurent.pinchart@ideasonboard.com --- Changelog v2: - fix device tree binding - reduce log level of PXP version to debug - drop fallback for missing pdata - add cleanup and enhancement patches to series - convert driver to regmap Signed-off-by: Michael Tretter <m.tretter@pengutronix.de> To: linux-media@vger.kernel.org To: devicetree@vger.kernel.org To: Philipp Zabel <p.zabel@pengutronix.de> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: Fabio Estevam <festevam@gmail.com> Cc: Alexander Stein <alexander.stein@ew.tq-group.com> Cc: kernel@pengutronix.de Cc: linux-imx@nxp.com Cc: linux-arm-kernel@lists.infradead.org Cc: Michael Tretter <m.tretter@pengutronix.de> --- Laurent Pinchart (7): media: imx-pxp: Sort headers alphabetically media: imx-pxp: Don't set bus_info manually in .querycap() media: imx-pxp: Add media controller support media: imx-pxp: Pass pixel format value to find_format() media: imx-pxp: Implement frame size enumeration media: imx-pxp: Introduce pxp_read() and pxp_write() wrappers media: imx-pxp: Use non-threaded IRQ Michael Tretter (9): dt-bindings: media: fsl-pxp: convert to yaml media: imx-pxp: detect PXP version media: imx-pxp: extract helper function to setup data path media: imx-pxp: explicitly disable unused blocks media: imx-pxp: disable LUT block media: imx-pxp: make data_path_ctrl0 platform dependent media: imx-pxp: add support for i.MX7D ARM: dts: imx7d: add node for PXP media: imx-pxp: convert to regmap .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 +++++ .../devicetree/bindings/media/fsl-pxp.txt | 26 -- arch/arm/boot/dts/imx7d.dtsi | 9 + drivers/media/platform/nxp/imx-pxp.c | 359 +++++++++++++++------ 4 files changed, 355 insertions(+), 121 deletions(-) --- base-commit: b7bfaa761d760e72a969d116517eaa12e404c262 change-id: 20230112-imx-pxp-073008b3c857 Best regards,