From patchwork Wed Jan 18 09:54:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: s-vadapalli X-Patchwork-Id: 13106012 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B311FC004D4 for ; Wed, 18 Jan 2023 09:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xhgk4gOKWHuIIXLsiDlsvBkV5EX1mBtduFDni0po1m0=; b=K8yaG6SOENXS1Z INLyLpCSjtuDCcKbw0TrFk5lKyvbJSK5HBGsAAQZK5vrHzr4EVYkyyHk9CmEtxZikcS9WoEceogav jWO+wAN7mAGzY/Yb3pVaoUhzvrzjk/Z1/lViMmrhNt6tU1xJNa7HS3ZSMsTbfVgBKR5oopUEllvqV /JSCzrHRypAn4NTX4ylrdaHqX5Q75wrRe4q0t/XebCmIzSGENq9AI7oHeKpSrhTaAf23amLho+G3i /Pmu4LXe+lNlV/s8vly3z1yZdHoXYyGCnJScyk4kHrZNakN+Qdgkl0zyWXZHXdIlWbondXkzWL1KZ M094b5JxZKFy9Bmvrm0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI59s-000DDH-5C; Wed, 18 Jan 2023 09:55:04 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pI59n-000DAn-VS for linux-arm-kernel@lists.infradead.org; Wed, 18 Jan 2023 09:55:02 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 30I9siVc007299; Wed, 18 Jan 2023 03:54:44 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1674035684; bh=jD3wjH/fKK2EjFCvy9AQqLjvXfkPS+sIQoGZYKdZK18=; h=From:To:CC:Subject:Date; b=MYzqYayCRSaPCoct9pv1gBcdZJScwfiJGiYUN3D864OBmyCBEnV5CEyIMpMHDnUG1 Z2E5YsRisIRwGYVJSnNDO1yL1JSytIPdafR+t3vqMjjbd9HyNXGrjcTQmW+knih64W QPBeZwSnW1ucION926ZQhouer038F7EF2B7jYrCs= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 30I9si9X036444 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 18 Jan 2023 03:54:44 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 18 Jan 2023 03:54:44 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 18 Jan 2023 03:54:44 -0600 Received: from uda0492258.dhcp.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 30I9se8f107670; Wed, 18 Jan 2023 03:54:40 -0600 From: Siddharth Vadapalli To: , , , , , , CC: , , , , , Subject: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver Date: Wed, 18 Jan 2023 15:24:37 +0530 Message-ID: <20230118095439.114222-1-s-vadapalli@ti.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230118_015500_151790_D92CAB04 X-CRM114-Status: UNSURE ( 9.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Delete unreachable code in am65_cpsw_init_cpts() function, which was Reported-by: Leon Romanovsky at: https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal Remove the devm action associated with am65_cpts_release() and invoke the function directly on the cleanup and exit paths. Changes from v2: 1. Drop Reviewed-by tag from Roger Quadros. 2. Add cleanup patch for deleting unreachable error handling code in am65_cpsw_init_cpts(). 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke am65_cpts_release(). Changes from v1: 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This error was reported by kernel test robot at: https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/ 2. Collect Reviewed-by tag from Roger Quadros. v2: https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/ v1: https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/ Siddharth Vadapalli (2): net: ethernet: ti: am65-cpsw: Delete unreachable error handling code net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 ++----- drivers/net/ethernet/ti/am65-cpts.c | 15 +++++---------- drivers/net/ethernet/ti/am65-cpts.h | 5 +++++ 3 files changed, 12 insertions(+), 15 deletions(-) Reviewed-by: Tony Nguyen Reviewed-by: Roger Quadros