mbox series

[v4,0/3] Add ASPEED AST2600 I2C new controller driver

Message ID 20230201103359.1742140-1-ryan_chen@aspeedtech.com (mailing list archive)
Headers show
Series Add ASPEED AST2600 I2C new controller driver | expand

Message

Ryan Chen Feb. 1, 2023, 10:33 a.m. UTC
This series add AST2600 i2c new register set driver. The i2c new
register set have new clock divider option for more flexiable generation.
And also have separate i2c master and slave register set for control.

v4:
-fix i2c-ast2600.c driver buffer mode use single buffer conflit in
 master slave mode both enable.
-fix kmemleak issue when use dma mode.
-fix typo aspeed,i2c-ast2600.yaml compatible is "aspeed,ast2600-i2c"
-fix typo aspeed,i2c-ast2600.ymal to aspeed,i2c-ast2600.yaml

v3:
-fix i2c global clock divide default value.
-remove i2c slave no used dev_dbg info.

v2:
-add i2c global ymal file commit.
-rename file name from new to ast2600.
 aspeed-i2c-new-global.c -> i2c-ast2600-global.c
 aspeed-i2c-new-global.h -> i2c-ast2600-global.h
 i2c-new-aspeed.c -> i2c-ast2600.c
-rename all driver function name to ast2600.

Ryan Chen (3):
  dt-bindings: i2c-ast2600: Add support for AST2600 I2C global
    controller
  dt-bindings: i2c-ast2600: Add support for AST2600 i2C driver
  i2c: aspeed: support ast2600 i2c new register mode driver

 .../i2c/aspeed,i2c-ast2600-global.yaml        |   44 +
 .../bindings/i2c/aspeed,i2c-ast2600.yaml      |   78 +
 MAINTAINERS                                   |   10 +
 drivers/i2c/busses/Kconfig                    |   11 +
 drivers/i2c/busses/Makefile                   |    1 +
 drivers/i2c/busses/i2c-ast2600-global.c       |   94 +
 drivers/i2c/busses/i2c-ast2600-global.h       |   19 +
 drivers/i2c/busses/i2c-ast2600.c              | 1811 +++++++++++++++++
 8 files changed, 2068 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.yaml
 create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.yaml
 create mode 100644 drivers/i2c/busses/i2c-ast2600-global.c
 create mode 100644 drivers/i2c/busses/i2c-ast2600-global.h
 create mode 100644 drivers/i2c/busses/i2c-ast2600.c

Comments

Krzysztof Kozlowski Feb. 2, 2023, 9 a.m. UTC | #1
On 01/02/2023 11:33, Ryan Chen wrote:
> This series add AST2600 i2c new register set driver. The i2c new
> register set have new clock divider option for more flexiable generation.
> And also have separate i2c master and slave register set for control.
> 
> v4:
> -fix i2c-ast2600.c driver buffer mode use single buffer conflit in
>  master slave mode both enable.
> -fix kmemleak issue when use dma mode.
> -fix typo aspeed,i2c-ast2600.yaml compatible is "aspeed,ast2600-i2c"
> -fix typo aspeed,i2c-ast2600.ymal to aspeed,i2c-ast2600.yaml
> 

How this can be a v4? Where are all others?

https://lore.kernel.org/all/?q=dfn%3Aaspeed%2Ci2c-ast2600-global.yaml
https://lore.kernel.org/all/?q=dfn%3Aaspeed%2Ci2c-ast2600.yaml

I see it for the first time.

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 2, 2023, 9:02 a.m. UTC | #2
On 02/02/2023 10:00, Krzysztof Kozlowski wrote:
> On 01/02/2023 11:33, Ryan Chen wrote:
>> This series add AST2600 i2c new register set driver. The i2c new
>> register set have new clock divider option for more flexiable generation.
>> And also have separate i2c master and slave register set for control.
>>
>> v4:
>> -fix i2c-ast2600.c driver buffer mode use single buffer conflit in
>>  master slave mode both enable.
>> -fix kmemleak issue when use dma mode.
>> -fix typo aspeed,i2c-ast2600.yaml compatible is "aspeed,ast2600-i2c"
>> -fix typo aspeed,i2c-ast2600.ymal to aspeed,i2c-ast2600.yaml
>>
> 
> How this can be a v4? Where are all others?
> 
> https://lore.kernel.org/all/?q=dfn%3Aaspeed%2Ci2c-ast2600-global.yaml
> https://lore.kernel.org/all/?q=dfn%3Aaspeed%2Ci2c-ast2600.yaml
> 
> I see it for the first time.

Ah, so v3 was never sent to DT maintainers:
https://lore.kernel.org/all/20220516064900.30517-3-ryan_chen@aspeedtech.com/

Best regards,
Krzysztof