mbox series

[v4,00/15] spi: bcm63xx-hsspi: driver and doc updates

Message ID 20230209200246.141520-1-william.zhang@broadcom.com (mailing list archive)
Headers show
Series spi: bcm63xx-hsspi: driver and doc updates | expand

Message

William Zhang Feb. 9, 2023, 8:02 p.m. UTC 
This patch series include the accumulative updates and fixes for the
driver from Broadcom. It also added a new driver for the updated SPI
controller found in the new BCMBCA SoC. The device tree document is
converted to yaml format and updated accordingly.

Changes in v4:
- Add Reviewed-by tag in patch 2
- Update patch 8 based on latest linux spi git for-next branch code

Changes in v3:
- Clean up spi-controller.yaml and update the example
- Drop the generic compatible string brcm,bcmbca-hsspi from the document 
  and dts files
- Port the cs_change and cs_off logic from SPI core 
  spi_transfer_one_message function to both controller drivers.
- Factor dummy cs workaround into a function, adjust the logic for
  different xfer modes and fine tune message level in bcm63xx-hsspi 
  controller driver
- Replace hard-coded opcode with SPINOR_OP definition
- Add a new patch to export export spi_transfer_cs_change_delay_exec 
  function in the spi core
- Add a new patch to include compatible string brcm,bcmbca-hsspi-v1.0 in 
  bcm63xx-hsspi controller driver
- Minor coding style fix in bcmbca-hsspi controller driver
- Add Acked-by and Reviewed-by tag

Changes in v2:
- Update the dts yaml document and all the related dtsi/dts accordingly
- Fix build error for Alpha platform
- Add a new patch for bcm63xx-hsspi driver to support the new compatible
string
- Make interrupt mode required but keep polling mode as default. Also
add a sysfs option wait_mode for run-time mode change
- Remove use_cs_workaround option and change the transfer logic to try
prepend mode first and if not prependable, switch to dummy cs mode with
clock limit at the 25MHz. Add driver sysfs node xfer_mode for run-time
configuration to dummy cs or prepend mode.
- Withdraw SPI device specific clock gate option patch for now

William Zhang (15):
  dt-bindings: spi: Convert bcm63xx-hsspi bindings to json-schema
  dt-bindings: spi: Add bcmbca-hsspi controller support
  ARM: dts: broadcom: bcmbca: Add spi controller node
  arm64: dts: broadcom: bcmbca: Add spi controller node
  spi: bcm63xx-hsspi: Add new compatible string support
  spi: bcm63xx-hsspi: Endianness fix for ARM based SoC
  spi: bcm63xx-hsspi: Add polling mode support
  spi: export spi_transfer_cs_change_delay_exec function
  spi: bcm63xx-hsspi: Handle cs_change correctly
  spi: bcm63xx-hsspi: Fix multi-bit mode setting
  spi: bcm63xx-hsspi: Add prepend mode support
  spi: spi-mem: Allow controller supporting mem_ops without exec_op
  spi: bcm63xx-hsspi: Disable spi mem dual io read op support
  spi: bcmbca-hsspi: Add driver for newer HSSPI controller
  MAINTAINERS: Add entry for Broadcom Broadband SoC HS SPI drivers

 .../bindings/spi/brcm,bcm63xx-hsspi.yaml      | 134 ++++
 .../bindings/spi/spi-bcm63xx-hsspi.txt        |  33 -
 MAINTAINERS                                   |  12 +
 arch/arm/boot/dts/bcm47622.dtsi               |  18 +
 arch/arm/boot/dts/bcm63138.dtsi               |  18 +
 arch/arm/boot/dts/bcm63148.dtsi               |  18 +
 arch/arm/boot/dts/bcm63178.dtsi               |  19 +
 arch/arm/boot/dts/bcm6756.dtsi                |  19 +
 arch/arm/boot/dts/bcm6846.dtsi                |  18 +
 arch/arm/boot/dts/bcm6855.dtsi                |  19 +
 arch/arm/boot/dts/bcm6878.dtsi                |  19 +
 arch/arm/boot/dts/bcm947622.dts               |   4 +
 arch/arm/boot/dts/bcm963138.dts               |   4 +
 arch/arm/boot/dts/bcm963138dvt.dts            |   4 +
 arch/arm/boot/dts/bcm963148.dts               |   4 +
 arch/arm/boot/dts/bcm963178.dts               |   4 +
 arch/arm/boot/dts/bcm96756.dts                |   4 +
 arch/arm/boot/dts/bcm96846.dts                |   4 +
 arch/arm/boot/dts/bcm96855.dts                |   4 +
 arch/arm/boot/dts/bcm96878.dts                |   4 +
 .../boot/dts/broadcom/bcmbca/bcm4908.dtsi     |  18 +
 .../boot/dts/broadcom/bcmbca/bcm4912.dtsi     |  20 +
 .../boot/dts/broadcom/bcmbca/bcm63146.dtsi    |  19 +
 .../boot/dts/broadcom/bcmbca/bcm63158.dtsi    |  19 +
 .../boot/dts/broadcom/bcmbca/bcm6813.dtsi     |  20 +
 .../boot/dts/broadcom/bcmbca/bcm6856.dtsi     |  18 +
 .../boot/dts/broadcom/bcmbca/bcm6858.dtsi     |  18 +
 .../boot/dts/broadcom/bcmbca/bcm94908.dts     |   4 +
 .../boot/dts/broadcom/bcmbca/bcm94912.dts     |   4 +
 .../boot/dts/broadcom/bcmbca/bcm963146.dts    |   4 +
 .../boot/dts/broadcom/bcmbca/bcm963158.dts    |   4 +
 .../boot/dts/broadcom/bcmbca/bcm96813.dts     |   4 +
 .../boot/dts/broadcom/bcmbca/bcm96856.dts     |   4 +
 .../boot/dts/broadcom/bcmbca/bcm96858.dts     |   4 +
 drivers/spi/Kconfig                           |   9 +
 drivers/spi/Makefile                          |   1 +
 drivers/spi/spi-bcm63xx-hsspi.c               | 488 ++++++++++++-
 drivers/spi/spi-bcmbca-hsspi.c                | 651 ++++++++++++++++++
 drivers/spi/spi-mem.c                         |   2 +-
 drivers/spi/spi.c                             |  20 +-
 include/linux/spi/spi.h                       |   5 +-
 41 files changed, 1620 insertions(+), 79 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/spi/brcm,bcm63xx-hsspi.yaml
 delete mode 100644 Documentation/devicetree/bindings/spi/spi-bcm63xx-hsspi.txt
 create mode 100644 drivers/spi/spi-bcmbca-hsspi.c

Comments

Mark Brown Feb. 10, 2023, 12:53 p.m. UTC | #1 
On Thu, Feb 09, 2023 at 12:02:31PM -0800, William Zhang wrote:
> This patch series include the accumulative updates and fixes for the
> driver from Broadcom. It also added a new driver for the updated SPI
> controller found in the new BCMBCA SoC. The device tree document is
> converted to yaml format and updated accordingly.

Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code.  Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.
Mark Brown Feb. 11, 2023, 12:54 a.m. UTC | #2 
On Thu, 09 Feb 2023 12:02:31 -0800, William Zhang wrote:
> This patch series include the accumulative updates and fixes for the
> driver from Broadcom. It also added a new driver for the updated SPI
> controller found in the new BCMBCA SoC. The device tree document is
> converted to yaml format and updated accordingly.
> 
> Changes in v4:
> - Add Reviewed-by tag in patch 2
> - Update patch 8 based on latest linux spi git for-next branch code
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[08/15] spi: export spi_transfer_cs_change_delay_exec function
        commit: 6e80133abeb09721ec4601de5b1e68be67135309
[09/15] spi: bcm63xx-hsspi: Handle cs_change correctly
        commit: c00d5e93ea018786d98670fc1d0dab4c36c2217c
[10/15] spi: bcm63xx-hsspi: Fix multi-bit mode setting
        commit: 811ff802aaf878ebbbaeac0307a0164fa21e7d40
[11/15] spi: bcm63xx-hsspi: Add prepend mode support
        commit: b7a82103f7c3a9168f0077e35688d4f9ce97294e
[12/15] spi: spi-mem: Allow controller supporting mem_ops without exec_op
        commit: 76a85704cb917e3b25e00f02d5fd46e4e0a9077d
[13/15] spi: bcm63xx-hsspi: Disable spi mem dual io read op support
        commit: c6182a187b33cd00a763ac2490c0f5210b2c4742
[14/15] spi: bcmbca-hsspi: Add driver for newer HSSPI controller
        commit: a38a2233f23b568ca06ca679fb2327447d6b0224
[15/15] MAINTAINERS: Add entry for Broadcom Broadband SoC HS SPI drivers
        commit: 80323599e33f9c19287a1a3707481fb157b27052

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark