From patchwork Fri Mar 17 02:31:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 13178504 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7B5EC6FD1D for ; Fri, 17 Mar 2023 03:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Z5A7Y0mh+lU9vi90Og0CkI1UpY+h2LWfC5nzdzTB0nY=; b=OFGSYm+JTF5nhF QepfaP5olQwJHKArRBoAzn0tFX+sO4qWMoQemQ/1D79D5Hi9WEkEU7nAmJKOpNebjbmD+dkbYGgsh Vl8rVRcauXIHhVQI2/SxcwAAwsr98DTHrCK7hqqZZRhSCOfm29/vgkuAAizjVNHyhvxoSSKJQyBnw pBHNZg2tzqlZ0RHT61ibxba0jSZOJBkLm8Qfr1b5ZYET20zezpa9S+IJ73N+eJonykZJQr7GyvOq8 hE3pUxhHtgraxL/ARFebBFq2ZrkobgXrAQTerzuwa6tepwcYSUVg1KTtT0ST5f7UJ3i8jpKe58eB0 lWVXWXUXN2DHtDft+iYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pd12h-000q5J-0w; Fri, 17 Mar 2023 03:46:11 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pczuQ-000f3u-2Z for linux-arm-kernel@lists.infradead.org; Fri, 17 Mar 2023 02:33:39 +0000 Received: by mail-wr1-x430.google.com with SMTP id y14so3190620wrq.4 for ; Thu, 16 Mar 2023 19:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679020401; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=SBufsd7TJN3UMnpjEy1Egh/dFft22er/s7/ID3KVYPo=; b=JIDokNwhtGVD8vEfHfhCtQdxRngF6jq4tx+Y9KQm+wtpj1RXOiNWWz9fDzkST1dtL7 AU0nRqjmaK7q2QGcPNENv83NH9p/Zr3y4xDhW75XsJ4JiIom+iNStFDKEZG/R/v2Apfn xz+LxG8SNkuW0FEDHyA4/JzDwG7j5j9uuYYYCpmrHRJQxTtOSHsomKFphtDYllgFLhOh ka9XMiOX/PTIhFyVXs+6bbIucoueIuz4s3cq6qMhK6HbPCQRBaEENOjxx4Bsv/UrBOHn 7RgNLZcb9ay5F9R0Scrx04Isrnp8aviivdXquaBMkG4+rriRkqgJ5PX3RRE12jiP9ftx AOSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679020401; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SBufsd7TJN3UMnpjEy1Egh/dFft22er/s7/ID3KVYPo=; b=ysTNHsxKY7XxjG5gXDLeQkPT4Xyt89Os5DfEF8ALm32pzeKpJE7XVvaOlIs8Z34zzA WCyr2wMSpRpO0WWMoIB/OFlEMjzRpw+2lQn5jrNymAp9H5EN/HW6YlszhTlT8zfl5q09 PNjS42NdeiWEz7iNfCCGxJQfU5Y3DfiT5DgaVHYzsHkVxsg6Ve8vH5F0nlbYLRRfN9E1 5dqI7lmnuuTfHiqCGWqC/SzN5ppBbErC6Hii6pJCI3A/zGbP3qaWQQpVP3CHTSSTNNHe r0buCrHSJkL0q9/GtSKHL6omEttC2/cXf2skqNZeYetcisY0k6cIAvD5bPba6ZM36fvP e97Q== X-Gm-Message-State: AO0yUKVyUQpDFxPZj1efFTg6yRFJl5cPugu49upjYqoKtpR9GMnMV/U9 gM9qo+pbAswgpZfTbg9YVEc= X-Google-Smtp-Source: AK7set81mRaNdHd1iJzkewnqPyIV7y8Tk9nfpEIfIQFfGbqJ1l6OMKIsl55+jYbv3tdZS4Sz3a4Bwg== X-Received: by 2002:adf:f0d0:0:b0:2cf:ea5d:f60a with SMTP id x16-20020adff0d0000000b002cfea5df60amr6634361wro.3.1679020399948; Thu, 16 Mar 2023 19:33:19 -0700 (PDT) Received: from localhost.localdomain (93-34-89-197.ip49.fastwebnet.it. [93.34.89.197]) by smtp.googlemail.com with ESMTPSA id z15-20020a5d44cf000000b002ce9f0e4a8fsm782313wrr.84.2023.03.16.19.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 19:33:19 -0700 (PDT) From: Christian Marangi To: Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Heiner Kallweit , Russell King , Gregory Clement , Sebastian Hesselbarth , Andy Gross , Bjorn Andersson , Konrad Dybcio , Christian Marangi , John Crispin , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Lee Jones , linux-leds@vger.kernel.org Subject: [net-next PATCH v4 00/14] net: Add basic LED support for switch/phy Date: Fri, 17 Mar 2023 03:31:11 +0100 Message-Id: <20230317023125.486-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230316_193334_837958_2965E835 X-CRM114-Status: GOOD ( 23.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a continue of [1]. It was decided to take a more gradual approach to implement LEDs support for switch and phy starting with basic support and then implementing the hw control part when we have all the prereq done. This series implements only the brightness_set() and blink_set() ops. An example of switch implementation is done with qca8k. For PHY a more generic approach is used with implementing the LED support in PHY core and with the user (in this case marvell) adding all the required functions. Currently we set the default-state as "keep" to not change the default configuration of the declared LEDs since almost every switch have a default configuration. [1] https://lore.kernel.org/lkml/20230216013230.22978-1-ansuelsmth@gmail.com/ Changes in new series v4: - Changes in Andrew patch: - net: phy: Add a binding for PHY LEDs: - Rename phy_led: led_list to list - Rename phy_device: led_list to leds - Remove phy_leds_remove() since devm_ should do what is needed - Fixup documentation for struct phy_led - Fail probe on LED errors - net: phy: phy_device: Call into the PHY driver to set LED brightness - Moved phy_led::phydev from previous patch to here since it is first used here. - net: phy: marvell: Implement led_blink_set() - Use int instead of unsigned - net: phy: marvell: Add software control of the LEDs - Use int instead of unsigned - Add depends on LED_CLASS for qca8k Kconfig - Fix Makefile for qca8k as suggested - Move qca8k_setup_led_ctrl to separate header - Move Documentation from dsa-port to ethernet-controller - Drop trailing . from Andrew patch fro consistency Changes in new series v3: - Move QCA8K_LEDS Kconfig option from tristate to bool - Use new helper led_init_default_state_get for default-state in qca8k - Drop cled_qca8k_brightness_get() as there isn't a good way to describe the mode the led is currently in - Rework qca8k_led_brightness_get() to return true only when LED is set to always ON Changes in new series v2: - Add LEDs node for rb3011 - Fix rb3011 switch node unevaluated properties while running make dtbs_check - Fix a copypaste error in qca8k-leds.c for port 4 required shift - Drop phy-handle usage for qca8k and use qca8k_port_to_phy() - Add review tag from Andrew - Add Christian Marangi SOB in each Andrew patch - Add extra description for dsa-port stressing that PHY have no access and LED are controlled by the related MAC - Add missing additionalProperties for dsa-port.yaml and ethernet-phy.yaml Changes from the old v8 series: - Drop linux,default-trigger set to netdev. - Dropped every hw control related patch and implement only blink_set and brightness_set - Add default-state to "keep" for each LED node example Andrew Lunn (6): net: phy: Add a binding for PHY LEDs net: phy: phy_device: Call into the PHY driver to set LED brightness net: phy: marvell: Add software control of the LEDs net: phy: phy_device: Call into the PHY driver to set LED blinking net: phy: marvell: Implement led_blink_set() arm: mvebu: dt: Add PHY LED support for 370-rd WAN port Christian Marangi (8): net: dsa: qca8k: move qca8k_port_to_phy() to header net: dsa: qca8k: add LEDs basic support net: dsa: qca8k: add LEDs blink_set() support dt-bindings: net: ethernet-controller: Document support for LEDs node dt-bindings: net: dsa: qca8k: add LEDs definition example arm: qcom: dt: Drop unevaluated properties in switch nodes for rb3011 arm: qcom: dt: Add Switch LED for each port for rb3011 dt-bindings: net: phy: Document support for LEDs node .../devicetree/bindings/net/dsa/qca8k.yaml | 24 ++ .../bindings/net/ethernet-controller.yaml | 21 ++ .../devicetree/bindings/net/ethernet-phy.yaml | 31 +++ arch/arm/boot/dts/armada-370-rd.dts | 14 ++ arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 124 +++++++++- drivers/net/dsa/qca/Kconfig | 8 + drivers/net/dsa/qca/Makefile | 3 + drivers/net/dsa/qca/qca8k-8xxx.c | 20 +- drivers/net/dsa/qca/qca8k-leds.c | 230 ++++++++++++++++++ drivers/net/dsa/qca/qca8k.h | 73 ++++++ drivers/net/dsa/qca/qca8k_leds.h | 16 ++ drivers/net/phy/Kconfig | 1 + drivers/net/phy/marvell.c | 81 +++++- drivers/net/phy/phy_device.c | 102 ++++++++ include/linux/phy.h | 35 +++ 15 files changed, 759 insertions(+), 24 deletions(-) create mode 100644 drivers/net/dsa/qca/qca8k-leds.c create mode 100644 drivers/net/dsa/qca/qca8k_leds.h