[PATCHv2,0/2] Improve RK3588 clocks and power domains support

Message

Sebastian Reichel April 3, 2023, 7:32 p.m. UTC

Hi,

After this patchset the power-domain support for RK3588 is basically on par
with the downstream implementation. More importantly the clock controller
change unblocks support for any IP blocks using linked clocks. The clock
controller change must be applied before the power-domain change to avoid
accessing unclocked registers.

Changes since PATCHv1:
 * https://lore.kernel.org/all/[e-mail]/
 * Replace dsb(sy) with wmb() to fix COMPILE_TEST build on !arm64; direct replacement
   would be mb(), but write memory barrier should be enough here as far as I can tell
 * Added Tested-by from Vincent Legoll

-- Sebastian

Boris Brezillon (1):
  soc: rockchip: power-domain: add rk3588 mem module support

Sebastian Reichel (1):
  clk: rockchip: rk3588: make gate linked clocks ignore unused

 drivers/clk/rockchip/clk-rk3588.c |  42 +++++---
 drivers/soc/rockchip/pm_domains.c | 160 +++++++++++++++++++++++-------
 2 files changed, 151 insertions(+), 51 deletions(-)

Comments

Heiko Stuebner April 17, 2023, 11:18 p.m. UTC | #1

On Mon, 3 Apr 2023 21:32:48 +0200, Sebastian Reichel wrote:
> After this patchset the power-domain support for RK3588 is basically on par
> with the downstream implementation. More importantly the clock controller
> change unblocks support for any IP blocks using linked clocks. The clock
> controller change must be applied before the power-domain change to avoid
> accessing unclocked registers.
> 
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/[e-mail]/
>  * Replace dsb(sy) with wmb() to fix COMPILE_TEST build on !arm64; direct replacement
>    would be mb(), but write memory barrier should be enough here as far as I can tell
>  * Added Tested-by from Vincent Legoll
> 
> [...]

Applied, thanks!

[1/2] clk: rockchip: rk3588: make gate linked clocks ignore unused
      commit: 64042c28c3bb6729df8e2fda89bc7ebbe3790907

Best regards,

Heiko Stuebner April 21, 2023, 12:56 p.m. UTC | #2

On Mon, 3 Apr 2023 21:32:48 +0200, Sebastian Reichel wrote:
> After this patchset the power-domain support for RK3588 is basically on par
> with the downstream implementation. More importantly the clock controller
> change unblocks support for any IP blocks using linked clocks. The clock
> controller change must be applied before the power-domain change to avoid
> accessing unclocked registers.
> 
> Changes since PATCHv1:
>  * https://lore.kernel.org/all/[e-mail]/
>  * Replace dsb(sy) with wmb() to fix COMPILE_TEST build on !arm64; direct replacement
>    would be mb(), but write memory barrier should be enough here as far as I can tell
>  * Added Tested-by from Vincent Legoll
> 
> [...]

Applied, thanks!

[2/2] soc: rockchip: power-domain: add rk3588 mem module support
      commit: 632a6b6593d5bfe9932490f8483195bbf50cbbb7

For 6.5, so this will get a rebase after 6.4-rc1.

Best regards,