| Message ID | 20230414112843.1358067-1-eblanc@baylibre.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: ti: k3-j7200-som-p0: Add TP6594 family PMICs | expand |
On 14/04/2023 13:28, Esteban Blanc wrote: > TPS6594 is a Power Management IC which provides regulators and others > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can > communicate through the I2C or SPI interfaces. > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives. > > This should be applied on top of other patch series: > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/ > For core MFD driver > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/ > For regulator driver Why? DTS cannot be merged with drivers, so if you insist on such dependency then: 1. Your patchset is broken, 2. I actually does not understand why, 3. NAK - don't merge DTS into driver branches. You probably are misunderstanding branches and dependencies. Best regards, Krzysztof
On 13:28-20230414, Esteban Blanc wrote: > TPS6594 is a Power Management IC which provides regulators and others > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can > communicate through the I2C or SPI interfaces. > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives. > > This should be applied on top of other patch series: > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/ > For core MFD driver > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/ > For regulator driver > https://lore.kernel.org/lkml/20230330030046.qr5dnft6klejkxkp@ungreased/ has anything changed?
On Fri Apr 14, 2023 at 8:05 PM CEST, Nishanth Menon wrote: > On 13:28-20230414, Esteban Blanc wrote: > > TPS6594 is a Power Management IC which provides regulators and others > > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and > > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can > > communicate through the I2C or SPI interfaces. > > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives. > > > > This should be applied on top of other patch series: > > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/ > > For core MFD driver > > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/ > > For regulator driver > > > > https://lore.kernel.org/lkml/20230330030046.qr5dnft6klejkxkp@ungreased/ > > has anything changed? Yes: - Harmonize regulators names across the different boards - Adjust AVS voltage range - Remove some outdated comments - Add PMICs to J784S4 board - Compatible string modified to match dt-bindings - Add gpio-controller and gpio-cells properties I missed a few of theses on the cover letter, sorry about that. Best regards,
On Fri Apr 14, 2023 at 1:36 PM CEST, Krzysztof Kozlowski wrote: > On 14/04/2023 13:28, Esteban Blanc wrote: > > TPS6594 is a Power Management IC which provides regulators and others > > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and > > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can > > communicate through the I2C or SPI interfaces. > > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives. > > > > This should be applied on top of other patch series: > > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/ > > For core MFD driver > > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/ > > For regulator driver > > Why? DTS cannot be merged with drivers, so if you insist on such > dependency then: > 1. Your patchset is broken, > 2. I actually does not understand why, > 3. NAK - don't merge DTS into driver branches. > > You probably are misunderstanding branches and dependencies. There is no dependency indeed. We thought that dt-bindings patch at least had to be applied before this DT series even if it is not a 'dependency', the other link was a mistake. I will remove these misleading links in next cover-letter. Thanks for your time. Best regards,
On 12:01-20230417, Esteban Blanc wrote: > On Fri Apr 14, 2023 at 8:05 PM CEST, Nishanth Menon wrote: > > On 13:28-20230414, Esteban Blanc wrote: > > > TPS6594 is a Power Management IC which provides regulators and others > > > features like GPIOs, RTC, watchdog, ESMs (Error Signal Monitor), and > > > PFSM (Pre-configurable Finite State Machine). The SoC and the PMIC can > > > communicate through the I2C or SPI interfaces. > > > TPS6594 is the super-set device while TPS6593 and LP8764 are derivatives. > > > > > > This should be applied on top of other patch series: > > > - https://lore.kernel.org/all/20230406075622.8990-1-jpanis@baylibre.com/ > > > For core MFD driver > > > - https://lore.kernel.org/lkml/20230414101217.1342891-1-eblanc@baylibre.com/ > > > For regulator driver > > > > > > > https://lore.kernel.org/lkml/20230330030046.qr5dnft6klejkxkp@ungreased/ > > > > has anything changed? > > Yes: > - Harmonize regulators names across the different boards > - Adjust AVS voltage range > - Remove some outdated comments > - Add PMICs to J784S4 board > - Compatible string modified to match dt-bindings > - Add gpio-controller and gpio-cells properties > > I missed a few of theses on the cover letter, sorry about that. The bindings and drivers need to reach kernel.org master branch first, if they are in by rc1, then the dts patches can be picked in.