From patchwork Thu Apr 20 12:29:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ivan T. Ivanov" X-Patchwork-Id: 13218703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 810D1C77B73 for ; Thu, 20 Apr 2023 12:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=zzDnMhFMIW6/ckNyiQkkGn+9uwsG+vY/vcB+glC9T5o=; b=gqJcrkCOvtTL9L x+locsoYRGq2DzGyRl/AsPu0gzdd9C1Q1mp09MklczOrEUm+rwFvw9Wdzyt0hwm2z/YcDYLUWWr6Q DPSbY4yzZCf5JCrxMK0+nlhbB/QBnFGju/xmVboeTC+2JvQFTvIT4n0M3dgtR7Kb3aKkCWUovK7zY SUlQkfVv6ivx3ZvQS8B2iUhhRTRDsd7Jyn0Es9vTLNZHrqQNHzuPqsLeUOSKgp59Hefu2txhsORzB bvOMe8Y5lf2jQEfD/B/3crAoJCXE3JwfE4HCIKNDlzAVjnjI8kpmmVRxkZcSX9s6/eMRcji4mcExA 4MQhL3ih/94xRaFzDhow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppTQG-0083lH-0x; Thu, 20 Apr 2023 12:30:00 +0000 Received: from smtp-out1.suse.de ([195.135.220.28]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppTQ3-0083gL-14; Thu, 20 Apr 2023 12:29:48 +0000 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4DA4821996; Thu, 20 Apr 2023 12:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1681993784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NqNQ26VQFbO7fto7VKWucLDm7RMWmzlVr9Dn+FC226M=; b=g7FWjH9oCaI7KcbbKeMx6+WwOlbFCAC7RCkVoWjhnG31ubCcUPtdpf0QdwBG7vPiKIUXKd 6wfRGvejpasv6DzOJhnkg5kkgd5qdBJIcFix+BRUgz+mBRaOYEhNfxnfaCxp6fXX8BYY0U s+fKcDCfaArHtz/WEXST4YE5gojbIA4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1681993784; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=NqNQ26VQFbO7fto7VKWucLDm7RMWmzlVr9Dn+FC226M=; b=VOPg+tN2APtYLaMnxx2us1FtjaZEoXLO9AGK6FuJnqtbokwbLU3ldnTips2nNnvFeJdJWb ibITeEi8GhrMVbAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 337F51333C; Thu, 20 Apr 2023 12:29:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ICFeDDgwQWSueQAAMHmgww (envelope-from ); Thu, 20 Apr 2023 12:29:44 +0000 From: "Ivan T. Ivanov" To: Srinivas Kandagatla , Rob Herring , Krzysztof Kozlowski Cc: Nicolas Saenz Julienne , Florian Fainelli , Stefan Wahren , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, "Ivan T. Ivanov" Subject: [PATCH v3 0/3] Add nvmem node for BCM2711 bootloader public key Date: Thu, 20 Apr 2023 15:29:21 +0300 Message-Id: <20230420122924.37997-1-iivanov@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230420_052947_515346_B188247F X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While debugging kernel stack trace from bug report[1], on openSUSE Tumbleweed, which uses vendor devicetree, I have found that rmem driver lack support for multiple rmem devices. Following patches add new devicetree node, its documentation and support for it in rmem driver. [1] https://bugzilla.suse.com/show_bug.cgi?id=1206846 Reviewed-by: Stefan Wahren --- [ 9.831285] sysfs: cannot create duplicate filename '/bus/nvmem/devices/rmem0' [ 9.831304] CPU: 3 PID: 467 Comm: (udev-worker) Not tainted 6.2.9-1-default #1 openSUSE Tumbleweed a4aeb3a90c0f23041a8a7944b12739b07585f009 [ 9.831326] Hardware name: raspberrypi rpi/rpi, BIOS 2023.01 01/01/2023 [ 9.831335] Call trace: [ 9.831343] dump_backtrace+0xe4/0x140 [ 9.831366] show_stack+0x20/0x30 [ 9.831379] dump_stack_lvl+0x64/0x80 [ 9.831398] dump_stack+0x18/0x34 [ 9.831410] sysfs_warn_dup+0x6c/0x90 [ 9.831424] sysfs_do_create_link_sd+0xf8/0x100 [ 9.831437] sysfs_create_link+0x28/0x50 [ 9.831449] bus_add_device+0x70/0x190 [ 9.831468] device_add+0x3e8/0x84c [ 9.831481] nvmem_register+0x85c/0x9f0 [ 9.831500] devm_nvmem_register+0x24/0x70 [ 9.831517] rmem_probe+0xa0/0xf4 [nvmem_rmem 649243b01e5e28ee94e4dd53bd13b6ececa836f8] [ 9.831555] platform_probe+0x70/0xd0 [ 9.831566] really_probe+0xc8/0x3e4 [ 9.831582] __driver_probe_device+0x84/0x190 [ 9.831598] driver_probe_device+0x44/0x11c [ 9.831613] __driver_attach+0xf8/0x200 [ 9.831629] bus_for_each_dev+0x78/0xd0 [ 9.831643] driver_attach+0x2c/0x40 [ 9.831657] bus_add_driver+0x188/0x250 [ 9.831672] driver_register+0x80/0x13c [ 9.831688] __platform_driver_register+0x30/0x40 [ 9.831699] rmem_driver_init+0x28/0x1000 [nvmem_rmem 649243b01e5e28ee94e4dd53bd13b6ececa836f8] [ 9.831727] do_one_initcall+0x48/0x2bc [ 9.831740] do_init_module+0x50/0x1f0 [ 9.831753] load_module+0x1e54/0x2250 [ 9.831763] __do_sys_init_module+0x2ac/0x2f0 [ 9.831774] __arm64_sys_init_module+0x24/0x30 [ 9.831785] invoke_syscall+0x78/0x100 [ 9.831803] el0_svc_common.constprop.0+0x15c/0x180 [ 9.831820] do_el0_svc+0x40/0xb0 [ 9.831836] el0_svc+0x34/0x134 [ 9.831850] el0t_64_sync_handler+0x114/0x120 [ 9.831865] el0t_64_sync+0x1a4/0x1a8 [ 9.831956] rmem: probe of 3ef62ce0.nvram failed with error -17 -- Changes since v2 https://lore.kernel.org/all/20230413085206.149730-1-iivanov@suse.de/ - Add devicetree bindings documentation patch -- Changes since v1 https://lore.kernel.org/all/20230411135035.106725-1-iivanov@suse.de/ I dig into Raspberry Github repository and found original patches from Tim and Phil which add new region and fix rmem driver. - Use NVMEM_DEVID_AUTO instead making region name unique from the driver itself. - Add devicetree node for BCM2711 bootloader public key. -- Ivan T. Ivanov (1): dt-bindings: nvmem: rmem: Add raspberrypi,bootloader-public-key Phil Elwell (1): nvmem: rmem: Use NVMEM_DEVID_AUTO Tim Gover (1): ARM: dts: Add nvmem node for BCM2711 bootloader public key Documentation/devicetree/bindings/nvmem/rmem.yaml | 1 + arch/arm/boot/dts/bcm2711-rpi.dtsi | 14 ++++++++++++++ drivers/nvmem/rmem.c | 1 + 3 files changed, 16 insertions(+)