| Message ID | 20230609083009.2822259-1-wenst@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | regulator: mt6358: Remove bogus regulators and improvements | expand |
On Fri, 09 Jun 2023 16:29:57 +0800, Chen-Yu Tsai wrote: > This series is a cleanup and improvement of the MT6358 regulator driver. > Various discrepancies were found while preparing to upstream MT8186 > device trees, which utilize the MT6366 PMIC, that is also covered by > this driver. > > Patches 1~8 should go through the regulator tree, and patch 9 through > the soc tree. This series (patches 7 and 8) depends on "regulator: Use > bitfield values for range selectors" [1] I sent out earlier. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/9] regulator: dt-bindings: mt6358: Merge ldo_vcn33_* regulators commit: a74d4c577c60b27fc57ea734ef8275921ae8dcb2 [2/9] regulator: dt-bindings: mt6358: Drop *_sshub regulators commit: 82f305b18eb0505444eab8ac86bfa134b67cb38e [3/9] regulator: mt6358: Merge VCN33_* regulators commit: 65bae54e08c109ddbbf121bb00058cf3b3fb7b8e [4/9] regulator: mt6358: Drop *_SSHUB regulators commit: 04ba665248ed91576d326041108e5fc2ec2254eb [5/9] regulator: mt6358: Const-ify mt6358_regulator_info data structures commit: 1ff35e66cae53f7090a671afddaee45d4ccd9396 [6/9] regulator: mt6358: Use linear voltage helpers for single range regulators commit: ea861df772fd8cca715d43f62fe13c09c975f7a2 [7/9] regulator: mt6358: Add output voltage fine tuning to fixed regulators (no commit info) [8/9] regulator: mt6358: Add output voltage fine tuning to variable LDOs (no commit info) All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, This series is a cleanup and improvement of the MT6358 regulator driver. Various discrepancies were found while preparing to upstream MT8186 device trees, which utilize the MT6366 PMIC, that is also covered by this driver. Patches 1~8 should go through the regulator tree, and patch 9 through the soc tree. This series (patches 7 and 8) depends on "regulator: Use bitfield values for range selectors" [1] I sent out earlier. This series can be seen as three parts: Part 1 - Fixing bogus regulators (patches 1~4 and 9) There are some regulators listed in the bindings and driver that have no corresponding pin on the actual hardware. MediaTek says these are a hardware construct for shared control of the same regulator in the VCN33 case and an alternative control scheme for low power suspend. In the VCN33 case, there's only one actual regulator, so we merge the two and rename them to match the hardware pin. No existing devices use these AFAICT, so this should be safe to change. In the *_SSHUB case, the two extra regulators refer to alternative configuration registers of the same regulators. They are intended for the SoC's low power mode companion processor to use, not the main processor or OS. It should be left to the implementation to choose which set of registers to actually control. Part 2 - Code cleanup (patches 5 and 6) Various tables in the regulator driver were not constant, even though they are just lookup tables. With some reworking of the code, they are made constant. Also, some regulators that have a single linear range were using linear range helpers. This is more complicated than just declaring the range and step directly in the description. This is simplified to use the latter approach. Part 3 - Output voltage fine tuning support (patches 7 and 8) Many of the LDOs on these PMIC support an extra level of output voltage fine tuning. Most default to no offset, but a couple have a non-zero offset by default. Previously this was unaccounted for in the driver and device tree constraints. On the outputs with non-zero offset, this ends up becoming a discrepancy between the device tree and actual hardware. These two patches adds support for this second level of tuning, modeled as bunch of linear ranges. While it's unlikely we need this level of control, it's nice to be able to read back the accurate hardware settings. Please have a look. After this series is done I'll send out patches for the MT6366 PMIC, which is what started this. That will also include updated YAML bindings for MT6366. I think we can merge MT6358 bindings into them afterwards. Thanks ChenYu [1] https://lore.kernel.org/linux-arm-kernel/20230609075032.2804554-1-wenst@chromium.org/ Chen-Yu Tsai (9): regulator: dt-bindings: mt6358: Merge ldo_vcn33_* regulators regulator: dt-bindings: mt6358: Drop *_sshub regulators regulator: mt6358: Merge VCN33_* regulators regulator: mt6358: Drop *_SSHUB regulators regulator: mt6358: Const-ify mt6358_regulator_info data structures regulator: mt6358: Use linear voltage helpers for single range regulators regulator: mt6358: Add output voltage fine tuning to fixed regulators regulator: mt6358: Add output voltage fine tuning to variable LDOs arm64: dts: mediatek: mt6358: Merge ldo_vcn33_* regulators .../bindings/regulator/mt6358-regulator.txt | 34 +- arch/arm64/boot/dts/mediatek/mt6358.dtsi | 11 +- drivers/regulator/mt6358-regulator.c | 499 ++++++++---------- include/linux/regulator/mt6358-regulator.h | 10 +- 4 files changed, 234 insertions(+), 320 deletions(-)