From patchwork Wed Jun 21 10:22:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason-JH.Lin" X-Patchwork-Id: 13287136 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CB37EB64D8 for ; Wed, 21 Jun 2023 10:33:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=hMvi3n7R1a65MuxRrr0g9YF60bvU0wV91k8sdWempO8=; b=GndpHvyrZ66ngh tEjXd4C8glCDTQvH/3MtA5ryXpLuQmiA4sh3QSG6mxfHpFDVaXlU4NKkbojQkrCD+pENmOGC/C4E5 u31A7hRuw3rERfjRuCnPW7TPQdWCjNfSwHHy2IVzROX/0w+gPFbknoBx9uiWgKcoT/HkazhjfJ5MN DnzOc2aunJehIcAG3lIt1Tw5rZqugdjHFok5apiK8Wq59RHh2B0P4fJ7aBghEtKH0ogsVb8DinlQa ZLoT0wuxjBnFhE9pVe7cm4giUAbIFo7muFepkAhgTJyf38onTL43t9udsL7PmPNBGV3RPDJdYPoL5 xnm4oSl4LAMCFvnKQUDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBv96-00E3xX-0P; Wed, 21 Jun 2023 10:33:04 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBv92-00E3v8-2L; Wed, 21 Jun 2023 10:33:01 +0000 X-UUID: f975c084101e11ee912e1518a6540028-20230621 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=EggFaisyYLlZMGKDdteaS6RHQn0kmzvukFhtmqjl8zM=; b=fkcpt4dMTOC5ixSXKk1wgqDep85GFjchHwuX5OrHVODaNFu7T8NUYIzYE9/LhAragdrMvVVWUzXpjRWcGf82oQJjcw5Vn0lXpmpqZ/kfaFBdPeTJy4B9EN9VlYIQs+v/14nPlNszN8oxAYaiUn+YEerpq2Ct65fiYddCk4iDGsY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:ea7814f2-550d-4822-bc38-a26cda1f319a,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:01c9525,CLOUDID:1eda553f-7aa7-41f3-a6bd-0433bee822f3,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: f975c084101e11ee912e1518a6540028-20230621 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1943096492; Wed, 21 Jun 2023 03:32:51 -0700 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 21 Jun 2023 18:22:48 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 21 Jun 2023 18:22:48 +0800 From: Jason-JH.Lin To: Chun-Kuang Hu , AngeloGioacchino Del Regno , Alexandre Mergnat CC: Matthias Brugger , Jason-ch Chen , Johnson Wang , "Jason-JH . Lin" , Singo Chang , Nancy Lin , Shawn Sung , , , , , Subject: [PATCH v3 0/4] Fix mediatek-drm coverity issues Date: Wed, 21 Jun 2023 18:22:43 +0800 Message-ID: <20230621102247.10116-1-jason-jh.lin@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_033300_765973_C57063D5 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add this patch series to fix some mediatek-drm coverity issues. Change in v3: 1. swap Fixes and Signed tag. 2. change cast (__u64) to '=' then ' *='. Change in v2: 1. remove kfree(pkt) in mtk_drm_crtc_create_pkt(). 2. change the statement of cnt reach to MAX_CRTC. 3. drop the mtk_gem_obj initialized patch. 4. change casting from unsined long to __u64. 5. add 'int offset' for multiplier calculation. 6. drop the unrelavaent modification in dereference null check patch. Jason-JH.Lin (4): drm/mediatek: Remove freeing not dynamic allocated memory drm/mediatek: Add cnt checking for coverity issue drm/mediatek: Add casting before assign drm/mediatek: Fix dereference before null check drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 7 ++---- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 ++++- drivers/gpu/drm/mediatek/mtk_drm_gem.c | 3 ++- drivers/gpu/drm/mediatek/mtk_drm_plane.c | 28 ++++++++++++------------ 4 files changed, 22 insertions(+), 21 deletions(-)