From patchwork Fri Jun 23 14:40:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13290802 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 436C5C0015E for ; Fri, 23 Jun 2023 15:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:Message-Id:Date:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=1VlsfSnetycJytXrq6tPROW6rx/A18csDNVo+kY1bFU=; b=I36 z9ZHtJvYItF8gui0g74ECRTXnYn3qRtOyvaQoHIazUkDNBns677KfUxW6aIveuak356HaP7qw9nN9 DSY9LEdJV8T7rmcItdmYNP6mAurpfKCorAj8kIW+NdjjDQtpToKJPUgmHIiN4IIuVI1FPNhp4VBNw 1RyHBYlwmTO3CtgFZl6j6eW0KGvNZe0DuPNiZ3qgf5A4V3wxoRg30c0OgGV+shwuH807cprJauXnk r36HF/rH2922UD4rf3UtT7PojTX0meO3uCMY1j13LjxZS+8YBk4nXW7KaqXa1wEYTdUS2/hUcq23s 0Cx8qX6UqHvfvGVI3dK3vCtT2c/bsug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qCiyq-003yti-39; Fri, 23 Jun 2023 15:45:48 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qChyI-003oIB-20 for linux-arm-kernel@lists.infradead.org; Fri, 23 Jun 2023 14:41:12 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-76300f4d7eeso54749185a.1 for ; Fri, 23 Jun 2023 07:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1687531266; x=1690123266; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1pUe2zkp/45DDH42H1s1tCQDytOnXmP2eY7aPcbSF1w=; b=e7oIK+tgiA1qubKXAMyCe24QHAYpbH2qdW6hSzJfZ7Y7PKDgICy1OJxnVOn4SnIXXi Uxb8BKyLELrjqVanPhOyD40zM/s6K68ugJq1Bq1iEQ3lX4FRysb/rXoDn2hzc4oGUkYE BUoMzj45dQaKUNQiIrAztVK/RSMSP4cZBM8aM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687531266; x=1690123266; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pUe2zkp/45DDH42H1s1tCQDytOnXmP2eY7aPcbSF1w=; b=K0Ni0/+dbD1qWjJAgLSJKLA31GSmQBgjld03s39WSGZhNYhXuxAvOwP6OaAgl69P76 KWbnGwQHloiyVZkhjAh2ZAFQtY8HmQM4XxhJXmPuOCW0jOegQnWPBN6y32/0jAqMzcz5 /lMvl8+JrCB4Tq/x9Tnk7Fx2glnLxr5h9xdzBPI30npCf3a7ZLyUw8R1IREmDBvdLR6R HuHgDDDtJm3GMQq+4zNVzNG0acmJdcLGAZAtSZFoXLfzLDrArxNN9Uz0yr+0ZxL84BOs Uz/RlXUOlCwUT5cRIvxLDo6K17gJeh2jd5bfLTulqEIpguGGF08pfpN248/5lVejd5jc I7Ew== X-Gm-Message-State: AC+VfDweix4bafLHiLIfYFg+evH785dbiteRy6v1ehzWDmERc493Uw32 Qrgd6DK/1j7CsPkEM7RYqmew4A== X-Google-Smtp-Source: ACHHUZ4IhPOL36VKR59tEJb2o3jA3l9pE226IcXVgSMSrQ3gKkdN8Hy1S9e4HdB1zSqef7hIlazxqw== X-Received: by 2002:a05:620a:2b47:b0:75b:23a1:40f with SMTP id dp7-20020a05620a2b4700b0075b23a1040fmr21782878qkb.37.1687531266514; Fri, 23 Jun 2023 07:41:06 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id i18-20020a05620a145200b007625382f4ccsm4564613qkl.69.2023.06.23.07.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 07:41:06 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , =?utf-8?q?Krzyszto?= =?utf-8?q?f_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi , Rob Herring Subject: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Date: Fri, 23 Jun 2023 10:40:53 -0400 Message-Id: <20230623144100.34196-1-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230623_074110_692505_41D76153 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org v6 -- No code has been changed. -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) -- Changed sign-off and author email address for all commits. This was due to a change in Broadcom's upstreaming policy. v5 -- Remove DT property "brcm,completion-timeout-us" from "DT bindings" commit. Although this error may be reported as a completion timeout, its cause was traced to an internal bus timeout which may occur even when there is no PCIe access being processed. We set a timeout of four seconds only if we are operating in "L1SS CLKREQ#" mode. -- Correct CEM 2.0 reference provided by HW engineer, s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) -- Add newline to dev_info() string (Stefan) -- Change variable rval to unsigned (Stefan) -- s/implementaion/implementation/ (Bjorn) -- s/superpowersave/powersupersave/ (Bjorn) -- Slightly modify message on "PERST#" commit. -- Rebase to torvalds master v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC driver probe() time. This is done in Raspian Linux and its absence may be the cause of a failing test case. -- New commit that removes stale comment. v3 -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) -- Put binding names in DT commit Subject (Bjorn) -- Add a verb to a commit's subject line (Bjorn) -- s/accomodat(\w+)/accommodat$1/g (Bjorn) -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) v2 -- Changed binding property 'brcm,completion-timeout-msec' to 'brcm,completion-timeout-us'. (StefanW for standard suffix). -- Warn when clamping timeout value, and include clamped region in message. Also add min and max in YAML. (StefanW) -- Qualify description of "brcm,completion-timeout-us" so that it refers to PCIe transactions. (StefanW) -- Remvove mention of Linux specifics in binding description. (StefanW) -- s/clkreq#/CLKREQ#/g (Bjorn) -- Refactor completion-timeout-us code to compare max and min to value given by the property (as opposed to the computed value). v1 -- The current driver assumes the downstream devices can provide CLKREQ# for ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle L1SS-capable devices. -- The Raspian Linux folks have already been using a PCIe RC property "brcm,enable-l1ss". These commits use the same property, in a backward-compatible manner, and the implementaion adds more detail and also automatically identifies devices w/o a clkreq# signal, i.e. most devices plugged into an RPi CM4 IO board. Jim Quinlan (5): dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device PCI: brcmstb: Set higher value for internal bus timeout PCI: brcmstb: Assert PERST# on BCM2711 PCI: brcmstb: Remove stale comment .../bindings/pci/brcm,stb-pcie.yaml | 9 ++ drivers/pci/controller/pcie-brcmstb.c | 91 ++++++++++++++++--- 2 files changed, 89 insertions(+), 11 deletions(-) base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb