From patchwork Fri Jul 7 05:26:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tinghan Shen X-Patchwork-Id: 13304443 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64512EB64DA for ; Fri, 7 Jul 2023 05:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Y8uPheZXwSWawf8ujdNFG98MV9LQkrh1EPOUUGBxdyU=; b=NtwF8WqPXUqpH7 qArOQMIjmPkwOx3Pe0tQ/CJZVV3NuGTJKvumIHi6StBgmhL/YIkzS1q1P71TrPYxNamrdU0bWKWoY 2VUrr81pSfAnlRe9j5I/EtVmfWaZcsqT6yrcU5R7OgvXklZrc/JqsdJiTg6nJZBU3rprn6SN7Qj6I A6/kSSqpmNQ6rcKVlbOpUrz5gMhzPEdYpOtApMFpiHzTucSwLAqsxy39ubgKKKPmc7MOz/87KMO5j G1ERlX771FfnhoyHQ1k/Grl9iooXkhUdYpbppW9qN7VfE9FWxoEdupdidDDthd+3q7Npae8g/TwW8 vgHyJNZWYdnN4tAiPO3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHe9G-003dlJ-0d; Fri, 07 Jul 2023 05:36:54 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHe9C-003dki-2y; Fri, 07 Jul 2023 05:36:52 +0000 X-UUID: 4457b5ec1c8811ee912e1518a6540028-20230706 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=S908HPXLMOOveANHXI/Onpb6be3Nr0vIEIrUdob0Jo4=; b=EkBwjGdv7QP5yEN9KhrszWDY/lcAQHkgeah7oELkXCtEhIGR6dkf+m0v8+cPSWtLUnaLRaESIioq7vDi/E1mS1+zMzEwlOVtaItKgBgmSoD1AuWl7YIKJ5Z4+fK0Y/uX+oxMJnk/DSKc0oD8y8fb75uzscIyZ7HcKhBTn/3xqv4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.27,REQID:5db02352-a14a-4352-ac8c-8efd0aa56183,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:01c9525,CLOUDID:400cbada-b4fa-43c8-9c3e-0d3fabd03ec0,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 4457b5ec1c8811ee912e1518a6540028-20230706 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1085775472; Thu, 06 Jul 2023 22:36:48 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 7 Jul 2023 13:26:14 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 7 Jul 2023 13:26:14 +0800 From: Tinghan Shen To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen CC: , , , , , Subject: [PATCH v14 00/12] Add support for MT8195 SCP 2nd core Date: Fri, 7 Jul 2023 13:26:00 +0800 Message-ID: <20230707052612.27521-1-tinghan.shen@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_223650_972490_A965BECF X-CRM114-Status: GOOD ( 16.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The mediatek remoteproc driver currently only allows bringing up a single core SCP, e.g. MT8183. It also only bringing up the 1st core in SoCs with a dual-core SCP, e.g. MT8195. This series support to bring-up the 2nd core of the dual-core SCP. v13 -> v14: 1. add review tag to patchset 1,6 2. exchange the order of sram power on and reset assert in mt8195_scp_c1_before_load at patchset 2 3. Use ERR_CAST in patchset 5 4. Re-write patchset 7 to remove dependency between core 0 and core 1 5. Add patch set 10 to report watchdot timeout to all cores v12 -> v13: 1. replace subdevice with new mediatek scp operations in patchset 7 2. add review tag to patchset 3 3. modify mediatek,scp phandle name of video-codec@18000000 at patchset 11 v11 -> v12: 1. add scp_add_single/multi_core() to patchset 6 2. remove unused comment in patchset 6 3. rename list name from mtk_scp_cluster to mtk_scp_list 4. rewrite the multi-core probe flow 5. disable rproc->autoboot and boot rproc by request_firmware_nowait at patchset 7 6. remove patchset 7 review tag v10 -> v11: 1. rewrite patchset 5 to probe single-core SCP with the cluster list 2. Also in patchset 5, move the pointer of mtk_scp object from the platform data property to the driver data property 3. move the appearance of mtk_scp cluster property to patcheset 7 v9 -> v10: 1. move the global mtk_scp list into the platform device driver data structure 2. remove an unnecessary if() condition v8 -> v9: 1. initialize l1tcm_size/l1tcm_phys at patchset 05/11 2. rewrite patchset 06/11 to unify the flow and remove hacks v7 -> v8: 1. update the node name of mt8192 asurada SCP rpmsg subnode 2. squash register definitions into driver patches 3. initialize local variables on the declaration at patch v8 06/11 v6 -> v7: 1. merge the mtk_scp_cluster struct into the mtk_scp structure at the "Probe multi-core SCP" patch v5 -> v6: 1. move the mtk_scp_of_regs structure from mtk_common.h to mtk_scp.c 2. rename the SCP core 0 label from 'scp' to 'scp_c0' v4 -> v5: 1. move resource release actions to the platform driver remove operation 2. fix dual-core watchdog handling v3 -> v4: 1. change the representation of dual-core SCP in dts file and update SCP yaml 2. rewrite SCP driver to reflect the change of dts node 3. drop 'remove redundant call of rproc_boot for SCP' in v3 for further investigation v2 -> v3: 1. change the representation of dual-core SCP in dts file and update SCP yaml 2. rewrite SCP driver to reflect the change of dts node 3. add SCP core 1 node to mt8195.dtsi 4. remove redundant call of rproc_boot for SCP 5. refine IPI error message v1 -> v2: 1. update dt-binding property description 2. remove kconfig for scp dual driver 3. merge mtk_scp_dual.c and mtk_scp_subdev.c to mtk_scp.c Tinghan Shen (12): dt-bindings: remoteproc: mediatek: Improve the rpmsg subnode definition arm64: dts: mediatek: Update the node name of SCP rpmsg subnode dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP remoteproc: mediatek: Add MT8195 SCP core 1 operations remoteproc: mediatek: Introduce cluster on single-core SCP remoteproc: mediatek: Probe multi-core SCP remoteproc: mediatek: Remove dependency of MT8195 SCP L2TCM power control on dual-core SCP remoteproc: mediatek: Setup MT8195 SCP core 1 SRAM offset remoteproc: mediatek: Handle MT8195 SCP core 1 watchdog timeout remoteproc: mediatek: Report watchdog crash to all cores remoteproc: mediatek: Refine ipi handler error message arm64: dts: mediatek: mt8195: Add SCP 2nd core .../bindings/remoteproc/mtk,scp.yaml | 176 ++++++- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +- .../boot/dts/mediatek/mt8192-asurada.dtsi | 2 +- .../boot/dts/mediatek/mt8195-cherry.dtsi | 6 +- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 34 +- drivers/remoteproc/mtk_common.h | 24 + drivers/remoteproc/mtk_scp.c | 458 +++++++++++++++--- 7 files changed, 610 insertions(+), 92 deletions(-)