mbox series

[v2,0/9] Use dev_err_probe in i2c probe function

Message ID 20230802095737.3957587-1-liaochang1@huawei.com (mailing list archive)
Headers show
Series Use dev_err_probe in i2c probe function | expand

Message

Liao, Chang Aug. 2, 2023, 9:57 a.m. UTC 
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.

v2:
1. Convert all dev_err() in lpi2c_imx_probe(), synquacer_i2c_probe(),
   mlxbf_i2c_probe() to dev_err_probe().
2. Add Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
3. Add Reviewed-by: Yicong Yang <yangyicong@hisilicon.com>
4. Add Reviewed-by: Andi Shyti <andi.shyti@kernel.com>

Liao Chang (9):
  i2c: bcm2835: Use dev_err_probe in probe function
  i2c: mlxbf: Use dev_err_probe in probe function
  i2c: xlp9xx: Use dev_err_probe in probe function
  i2c: hisi: Use dev_err_probe in probe function
  i2c: qcom-cci: Use dev_err_probe in probe function
  i2c: pxa: Use dev_err_probe in probe function
  i2c: dln2: Use dev_err_probe in probe function
  i2c: imx-lpi2c: Use dev_err_probe in probe function
  i2c: synquacer: Use dev_err_probe in probe function

 drivers/i2c/busses/i2c-bcm2835.c   | 14 ++++-----
 drivers/i2c/busses/i2c-dln2.c      |  6 ++--
 drivers/i2c/busses/i2c-hisi.c      | 12 +++----
 drivers/i2c/busses/i2c-imx-lpi2c.c | 12 +++----
 drivers/i2c/busses/i2c-mlxbf.c     | 50 ++++++++++--------------------
 drivers/i2c/busses/i2c-pxa.c       |  7 ++---
 drivers/i2c/busses/i2c-qcom-cci.c  |  6 ++--
 drivers/i2c/busses/i2c-synquacer.c | 19 ++++--------
 drivers/i2c/busses/i2c-xlp9xx.c    |  6 ++--
 9 files changed, 46 insertions(+), 86 deletions(-)

Comments

Andi Shyti Aug. 4, 2023, 10:19 p.m. UTC | #1 
Hi Liao,

On Wed, Aug 02, 2023 at 05:57:28PM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.

first of all thanks for this cleanup which is very much
appreciated!

I need to ask you to add the version to all the patches, not just
patch 0/9. It's trivial if you do "git format-patch -v 2...".

Thanks,
Andi
Liao, Chang Aug. 7, 2023, 2:13 a.m. UTC | #2 
在 2023/8/5 6:19, Andi Shyti 写道:
> Hi Liao,
> 
> On Wed, Aug 02, 2023 at 05:57:28PM +0800, Liao Chang wrote:
>> Use the dev_err_probe function instead of dev_err in the probe function
>> so that the printed messge includes the return value and also handles
>> -EPROBE_DEFER nicely.
> 
> first of all thanks for this cleanup which is very much
> appreciated!
> 
> I need to ask you to add the version to all the patches, not just
> patch 0/9. It's trivial if you do "git format-patch -v 2...".

Hi Andi,

Trully sorry for the misleading, I will add the version to all the patches
and send them out in next revision.

Thanks for taking the time to review these patches.

> 
> Thanks,
> Andi