mbox series

[v3,0/5] Add R5F and C7x DSP nodes for J721S2 SoC.

Message ID 20230811202252.3586926-1-a-nandan@ti.com (mailing list archive)
Headers show
Series Add R5F and C7x DSP nodes for J721S2 SoC. | expand

Message

Apurva Nandan Aug. 11, 2023, 8:22 p.m. UTC
This series adds the R5F processor nodes and C7x DSP nodes for 
J721S2 SoC.

The first three patches adds the remote proc nodes to the SoC device
tree and the last two patches reserves the memory for remote proc IPCs
on J721S2 EVM board.

Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/

v3: Changelog:
1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
   which fixes the following dtbs_check for k3-am69-sk.dts
   - dsp@64800000: 'mboxes' is a required property
   - dsp@64800000: 'memory-region' is a required property
2) Split into separate patches for C7x and R5F

Link to v2:
https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/

v2:Changelog:
1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
2) Fixed mboxes property in for all cores in som dts

Link to v1:
https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/

Apurva Nandan (4):
  arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
  arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
  arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
    R5F
  arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
    C71x DSPs

Hari Nagalla (1):
  arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes

 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 106 +++++++++
 .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  40 ++++
 arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi  | 208 ++++++++++++++++++
 3 files changed, 354 insertions(+)

Comments

Andrew Davis Aug. 11, 2023, 8:31 p.m. UTC | #1
On 8/11/23 3:22 PM, Apurva Nandan wrote:
> This series adds the R5F processor nodes and C7x DSP nodes for
> J721S2 SoC.
> 
> The first three patches adds the remote proc nodes to the SoC device
> tree and the last two patches reserves the memory for remote proc IPCs
> on J721S2 EVM board.
> 
> Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/
> 
> v3: Changelog:
> 1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
>     which fixes the following dtbs_check for k3-am69-sk.dts
>     - dsp@64800000: 'mboxes' is a required property
>     - dsp@64800000: 'memory-region' is a required property
> 2) Split into separate patches for C7x and R5F

Thanks for taking care of these details, series LGTM,

Reviewed-by: Andrew Davis <afd@ti.com>

> 
> Link to v2:
> https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/
> 
> v2:Changelog:
> 1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
> 2) Fixed mboxes property in for all cores in som dts
> 
> Link to v1:
> https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/
> 
> Apurva Nandan (4):
>    arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
>    arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
>    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
>      R5F
>    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
>      C71x DSPs
> 
> Hari Nagalla (1):
>    arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes
> 
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 106 +++++++++
>   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  40 ++++
>   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi  | 208 ++++++++++++++++++
>   3 files changed, 354 insertions(+)
>
Nishanth Menon Aug. 11, 2023, 9:14 p.m. UTC | #2
On 15:31-20230811, Andrew Davis wrote:
> On 8/11/23 3:22 PM, Apurva Nandan wrote:
> > This series adds the R5F processor nodes and C7x DSP nodes for
> > J721S2 SoC.
> > 
> > The first three patches adds the remote proc nodes to the SoC device
> > tree and the last two patches reserves the memory for remote proc IPCs
> > on J721S2 EVM board.
> > 
> > Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/
> > 
> > v3: Changelog:
> > 1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
> >     which fixes the following dtbs_check for k3-am69-sk.dts
> >     - dsp@64800000: 'mboxes' is a required property
> >     - dsp@64800000: 'memory-region' is a required property
> > 2) Split into separate patches for C7x and R5F
> 
> Thanks for taking care of these details, series LGTM,
> 
> Reviewed-by: Andrew Davis <afd@ti.com>
> 
> > 
> > Link to v2:
> > https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/
> > 
> > v2:Changelog:
> > 1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
> > 2) Fixed mboxes property in for all cores in som dts
> > 
> > Link to v1:
> > https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/
> > 
> > Apurva Nandan (4):
> >    arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
> >    arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
> >    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
> >      R5F
> >    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
> >      C71x DSPs
> > 
> > Hari Nagalla (1):
> >    arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes

We are still missing arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi which is
a TI product.

So, lets hold this series off from the immediate merge set at least.

> > 
> >   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 106 +++++++++
> >   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  40 ++++
> >   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi  | 208 ++++++++++++++++++
> >   3 files changed, 354 insertions(+)
> >