From patchwork Fri Aug 18 05:05:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 13357347 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F359C7113B for ; Fri, 18 Aug 2023 05:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=RK2EbIeOMecNDGts7mNEIiM+LH4GZRxF6qv1bpQRBbg=; b=yUnmGRQmVLf5zj zppJGs1UpmVJVHKRHHykqKJlnWz5UxyuP/aHMvvzOxasm4atj4dDcYESzfHLXu2rkcWmPgugw/iUu g91JFQSGAlXc6OuTPrFoKlC3ricEofXSLfjUFfAQWNopYPxeqQQ4bC6RTQdEKe8q5PI+EfctWWg3h D94woQ3LZfElAwj6X9B650eIYZcR5Wja5L4ns05REqG9jSoHhaibFErSb0xDiFCtjQzLVNd1hNC1z 8ywOKEKJOa8wIfbiOq78c1e8j+9TpqOMT98ZkvpYap4pfZ/iU8fxhDfw9H6SLAmWwA13+DVdxyJLU xG2iR6R/AXmRF1l28pMg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWrgH-007iRo-1T; Fri, 18 Aug 2023 05:05:53 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWrgD-007iQL-0V for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 05:05:51 +0000 Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RRqVR4MKZzNmnJ; Fri, 18 Aug 2023 13:02:07 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 18 Aug 2023 13:05:39 +0800 From: Ruan Jinjie To: , , , , , , , , , , , CC: Subject: [PATCH net-next v2 0/3] net: Update and fix return value check for vcap_get_rule() Date: Fri, 18 Aug 2023 13:05:02 +0800 Message-ID: <20230818050505.3634668-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_220549_494129_01F6D246 X-CRM114-Status: UNSURE ( 9.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org As Simon Horman suggests, update vcap_get_rule() to always return an ERR_PTR() and update the error detection conditions to use IS_ERR(), which would be more cleaner. So se IS_ERR() to update the return value and fix the issue in lan966x_ptp_add_trap(). Changes in v2: - Update vcap_get_rule() to always return an ERR_PTR(). - Update the return value fix in lan966x_ptp_add_trap(). - Update the return value check in sparx5_tc_free_rule_resources(). Ruan Jinjie (3): net: microchip: vcap api: Always return ERR_PTR for vcap_get_rule() net: lan966x: Fix return value check for vcap_get_rule() net: microchip: sparx5: Update return value check for vcap_get_rule() drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c | 4 ++-- drivers/net/ethernet/microchip/sparx5/sparx5_tc_flower.c | 2 +- drivers/net/ethernet/microchip/vcap/vcap_api.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Simon Horman