From patchwork Fri Aug 25 02:39:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 13364937 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D127C3DA6F for ; Fri, 25 Aug 2023 02:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:Mime-Version:Message-Id :Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=R/xd1/oo6uQmwiltt7BNEKQwPMP4ixY1Qd/u9MawrzU=; b=16qCnSSuJDjyMl teUuwUSayvDboAgqniOK7feLiJqY4+MobuSmL0sjF3OeNLDuAY3VBKLrqsjmyffiHmIFeUg6b3sn0 Y++xQx4wSePX7IimkqxS9F2lpqYaQioovYpDOTRCENSdPsJgAm+hritSjIZihzkR2KSe1aFIoq4RI 5KV2lRekWuWGljfPpeUKXgicit/k/tPQv12676vO9cSi3W+CrM+6svoqYLQIidKSFPP4kZsNxIaYD Vj+0VnQ6f0XGpe0yId3W64TJn04+vw07lOPXsYQHNaHnv9fvFf4r38cmPvGvUjMxy8zQLDXCTdTXH O1fTQTtePqgxvMjcv7Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZMkT-0048Jv-1i; Fri, 25 Aug 2023 02:40:33 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZMkQ-0048Ih-1M for linux-arm-kernel@lists.infradead.org; Fri, 25 Aug 2023 02:40:31 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5925f39aa5cso12516207b3.1 for ; Thu, 24 Aug 2023 19:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692931227; x=1693536027; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=9y0R0T/KYoRSkCgPsetHA/E7ag4fZJml6jv6nZDJg9Q=; b=lgMPZ9u2Li+a94DkzByZ+jgOm9cM0gX+J1LFEJnVHnhMY8aW+ZctJVGNUG54bt1wrO LvHQf308xkPh+3/sj9S0wUsaFrisxoUbNwCKcmEC4hD1pY1NV0+L0GmfzZxZAjkijRY9 MAgkqwS7Ds3rfex5SPDQShFaTqHiMrngfMoU+Z3ZM9+VTlmnWKVXQ44+NzSwrgDwChNs zLz3hiZ280SVTpqXyMA2qrEQ3xOtA+eS6YvbXOjE7WqNe/op3qVmxwWbZ74VRJ054Nzn Y8TY1O4rEqdUN6vjqPFYC/bnAIcGYF2T8bR9kGMrZl92slRrctI3dMiCVoHzuSfMz4OZ BK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692931227; x=1693536027; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9y0R0T/KYoRSkCgPsetHA/E7ag4fZJml6jv6nZDJg9Q=; b=lEhOjmbOjPqWJd5WuevWegkQihzaZLkAsU35Ca8fdZTW43mgwmYUhJIBk8aRya0GC4 5dQPcMhncO688IKMUizEP6Ir6u8PtEEOgN9UTuPuiUaBfn8jI4Bapxesd+9N2sLF1pW7 PHxWGRXcc6ZTB53Idns2wQoph0IlKY2G8kKFfip734GgZ6GPmJJ2taWrj23XtIqzcQ6b VJY9OlFFq53JNlvoU9xgC4DPn3+AVXjnjdefpHeWBsIGlFssEIR+CFhNi2JJBI0yf8Dv inCklVroVr5Hv9HKPwfoMxpVKYETPiE8Qp3LdyJDaPgiTeXZkOjq2BD+XFWh2+YPZS2R vE8A== X-Gm-Message-State: AOJu0Yz9y8woxrtireOyYv3A4r2+5oyS6BvsdfP69dmo32ICi9cWiWZ3 zg0mhPXJcI+nQ782loOQA2JmpMhIAoVS X-Google-Smtp-Source: AGHT+IEB53pqv6HCic/xx2KLuoXmwH5iUnq0oTL0ZppgE2SwkTZgpvnxmDyHuX/w5KJ70BlN5o0QKPx9YKY0 X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:449e:d47b:bc6b:cb6b]) (user=irogers job=sendgmr) by 2002:a05:690c:2fc2:b0:589:a533:405b with SMTP id ex2-20020a05690c2fc200b00589a533405bmr379315ywb.3.1692931227754; Thu, 24 Aug 2023 19:40:27 -0700 (PDT) Date: Thu, 24 Aug 2023 19:39:56 -0700 Message-Id: <20230825024002.801955-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.rc2.253.gd59a3bf2b4-goog Subject: [PATCH v2 0/6] Fix missing caps, fix unnecessary casting/checking From: Ian Rogers To: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Kan Liang , Ravi Bangoria , Suzuki Poulouse , Kajol Jain , Athira Rajeev , Ming Wang , Huacai Chen , Sean Christopherson , K Prateek Nayak , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Wei Li X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_194030_484992_C339BD14 X-CRM114-Status: GOOD ( 12.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wei Li reported an issue where writing PMU caps for ARM was broken. Patch 1 addresses this issue. Patch 2 removes unnecessary checks on a PMU's name by ensuring the fake PMU has a name. Types are updated to have a const as a consequence and a cleanup of the use of types is done for struct pmu's variable name. This was motivated by the discussion: https://lore.kernel.org/lkml/20230818171952.3719251-1-irogers@google.com/ Patches 3-5 repeat the const cleanup on struct pmu's name with the variables id and config in struct pmu and struct parse_events_term respectively. This is done for consistency with patch 2. Patch 6 tidies casts around libslang and removes workarounds for libslang support needed for a libslang older than 15 years - let's say nobody cares about a libslang that is this old. Ian Rogers (6): perf header: Fix missing PMU caps perf pmu: Remove logic for PMU name being NULL perf parse-events: Make term's config const perf pmu: Make id const and add missing free perf build-id: Simplify build_id_cache__cachedir perf tui slang: Tidy casts tools/perf/arch/arm64/util/mem-events.c | 2 +- tools/perf/arch/powerpc/util/mem-events.c | 6 ++-- tools/perf/arch/x86/util/mem-events.c | 8 ++--- tools/perf/arch/x86/util/pmu.c | 10 +++--- tools/perf/builtin-list.c | 2 +- tools/perf/tests/pmu-events.c | 20 ++++++------ tools/perf/tests/pmu.c | 18 +++++------ tools/perf/ui/Build | 2 -- tools/perf/ui/browser.c | 6 ++-- tools/perf/ui/browsers/Build | 5 --- tools/perf/ui/libslang.h | 20 +++--------- tools/perf/ui/tui/helpline.c | 2 +- tools/perf/ui/tui/setup.c | 2 +- tools/perf/ui/tui/util.c | 12 +++---- tools/perf/util/build-id.c | 6 ++-- tools/perf/util/env.c | 8 ++--- tools/perf/util/header.c | 39 ++++++++++------------- tools/perf/util/mem-events.c | 16 +++++----- tools/perf/util/mem-events.h | 2 +- tools/perf/util/parse-events.c | 17 ++++------ tools/perf/util/parse-events.h | 6 ++-- tools/perf/util/parse-events.y | 2 +- tools/perf/util/pmu.c | 19 ++++++----- tools/perf/util/pmu.h | 10 +++--- 24 files changed, 105 insertions(+), 135 deletions(-)