mbox series

[V3,0/6] Power: T7: add power domain driver

Message ID 20230829020404.4058677-1-xianwei.zhao@amlogic.com (mailing list archive)
Headers show
Series Power: T7: add power domain driver | expand

Message

Xianwei Zhao Aug. 29, 2023, 2:03 a.m. UTC
First patch is that remove C3 some power domain ALWAYS_ON property.
Second patch is that add driver to support power parent node. 
Third patch is that turn on power if initial power domain with
"AWAY_ON" property state is off.

Other patchs adds power controller driver support for Amlogic T7 SoC.

Changes Since v2:
 -Modify subject.
 -Define PWRC_NO_PARENT UINT_MAX
 -Remove modification that transform is_off into 1 or 0 using !!

Changes Since v1:
 -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
 -Modify T7_NIC flag  "ALWAYS_ON"

xianwei.zhao (6):
  genpd: amlogic: modify some power domains property
  genpd: amlogic: add driver to support power parent node
  genpd: amlogic: init power domain state
  dt-bindings: power: add Amlogic T7 power domains
  genpd: amlogic: Add support for T7 power domains controller
  arm64: dts: amlogic: t7: add power domain controller node

 .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
 drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
 include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
 4 files changed, 185 insertions(+), 14 deletions(-)
 create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h


base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70

Comments

Neil Armstrong Sept. 8, 2023, 12:40 p.m. UTC | #1
Hi,

On 29/08/2023 04:03, Xianwei Zhao wrote:
> First patch is that remove C3 some power domain ALWAYS_ON property.
> Second patch is that add driver to support power parent node.
> Third patch is that turn on power if initial power domain with
> "AWAY_ON" property state is off.
> 
> Other patchs adds power controller driver support for Amlogic T7 SoC.

Please re-send to Ulf Hansson <ulf.hansson@linaro.org> and
linux-pm@vger.kernel.org since this driver has moved to the
GENERIC PM DOMAIN PROVIDERS subsystem.

I'll take the DT patch since bindings patch was reviewed.

Thanks,
Neil

> 
> Changes Since v2:
>   -Modify subject.
>   -Define PWRC_NO_PARENT UINT_MAX
>   -Remove modification that transform is_off into 1 or 0 using !!
> 
> Changes Since v1:
>   -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
>   -Modify T7_NIC flag  "ALWAYS_ON"
> 
> xianwei.zhao (6):
>    genpd: amlogic: modify some power domains property
>    genpd: amlogic: add driver to support power parent node
>    genpd: amlogic: init power domain state
>    dt-bindings: power: add Amlogic T7 power domains
>    genpd: amlogic: Add support for T7 power domains controller
>    arm64: dts: amlogic: t7: add power domain controller node
> 
>   .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
>   drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
>   include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
>   4 files changed, 185 insertions(+), 14 deletions(-)
>   create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h
> 
> 
> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
Neil Armstrong Sept. 8, 2023, 12:45 p.m. UTC | #2
On 08/09/2023 14:40, Neil Armstrong wrote:
> Hi,
> 
> On 29/08/2023 04:03, Xianwei Zhao wrote:
>> First patch is that remove C3 some power domain ALWAYS_ON property.
>> Second patch is that add driver to support power parent node.
>> Third patch is that turn on power if initial power domain with
>> "AWAY_ON" property state is off.
>>
>> Other patchs adds power controller driver support for Amlogic T7 SoC.
> 
> Please re-send to Ulf Hansson <ulf.hansson@linaro.org> and
> linux-pm@vger.kernel.org since this driver has moved to the
> GENERIC PM DOMAIN PROVIDERS subsystem.
> 
> I'll take the DT patch since bindings patch was reviewed.

In fact I'll need Ulf to provide me an immutable branch or tag with
the bindings in order for me to apply the DT patch.

Neil

> 
> Thanks,
> Neil
> 
>>
>> Changes Since v2:
>>   -Modify subject.
>>   -Define PWRC_NO_PARENT UINT_MAX
>>   -Remove modification that transform is_off into 1 or 0 using !!
>>
>> Changes Since v1:
>>   -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
>>   -Modify T7_NIC flag  "ALWAYS_ON"
>>
>> xianwei.zhao (6):
>>    genpd: amlogic: modify some power domains property
>>    genpd: amlogic: add driver to support power parent node
>>    genpd: amlogic: init power domain state
>>    dt-bindings: power: add Amlogic T7 power domains
>>    genpd: amlogic: Add support for T7 power domains controller
>>    arm64: dts: amlogic: t7: add power domain controller node
>>
>>   .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
>>   drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
>>   include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
>>   4 files changed, 185 insertions(+), 14 deletions(-)
>>   create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h
>>
>>
>> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
>
Xianwei Zhao Sept. 11, 2023, 2:29 a.m. UTC | #3
Hi Neil,
    Thanks.

On 2023/9/8 20:45, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
> 
> On 08/09/2023 14:40, Neil Armstrong wrote:
>> Hi,
>>
>> On 29/08/2023 04:03, Xianwei Zhao wrote:
>>> First patch is that remove C3 some power domain ALWAYS_ON property.
>>> Second patch is that add driver to support power parent node.
>>> Third patch is that turn on power if initial power domain with
>>> "AWAY_ON" property state is off.
>>>
>>> Other patchs adds power controller driver support for Amlogic T7 SoC.
>>
>> Please re-send to Ulf Hansson <ulf.hansson@linaro.org> and
>> linux-pm@vger.kernel.org since this driver has moved to the
>> GENERIC PM DOMAIN PROVIDERS subsystem.
>>
>> I'll take the DT patch since bindings patch was reviewed.
> 
> In fact I'll need Ulf to provide me an immutable branch or tag with
> the bindings in order for me to apply the DT patch.
> 
Will res-send.
> Neil
> 
>>
>> Thanks,
>> Neil
>>
>>>
>>> Changes Since v2:
>>>   -Modify subject.
>>>   -Define PWRC_NO_PARENT UINT_MAX
>>>   -Remove modification that transform is_off into 1 or 0 using !!
>>>
>>> Changes Since v1:
>>>   -Fix license from "GPL-2.0-only OR .*" to "GPL-2.0-only OR MIT".
>>>   -Modify T7_NIC flag  "ALWAYS_ON"
>>>
>>> xianwei.zhao (6):
>>>    genpd: amlogic: modify some power domains property
>>>    genpd: amlogic: add driver to support power parent node
>>>    genpd: amlogic: init power domain state
>>>    dt-bindings: power: add Amlogic T7 power domains
>>>    genpd: amlogic: Add support for T7 power domains controller
>>>    arm64: dts: amlogic: t7: add power domain controller node
>>>
>>>   .../power/amlogic,meson-sec-pwrc.yaml         |   3 +-
>>>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   6 +
>>>   drivers/genpd/amlogic/meson-secure-pwrc.c     | 127 ++++++++++++++++--
>>>   include/dt-bindings/power/amlogic,t7-pwrc.h   |  63 +++++++++
>>>   4 files changed, 185 insertions(+), 14 deletions(-)
>>>   create mode 100644 include/dt-bindings/power/amlogic,t7-pwrc.h
>>>
>>>
>>> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
>>
>
Neil Armstrong Sept. 11, 2023, 3:09 p.m. UTC | #4
Hi,

On Tue, 29 Aug 2023 10:03:58 +0800, Xianwei Zhao wrote:
> First patch is that remove C3 some power domain ALWAYS_ON property.
> Second patch is that add driver to support power parent node.
> Third patch is that turn on power if initial power domain with
> "AWAY_ON" property state is off.
> 
> Other patchs adds power controller driver support for Amlogic T7 SoC.
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.7/arm64-dt)

[6/6] arm64: dts: amlogic: t7: add power domain controller node
      https://git.kernel.org/amlogic/c/5355699dabac3c97492a30e6e01820fcaae11218

These changes has been applied on the intermediate git tree [1].

The v6.7/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git