mbox series

[net-next,0/4] dpll: add phase offset and phase adjust

Message ID 20230905232610.1403647-1-arkadiusz.kubalewski@intel.com (mailing list archive)
Headers show
Series dpll: add phase offset and phase adjust | expand

Message

Kubalewski, Arkadiusz Sept. 5, 2023, 11:26 p.m. UTC
This RFC is to start discussion over extending dpll interface
with possibility to:
- read a phase offset between signals on pin and dpll,
- adjust a phase of pin's signal.

The RFC is based on latest version of dpll interface submitted for
net-next [1].

[1] https://lore.kernel.org/netdev/20230824213132.827338-1-vadim.fedorenko@linux.dev/

Arkadiusz Kubalewski (4):
  dpll: docs: add support for pin signal phase offset/adjust
  dpll: spec: add support for pin-dpll signal phase offset/adjust
  dpll: netlink/core: add support for pin-dpll signal phase
    offset/adjust
  ice: dpll: implement phase related callbacks

 Documentation/driver-api/dpll.rst         |  53 ++++-
 Documentation/netlink/specs/dpll.yaml     |  33 +++-
 drivers/dpll/dpll_netlink.c               |  99 +++++++++-
 drivers/dpll/dpll_nl.c                    |   8 +-
 drivers/dpll/dpll_nl.h                    |   2 +-
 drivers/net/ethernet/intel/ice/ice_dpll.c | 224 +++++++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_dpll.h |  10 +-
 include/linux/dpll.h                      |  18 ++
 include/uapi/linux/dpll.h                 |   8 +-
 9 files changed, 443 insertions(+), 12 deletions(-)

Comments

Jiri Pirko Sept. 6, 2023, 8:37 a.m. UTC | #1
Wed, Sep 06, 2023 at 01:26:06AM CEST, arkadiusz.kubalewski@intel.com wrote:
>This RFC is to start discussion over extending dpll interface
>with possibility to:
>- read a phase offset between signals on pin and dpll,
>- adjust a phase of pin's signal.

1) RFC patches should be marked as such
2) I suggest to postpone this after the first dpll patchset is merged

>
>The RFC is based on latest version of dpll interface submitted for
>net-next [1].
>
>[1] https://lore.kernel.org/netdev/20230824213132.827338-1-vadim.fedorenko@linux.dev/
>
>Arkadiusz Kubalewski (4):
>  dpll: docs: add support for pin signal phase offset/adjust
>  dpll: spec: add support for pin-dpll signal phase offset/adjust
>  dpll: netlink/core: add support for pin-dpll signal phase
>    offset/adjust
>  ice: dpll: implement phase related callbacks
>
> Documentation/driver-api/dpll.rst         |  53 ++++-
> Documentation/netlink/specs/dpll.yaml     |  33 +++-
> drivers/dpll/dpll_netlink.c               |  99 +++++++++-
> drivers/dpll/dpll_nl.c                    |   8 +-
> drivers/dpll/dpll_nl.h                    |   2 +-
> drivers/net/ethernet/intel/ice/ice_dpll.c | 224 +++++++++++++++++++++-
> drivers/net/ethernet/intel/ice/ice_dpll.h |  10 +-
> include/linux/dpll.h                      |  18 ++
> include/uapi/linux/dpll.h                 |   8 +-
> 9 files changed, 443 insertions(+), 12 deletions(-)
>
>-- 
>2.38.1
>
Kubalewski, Arkadiusz Sept. 6, 2023, 10:30 a.m. UTC | #2
>From: Jiri Pirko <jiri@resnulli.us>
>Sent: Wednesday, September 6, 2023 10:38 AM
>
>Wed, Sep 06, 2023 at 01:26:06AM CEST, arkadiusz.kubalewski@intel.com wrote:
>>This RFC is to start discussion over extending dpll interface with
>>possibility to:
>>- read a phase offset between signals on pin and dpll,
>>- adjust a phase of pin's signal.
>
>1) RFC patches should be marked as such

That is true, sorry about that, will fix it if there would be v2.

>2) I suggest to postpone this after the first dpll patchset is merged

Well this is exactly only to start discussion, I will resubmit the patches
after the merge of dpll, although we can decide some details already.

Thank you!
Arkadiusz

>
>>
>>The RFC is based on latest version of dpll interface submitted for
>>net-next [1].
>>
>>[1]
>>https://lore.kernel.org/netdev/20230824213132.827338-1-vadim.fedorenko@
>>linux.dev/
>>
>>Arkadiusz Kubalewski (4):
>>  dpll: docs: add support for pin signal phase offset/adjust
>>  dpll: spec: add support for pin-dpll signal phase offset/adjust
>>  dpll: netlink/core: add support for pin-dpll signal phase
>>    offset/adjust
>>  ice: dpll: implement phase related callbacks
>>
>> Documentation/driver-api/dpll.rst         |  53 ++++-
>> Documentation/netlink/specs/dpll.yaml     |  33 +++-
>> drivers/dpll/dpll_netlink.c               |  99 +++++++++-
>> drivers/dpll/dpll_nl.c                    |   8 +-
>> drivers/dpll/dpll_nl.h                    |   2 +-
>> drivers/net/ethernet/intel/ice/ice_dpll.c | 224 +++++++++++++++++++++-
>> drivers/net/ethernet/intel/ice/ice_dpll.h |  10 +-
>> include/linux/dpll.h                      |  18 ++
>> include/uapi/linux/dpll.h                 |   8 +-
>> 9 files changed, 443 insertions(+), 12 deletions(-)
>>
>>--
>>2.38.1
>>