From patchwork Mon Oct 23 07:18:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13432447 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CC56C001E0 for ; Mon, 23 Oct 2023 07:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:MIME-Version:Message-Id:Date: Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=gK82Lrb/KqrSIzocMj3L8BQ23QuaXQ8Z93n6tY246uc=; b=RphnnSmMp6/kMo WpUCfinHM40K2lkvqkiqrci89N0tvMd4paKbNKb1r0a8S7sEho40S/Zjpq5puwn4/FidWOUUewAYx I8YaApG9qsSMCg5TqMxEbyFDQLmCiOJBgx7uRG9XIRjasZ+JqLtqv0ZCCugsqtofxqD3knTy6m9My bRwo1tBvjaOda+ArB2uwkKehD4sMn/LSbO0daDp0SnDu1pu5fqMmbCOFRmn1UgcJojUC9YA45/dV8 eGqJqw9g0WTB5TPxQOcuZEPKgyz0FbQH4kEZyvmfBrfsfe8Ihwae7zrw7VZUOxUGqsMhSXkVhyyyk v370/D60DyKTgdPaxAeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qupDU-006czU-2u; Mon, 23 Oct 2023 07:19:12 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qupDR-006cyG-1P for linux-arm-kernel@lists.infradead.org; Mon, 23 Oct 2023 07:19:11 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-507a55302e0so3902566e87.0 for ; Mon, 23 Oct 2023 00:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698045547; x=1698650347; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=V6S45ihz7Bjy9mA8Op/n3MFfIjFItEt+vr7En/kunok=; b=jhOmEV7zE/jUiQAlhwjiIL9/h5lrS9Av+EJ0G0ANwBHK7zjeOofXO6te/nXhgzVsrO +lo96b9vvyi2hhfH1E4nhlMIUq/xzT0NT/8y2LOvC3Qq8yS7hH4vnWAn7WcQHeTFTIRl F5kHqxaVouScVzwxWsIKRu3HphOOayrJLqyqw5FBTbX1IEC27DGoZfbHclyeNZuYax7f 4iLeSPqkjppqlUg1xlnwTQMDAiI5bvgE4tQE2gQegCZm3mrcinNd0+iZ7FbcRQ9OQ+3E 9PnAgosh5Fq1yClDe81SyFhXFLaoi4e7a+v72z+e2KGmgyEyfBThDa6pZOTNfyt9wQB/ KO0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698045547; x=1698650347; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V6S45ihz7Bjy9mA8Op/n3MFfIjFItEt+vr7En/kunok=; b=Xbi5iQkflBT2O82eXBsdg4kNB9pAGP8Fto2C+VUcLu9jaf8473apqF4gwMWPSCAPGi JqNMnfOp0e+Yu8q6ENP1Numoo3lYo4EC2uvRGJwrMnWwEb2P+esvIX+dkbrMUvddEqtr 5ohth6CcUX4wFVaAOipCcXZgAkp1Bl1xnRpxnYFYFg/QCk4+WC9Mdh8DjFjGrSPS8GEV Xi2zv1diCkCtiT+XfdyxI9BE/q+q3/iCGBgVPc1wFwDTAqWdg/PPpTXdl7EvaA0Pnlh3 DkAApKlUfkvjAaIs8zyWkGEzAuGyzIfz3wOQf/HcJtvNEYurZB4NQ8nImIcrr7Zi7Btu 2zRg== X-Gm-Message-State: AOJu0Yx7g5BnODhMJVhdxhoYYBT139H0En3YffWmlGdRAHpmGTJ4r/vM PctFoRrH4dExBoI5TuDXmHc8Ag9RNkGf35uTuTM= X-Google-Smtp-Source: AGHT+IFKM2nSpNd3WVDpF/VRmFq9h8fCIDE8pLl2KqvSnJNj4ahDrxhFwmN/vM+qfF/affWMr5q96w== X-Received: by 2002:ac2:4827:0:b0:503:200f:47a9 with SMTP id 7-20020ac24827000000b00503200f47a9mr5859572lft.15.1698045546679; Mon, 23 Oct 2023 00:19:06 -0700 (PDT) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id w15-20020a05651204cf00b00507a682c049sm1578727lfq.215.2023.10.23.00.19.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 00:19:06 -0700 (PDT) From: Linus Walleij Subject: [PATCH net-next v5 0/7] Create a binding for the Marvell MV88E6xxx DSA switches Date: Mon, 23 Oct 2023 09:18:51 +0200 Message-Id: <20231023-marvell-88e6152-wan-led-v5-0-0e82952015a7@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAFseNmUC/3XQy2rDMBAF0F8JWldFL1vjrvIfIQs9Ro7AlYtsl ITgf4/qblyMl5fLnAvzIhPmiBP5Or1IxhKnOKYamo8TcTeTeqTR10wEE5IzBvTb5ILDQAGw5Y2 gd5PogL5mp6TVwYvgSb3+yRjiY5UvJOFMEz5mcq3NLU7zmJ/rZOFr/6dzeagXThllmgtrug4a7 c5DTCaPn2PuV7SILaSOIVEhHZxhYFsA1e0guYXaY0hWSILzSnU+WN7sILWFjh9X1C+EyFyrJUi L/6BlWd40z65UpAEAAA== To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Linus Walleij , Rob Herring , Vladimir Oltean X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_001909_479864_647BFB04 X-CRM114-Status: GOOD ( 20.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Marvell switches are lacking DT bindings. I need proper schema checking to add LED support to the Marvell switch. Just how it is, it can't go on like this. Some Device Tree fixes are included in the series, these remove the major and most annoying warnings fallout noise: some warnings remain, and these are of more serious nature, such as missing phy-mode. They can be applied individually, or to the networking tree with the rest of the patches. Thanks to Andrew Lunn, Vladimir Oltean and Russell King for excellent review and feedback! Signed-off-by: Linus Walleij --- Changes in v5: - Consistently rename switch@n to ethernet-switch@n in all cleanup patches - Consistently rename ports to ethernet-ports in all cleanup patches - Consistently rename all port@n to ethernet-port@n in all cleanup patches - Consistently rename all phy@n to ethernet-phy@n in all cleanup patches - Restore the nodename on the Turris MOX which has a U-Boot binary using the nodename as ABI, put in a blurb warning about this so no-one else tries to change it in the future. - Drop dsa.yaml direct references where we reference dsa.yaml#/$defs/ethernet-ports - Replace the conjured MV88E6xxx example by a better one based on imx6qdl plus strictly named nodes and added reset-gpios for a more complete example, and another example using the interrupt controller based on armada-381-netgear-gs110emx.dts - Bump lineage to 2008 as Vladimir says the code was developed starting 2008. - Link to v4: https://lore.kernel.org/r/20231018-marvell-88e6152-wan-led-v4-0-3ee0c67383be@linaro.org Changes in v4: - Rebase the series on top of Rob's series "dt-bindings: net: Child node schema cleanups" (or the hex numbered ports will not work) - Fix up a whitespacing error corrupting v3... - Add a new patch making the generic DSA binding require ports or ethernet-ports in the switch node. - Drop any corrections of port@a in the patches. - Drop oneOf in the compatible enum for mv88e6xxx - Use ethernet-switch, ethernet-ports and ethernet-phy in the examples - Transclude the dsa.yaml#/$defs/ethernet-ports define for ports - Move the DTS and binding fixes first, before the actual bindings, so they apply without (too many) warnings as fallout. - Drop stray colon in text. - Drop example port in the mveusb binding. - Link to v3: https://lore.kernel.org/r/20231016-marvell-88e6152-wan-led-v3-0-38cd449dfb15@linaro.org Changes in v3: - Fix up a related mvusb example in a different binding that the scripts were complaining about. - Fix up the wording on internal vs external MDIO buses in the mv88e6xxx binding document. - Remove pointless label and put the right rev-mii into the MV88E6060 schema. - Link to v2: https://lore.kernel.org/r/20231014-marvell-88e6152-wan-led-v2-0-7fca08b68849@linaro.org Changes in v2: - Break out a separate Marvell MV88E6060 binding file. I stand corrected. - Drop the idea to rely on nodename mdio-external for the external MDIO bus, keep the compatible, drop patch for the driver. - Fix more Marvell DT mistakes. - Fix NXP DT mistakes in a separate patch. - Fix Marvell ARM64 mistakes in a separate patch. - Link to v1: https://lore.kernel.org/r/20231013-marvell-88e6152-wan-led-v1-0-0712ba99857c@linaro.org --- Linus Walleij (7): dt-bindings: net: dsa: Require ports or ethernet-ports dt-bindings: net: mvusb: Fix up DSA example ARM: dts: marvell: Fix some common switch mistakes ARM: dts: nxp: Fix some common switch mistakes ARM64: dts: marvell: Fix some common switch mistakes dt-bindings: marvell: Rewrite MV88E6xxx in schema dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Documentation/devicetree/bindings/net/dsa/dsa.yaml | 6 + .../bindings/net/dsa/marvell,mv88e6060.yaml | 88 ++++++ .../bindings/net/dsa/marvell,mv88e6xxx.yaml | 330 +++++++++++++++++++++ .../devicetree/bindings/net/dsa/marvell.txt | 109 ------- .../devicetree/bindings/net/marvell,mvusb.yaml | 7 +- MAINTAINERS | 3 +- arch/arm/boot/dts/marvell/armada-370-rd.dts | 24 +- .../dts/marvell/armada-381-netgear-gs110emx.dts | 44 ++- .../dts/marvell/armada-385-clearfog-gtr-l8.dts | 38 +-- .../dts/marvell/armada-385-clearfog-gtr-s4.dts | 22 +- arch/arm/boot/dts/marvell/armada-385-linksys.dtsi | 18 +- .../boot/dts/marvell/armada-385-turris-omnia.dts | 20 +- arch/arm/boot/dts/marvell/armada-388-clearfog.dts | 20 +- .../boot/dts/marvell/armada-xp-linksys-mamba.dts | 18 +- arch/arm/boot/dts/nxp/vf/vf610-zii-cfu1.dts | 14 +- arch/arm/boot/dts/nxp/vf/vf610-zii-scu4-aib.dts | 70 ++--- arch/arm/boot/dts/nxp/vf/vf610-zii-spb4.dts | 18 +- arch/arm/boot/dts/nxp/vf/vf610-zii-ssmb-dtu.dts | 20 +- arch/arm/boot/dts/nxp/vf/vf610-zii-ssmb-spu3.dts | 18 +- .../dts/marvell/armada-3720-espressobin-ultra.dts | 14 +- .../boot/dts/marvell/armada-3720-espressobin.dtsi | 20 +- .../boot/dts/marvell/armada-3720-gl-mv1000.dts | 20 +- .../boot/dts/marvell/armada-3720-turris-mox.dts | 189 ++++++------ .../boot/dts/marvell/armada-7040-mochabin.dts | 24 +- .../dts/marvell/armada-8040-clearfog-gt-8k.dts | 22 +- arch/arm64/boot/dts/marvell/cn9130-crb.dtsi | 42 ++- 26 files changed, 761 insertions(+), 457 deletions(-) --- base-commit: 1c9be5fea84e409542a186893d219bf7cff22f5a change-id: 20231008-marvell-88e6152-wan-led-88c43b7fd2fd Best regards,