mbox series

[0/4] firmware: arm_ffa: Few fixes for FF-A notification support

Message ID 20231024-ffa-notification-fixes-v1-0-d552c0ec260d@arm.com (mailing list archive)
Headers show
Series firmware: arm_ffa: Few fixes for FF-A notification support | expand

Message

Sudeep Holla Oct. 24, 2023, 10:56 a.m. UTC
Hi,

These are set of small fixes around FF-A notification support that are
currently queued in -next. It is mostly to take care of absence of
the notification support in the firmware as well as allowing them to be
optional and continue initialisation even when the notification fails.

Regards,
Sudeep

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
Sudeep Holla (4):
      firmware: arm_ffa: Allow FF-A initialisation even when notification fails
      firmware: arm_ffa: Setup the partitions after the notification initialisation
      firmware: arm_ffa: Add checks for the notification enabled state
      firmware: arm_ffa: Fix FFA notifications cleanup path

 drivers/firmware/arm_ffa/driver.c | 65 ++++++++++++++++++++++++++-------------
 1 file changed, 44 insertions(+), 21 deletions(-)
---
base-commit: bcefd1bf63b1ec9bb08067021cf47f0fad96f395
change-id: 20231024-ffa-notification-fixes-9d5cf1e131ef

Best regards,

Comments

Jens Wiklander Oct. 25, 2023, 11:55 a.m. UTC | #1
Hi Sudeep,

On Tue, Oct 24, 2023 at 12:56 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> Hi,
>
> These are set of small fixes around FF-A notification support that are
> currently queued in -next. It is mostly to take care of absence of
> the notification support in the firmware as well as allowing them to be
> optional and continue initialisation even when the notification fails.
>
> Regards,
> Sudeep
>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> Sudeep Holla (4):
>       firmware: arm_ffa: Allow FF-A initialisation even when notification fails
>       firmware: arm_ffa: Setup the partitions after the notification initialisation
>       firmware: arm_ffa: Add checks for the notification enabled state
>       firmware: arm_ffa: Fix FFA notifications cleanup path
>
>  drivers/firmware/arm_ffa/driver.c | 65 ++++++++++++++++++++++++++-------------
>  1 file changed, 44 insertions(+), 21 deletions(-)

Works as expected with and without FF-A notifications enabled in the
secure world.

Tested-by: Jens Wiklander <jens.wiklander@linaro.org>

Cheers,
Jens

> ---
> base-commit: bcefd1bf63b1ec9bb08067021cf47f0fad96f395
> change-id: 20231024-ffa-notification-fixes-9d5cf1e131ef
>
> Best regards,
> --
> Regards,
> Sudeep
>
Sudeep Holla Oct. 25, 2023, 1:47 p.m. UTC | #2
On Wed, Oct 25, 2023 at 01:55:38PM +0200, Jens Wiklander wrote:
> Hi Sudeep,
>
> On Tue, Oct 24, 2023 at 12:56 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > Hi,
> >
> > These are set of small fixes around FF-A notification support that are
> > currently queued in -next. It is mostly to take care of absence of
> > the notification support in the firmware as well as allowing them to be
> > optional and continue initialisation even when the notification fails.
> >
> > Regards,
> > Sudeep
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > Sudeep Holla (4):
> >       firmware: arm_ffa: Allow FF-A initialisation even when notification fails
> >       firmware: arm_ffa: Setup the partitions after the notification initialisation
> >       firmware: arm_ffa: Add checks for the notification enabled state
> >       firmware: arm_ffa: Fix FFA notifications cleanup path
> >
> >  drivers/firmware/arm_ffa/driver.c | 65 ++++++++++++++++++++++++++-------------
> >  1 file changed, 44 insertions(+), 21 deletions(-)
>
> Works as expected with and without FF-A notifications enabled in the
> secure world.
>
> Tested-by: Jens Wiklander <jens.wiklander@linaro.org>

Thanks a lot for testing, much appreciated!

--
Regards,
Sudeep
Sudeep Holla Nov. 13, 2023, 12:25 p.m. UTC | #3
On Tue, 24 Oct 2023 11:56:16 +0100, Sudeep Holla wrote:
> These are set of small fixes around FF-A notification support that are
> currently queued in -next. It is mostly to take care of absence of
> the notification support in the firmware as well as allowing them to be
> optional and continue initialisation even when the notification fails.
> 
> Regards,
> Sudeep
>
> [...]

Applied to sudeep.holla/linux (for-next/ffa/fixes), thanks!

[1/4] firmware: arm_ffa: Allow FF-A initialisation even when notification fails
      (Dropped redundant return before applying as suggested by Jens)
      https://git.kernel.org/sudeep.holla/c/95520fc07743
[2/4] firmware: arm_ffa: Setup the partitions after the notification initialisation
      https://git.kernel.org/sudeep.holla/c/6f47023f7a52
[3/4] firmware: arm_ffa: Add checks for the notification enabled state
      https://git.kernel.org/sudeep.holla/c/f4bfcaee34bc
[4/4] firmware: arm_ffa: Fix FFA notifications cleanup path
      https://git.kernel.org/sudeep.holla/c/6d67cbe67a86
--
Regards,
Sudeep