| Message ID | 20231025060717.71895-1-umang.jain@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | staging: vc04_services: Use %p4cc to print fourcc | expand |
Hi, [add Raspberry Pi guys] Am 25.10.23 um 08:07 schrieb Umang Jain: > The following patch drop VCHIQ_FOURCC_AS_4CHARS macro in favour of %p4cc > format modifier to print FourCC codes in the logs. > > *Before this patch* > `mailbox: vchiq_core_msg debug: Sent Msg DATA(5) to AUDS s:1 d:62 len:20` > > *After this patch* > bcm2835_vchiq 3f00b840.mailbox: vchiq_core_msg debug: Sent Msg DATA(5) to SDUA little-endian (0x41554453) s:1 d:62 len:20 > > The inversion of AUDS to SDUA as per usage of %p4cc > Does it hamper readability ? Feedback is appreciated. looks good to me. Any concerns Phil or Dave? > > As documented in the commit message, the 'entity' char array length is > increased to hold more characters for the log output. Not doing so, > causes kernel stack corruption at runtime. > > Based on top of: > - [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk > > Umang Jain (1): > staging: vc04_services: Use %p4cc format modifier to print FourCC > codes > > .../interface/vchiq_arm/vchiq_arm.c | 20 +++++----- > .../interface/vchiq_arm/vchiq_core.c | 40 +++++++++---------- > .../interface/vchiq_arm/vchiq_core.h | 6 --- > .../interface/vchiq_arm/vchiq_dev.c | 7 ++-- > 4 files changed, 33 insertions(+), 40 deletions(-) >
The following patch drop VCHIQ_FOURCC_AS_4CHARS macro in favour of %p4cc format modifier to print FourCC codes in the logs. *Before this patch* `mailbox: vchiq_core_msg debug: Sent Msg DATA(5) to AUDS s:1 d:62 len:20` *After this patch* bcm2835_vchiq 3f00b840.mailbox: vchiq_core_msg debug: Sent Msg DATA(5) to SDUA little-endian (0x41554453) s:1 d:62 len:20 The inversion of AUDS to SDUA as per usage of %p4cc Does it hamper readability ? Feedback is appreciated. As documented in the commit message, the 'entity' char array length is increased to hold more characters for the log output. Not doing so, causes kernel stack corruption at runtime. Based on top of: - [PATCH v2 0/8] staging: vc04: Drop custom logging based on printk Umang Jain (1): staging: vc04_services: Use %p4cc format modifier to print FourCC codes .../interface/vchiq_arm/vchiq_arm.c | 20 +++++----- .../interface/vchiq_arm/vchiq_core.c | 40 +++++++++---------- .../interface/vchiq_arm/vchiq_core.h | 6 --- .../interface/vchiq_arm/vchiq_dev.c | 7 ++-- 4 files changed, 33 insertions(+), 40 deletions(-)