[0/9] staging: vc04_services: Smatch fixes and remove custom logging

Message

Umang Jain Nov. 7, 2023, 9:51 a.m. UTC

Patch 1/9 to 3/9 targets the warnings exposed by Smatch analysis.
Smatch fixes was sent earlier under "staging: vc04: Smatch analysis
fixes", but now I have patches on top of them, I have tied
these fixes in this series (so could be merged all at once).

This series also removes the vchiq_log_* macro and makes use of dev_dbg()
directly.

4/9 is just a drive-by patch to shorten function helper.
5/9 is bug fixup where NULL was passed instead of a struct device
pointer

6/9 to 7/9 removes each of the vchiq_log_* respectively.

This completes the following TODO item:

```
* Cleanup logging mechanism

The driver should probably be using the standard kernel logging mechanisms
such as dev_info, dev_dbg, and friends.
```

Umang Jain (9):
  staging: vc04_services: vchiq_core: Log through struct vchiq_instance
  staging: vc04_services: Log using pr_err() when vchiq_state is unset
  staging: vc04_services: bcm2835-camera: Remove redundant null check
  staging: vc04_services: Shorten helper function name
  staging: vc04_services: Do not pass NULL to vchiq_log_error()
  staging: vc04_services: Drop vchiq_log_error() in favour of dev_dbg
  staging: vc04_services: Drop vchiq_log_warning() in favour of dev_dbg
  staging: vc04_services: Drop vchiq_log_trace() in favour of dev_dbg
  staging: vc04_services: Drop vchiq_log_debug() in favour of dev_dbg

 .../bcm2835-camera/bcm2835-camera.c           |   7 +-
 drivers/staging/vc04_services/interface/TODO  |   5 -
 .../interface/vchiq_arm/vchiq_arm.c           | 223 +++++----
 .../interface/vchiq_arm/vchiq_connected.c     |   8 +-
 .../interface/vchiq_arm/vchiq_connected.h     |   4 +-
 .../interface/vchiq_arm/vchiq_core.c          | 463 ++++++++++--------
 .../interface/vchiq_arm/vchiq_core.h          |  36 +-
 .../interface/vchiq_arm/vchiq_dev.c           | 112 +++--
 8 files changed, 461 insertions(+), 397 deletions(-)


base-commit: d2f51b3516dade79269ff45eae2a7668ae711b25